From 05cfdf6a6adc26fa502e12d43c8c5bd882d47414 Mon Sep 17 00:00:00 2001
From: Daniel Cousens <github@dcousens.com>
Date: Mon, 14 Sep 2015 15:03:35 +1000
Subject: [PATCH] docs: remove inline endian-ness notes, no endianness
---
src/transaction.js | 2 +-
src/transaction_builder.js | 6 +++---
test/bitcoin.core.js | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/transaction.js b/src/transaction.js
index 3ddf84b..f284381 100644
--- a/src/transaction.js
+++ b/src/transaction.js
@@ -246,7 +246,7 @@ Transaction.prototype.getHash = function () {
}
Transaction.prototype.getId = function () {
- // TxHash is little-endian, we need big-endian
+ // transaction hash's are displayed in reverse order
return bufferutils.reverse(this.getHash()).toString('hex')
}
diff --git a/src/transaction_builder.js b/src/transaction_builder.js
index 7b599e8..36aed85 100644
--- a/src/transaction_builder.js
+++ b/src/transaction_builder.js
@@ -169,13 +169,13 @@ TransactionBuilder.fromTransaction = function (transaction, network) {
}
TransactionBuilder.prototype.addInput = function (txHash, vout, sequence, prevOutScript) {
- // is it a txId?
+ // is it a hex string?
if (typeof txHash === 'string') {
- // a txId is big-endian hex, we want a little-endian Buffer
+ // transaction hashs's are displayed in reverse order, un-reverse it
txHash = new Buffer(txHash, 'hex')
Array.prototype.reverse.call(txHash)
- // is it a Transaction?
+ // is it a Transaction object?
} else if (txHash instanceof Transaction) {
prevOutScript = txHash.outs[vout].script
txHash = txHash.getHash()
diff --git a/test/bitcoin.core.js b/test/bitcoin.core.js
index c5ca7d6..714280b 100644
--- a/test/bitcoin.core.js
+++ b/test/bitcoin.core.js
@@ -149,7 +149,7 @@ describe('Bitcoin-core', function () {
transaction.ins.forEach(function (txIn, i) {
var input = inputs[i]
- // reverse because test data is big-endian
+ // reverse because test data is reversed
var prevOutHash = bitcoin.bufferutils.reverse(new Buffer(input[0], 'hex'))
var prevOutIndex = input[1]
@@ -202,7 +202,7 @@ describe('Bitcoin-core', function () {
var inIndex = f[2]
var hashType = f[3]
- // reverse because test data is big-endian
+ // reverse because test data is reversed
var expectedHash = bitcoin.bufferutils.reverse(new Buffer(f[4], 'hex'))
var hashTypes = []