Commit graph

211 commits

Author SHA1 Message Date
Daniel Cousens
40f0c91162 Transaction: use TxIn/TxOut consistently 2014-06-16 14:21:38 +10:00
Daniel Cousens
8b5647b0b9 Transaction: remove TxIn/TxOut exports 2014-06-16 14:21:38 +10:00
Daniel Cousens
e49e1796d5 Transaction: remove untested TransactionIn constructor params 2014-06-15 00:40:28 +10:00
Daniel Cousens
8c5c0a13a6 Transaction: remove untested (and broken) functionality 2014-06-15 00:40:21 +10:00
Daniel Cousens
7e5af52cd1 Transaction: mass rename from SPK/SS to Input/Output
I think it is important we maintain some reasoning that an Input script
is actually a script signature, but in the end, these names are more
coherent and understandable when reasoning with our code.  So I think
its OK we break tradition with bitcoind.
2014-06-13 11:36:31 +10:00
Daniel Cousens
41c3b68293 templates: rename to scripts 2014-06-13 10:52:07 +10:00
Daniel Cousens
00cec9ce64 Script: move all templates to templates.js 2014-06-13 10:52:07 +10:00
Daniel Cousens
005ca31fb3 Transaction: remove unnecessary clone 2014-06-13 10:49:54 +10:00
Daniel Cousens
323f0612d0 Transaction: remove unnecessary Buffer copy 2014-06-13 10:49:53 +10:00
Daniel Cousens
9a72c7437b Script: adds Script.EMPTY constant 2014-06-13 10:49:08 +10:00
Daniel Cousens
f5005299d1 JSHint: remove defined but never used 2014-06-04 15:46:24 +10:00
Daniel Cousens
2f44628604 Transaction: refactor hashForSignature
Adds asserts to ensure only valid hashes are created (until the
implementation is complete).

Also uses `Script.without` to remove OP_CODESEPARATOR from the Scripts
as required by the protocol.
2014-05-29 16:06:19 +10:00
Daniel Cousens
54950c9abb Transaction: fix SIGHASH_* constant values 2014-05-29 16:06:19 +10:00
Daniel Cousens
db814439a3 Transaction: extract DEFAULT_SEQUENCE constant
Also fixes the bug when the sequence number is 0 and
`TransactionIn.defaultSequence` is used; resulting in an undefined
sequence number as it is undefined.
2014-05-29 16:06:19 +10:00
Daniel Cousens
58fd12e66d ecdsa: always use signature object 2014-05-24 16:25:38 +10:00
Daniel Cousens
2dec1375a1 ecdsa: use (r, s) values directly 2014-05-24 00:48:31 +10:00
Daniel Cousens
99a1b7274c Transaction: use the type embedded in the signature 2014-05-18 17:52:48 +10:00
Daniel Cousens
0468c4710c Transaction: rename (de)serialize to [to/from]Buffer 2014-05-17 00:09:13 +10:00
Daniel Cousens
e033a872c9 Transaction: rename hashTransactionForSignature to hashForSignature 2014-05-17 00:09:13 +10:00
Daniel Cousens
e27c97a791 ECPubKey/ECKey: separate to two files 2014-05-13 16:51:06 +10:00
Daniel Cousens
05e0d08098 BufferExt: rename to bufferutils 2014-05-13 16:46:12 +10:00
Daniel Cousens
614a213d44 Transaction: remove untested hash array support 2014-05-12 10:17:38 +10:00
Daniel Cousens
708aa03390 Transaction/Script: bitcoin network no longer implied
A Transaction (and its subsequent scripts) do not carry any network
specific information in the Bitcoin protocol.
Therefore they can not (without further context) produce the network
specific constants for the generation of the base58 Addresses.

As TransactionOut.address is used heavily throughout Wallet and other
areas of the library, this could not be entirely removed without a large
number of changes.
For now, TransactionOut.address is only defined in the case of
Tx.addOutput being used directly:

      Transaction.addOutput(address, value)
2014-05-08 10:59:58 +10:00
Daniel Cousens
0822def7e0 Script: add standard Script.create*ScriptPubKey
Extracts the two Script types out of Script.createOutputScript, and puts
them both under test.

Also renames Script.createMultiSigOutputScript to adhere to the same
convention.
2014-05-08 10:59:58 +10:00
Daniel Cousens
57b8afbdab Network: rename Network to Networks
This change removes the most common ambiguities.
As the network module is not representative of a class, the lower case
has been used.
2014-05-08 10:59:58 +10:00
Daniel Cousens
74e53b49a5 Script/Transaction: remove untested functions
These functions are not under test, and are unnecessary bloat due to a
confusing API.

Script.from*(asmStr) were two functions that attempted to parse ASM
codes and produce a script from this.
While useful, an parser can be introduced later under a single function
and under test... removed.

Although Script.extractPublicKeys implementation is likely to be correct,
it is not absolute in that what it returns is even strictly a set of
public keys.
It is a useful function, but can be done in a better way later,
probably checking against the Script templates instead.

Transaction.signWithKeys has some inherent undocumented behaviour, and it is not
clear when you would use it over just Transaction.addOutput and
Transaction.sign individually.  Nor does it mimic anything in the
bitcoind API... removed.
2014-05-08 10:59:58 +10:00
Daniel Cousens
76323a07d0 Transaction: restrict TxIn/TxOut constructor params
To keep this change minimal, both TxIn/TxOut still use the parameter
object for initialization.  TxOut accepts only the types it uses
internally, and not hex or byte arrays for scripts.

The clone is unnecessary as a TransactionOut is never mutated after its
creation.

This resulted in TransactionOut.scriptPubKey no longer being needed,
and was removed.  To access the scriptPubKey as a byte buffer, a user
can simply use:

	TransactionOut.script.toBuffer()

Unfortunately, this leaves TransactionOut in a sorry state of test.
Something that needs to be fixed.
2014-05-08 10:59:58 +10:00
Daniel Cousens
9a7e291d70 Transaction: fix incorrect outIndex type 2014-05-08 08:52:07 +10:00
Daniel Cousens
a77846701f Fixes network support for TxOut 2014-05-06 15:40:40 +10:00
Daniel Cousens
4012b82bec Fixes Transaction.addOutput(Address, Number) 2014-05-06 15:40:40 +10:00
Daniel Cousens
695eb64a3a Clarifies Transaction.addOutput param documentation 2014-05-06 15:40:40 +10:00
Daniel Cousens
baa568697b Transaction.deserialize no longer mutates input 2014-05-05 09:11:37 +10:00
Daniel Cousens
02013beda9 Renames variables to be more verbose 2014-05-05 09:11:37 +10:00
Daniel Cousens
b860daf70b Corrects endianness comments 2014-05-04 17:31:47 +10:00
Daniel Cousens
87048d3b4e Adds performance notes 2014-05-04 17:31:47 +10:00
Daniel Cousens
a8cf2fdd9e Changes internal serialization to use Buffers instead 2014-05-04 17:31:22 +10:00
Daniel Cousens
10ee5532c3 Serialize now returns a buffer 2014-05-04 15:37:25 +10:00
Daniel Cousens
09c6a787d9 Changes sequence number to an actual Number 2014-05-04 15:37:25 +10:00
Daniel Cousens
bb80eda218 Merge pull request #165 from bitcoinjs/bigi-monkey-patching-no-more
Upgrade bigi & remove monkey patching
2014-05-04 07:39:19 +10:00
Wei Lu
1e6b283f9a Remove Number.isFinite check on tx input index 2014-05-03 10:19:38 +08:00
Wei Lu
af1f121fd4 upgrade bigi & remove monkey patching 2014-05-03 10:04:54 +08:00
Daniel Cousens
69c0497038 Renames createInputScript to createPubKeyHashScriptSig 2014-04-26 04:04:19 +10:00
Daniel Cousens
a4e68d142d Adds assertions for types in signScriptSig 2014-04-26 04:04:16 +10:00
Daniel Cousens
8ad8f6f169 Renames p2shsign to signScriptSig 2014-04-26 03:51:13 +10:00
Daniel Cousens
5546cae928 Removes type coercion for a stricter TX API 2014-04-26 03:51:13 +10:00
Daniel Cousens
9af8d95daf Removes applyMultisigs and adds setScriptSig 2014-04-26 03:51:13 +10:00
Daniel Cousens
ae60e6eb95 Replacse JSBN with bigi 2014-04-22 02:19:30 +10:00
Daniel Cousens
c44af2109e Uses typeof address === 'string' instead 2014-04-20 04:54:50 +10:00
Daniel Cousens
92f1c3e319 Fixes Transaction.addOutput() param handling to match documentation
Now (horrendously) supports other networks
2014-04-20 04:47:56 +10:00
Daniel Cousens
1d1306b054 Removes Address.fromPubKey and improves test vectors 2014-04-20 04:38:33 +10:00
Daniel Cousens
682ec133bb Migrates Address to stricter API subset 2014-04-18 17:12:29 +10:00
Daniel Cousens
b4f70dcdde Migrates ECKey to stricter API 2014-04-18 06:36:27 +10:00
Daniel Cousens
6de94856e3 Makes ECDSA capitalization consistent 2014-04-09 04:11:13 +10:00
Daniel Cousens
c99a576fbd Migrates all usage of crypto-js/sha256 to ./crypto 2014-04-08 23:07:46 +10:00
Daniel Cousens
81d9c8e759 Renames util.js to crypto.js 2014-04-08 22:00:28 +10:00
Wei Lu
93fe1b4c78 cosmetic standardization
[closes #56]
2014-03-31 11:47:47 +08:00
Daniel Cousens
8f7f50d555 Removes deprecated ECKey.export function 2014-03-29 18:12:02 +11:00
Daniel Cousens
63dd7c7dec Now uses varIntToNum 2014-03-26 19:11:37 +11:00
Wei Lu
8d2525dba1 allow feePerKb to be set to zero 2014-03-26 08:43:34 +08:00
Wei Lu
75218e784f Transaction fee calculation does not need BigInteger 2014-03-26 08:43:33 +08:00
Wei Lu
7bd312de71 get rid of magic numbers in fee estimation 2014-03-26 08:43:33 +08:00
Wei Lu
3d12d3b038 implement and use txOut.scriptPubKey 2014-03-26 08:43:32 +08:00
Wei Lu
b7d65fb757 Transaction is able to estimate fees 2014-03-26 08:43:31 +08:00
Wei Lu
c3880c0cdf script.toAddress -> script.getToAddress 2014-03-26 08:43:31 +08:00
Daniel Cousens
36af0223de Strict comparison operators with 0 2014-03-24 06:22:26 +11:00
Daniel Cousens
a062297be2 Uses Array.prototype.foreach for stricter scoping 2014-03-24 06:22:26 +11:00
Daniel Cousens
87453f1828 Fixes variable redeclarations 2014-03-24 06:22:26 +11:00
Daniel Cousens
ed137a3b9d Various stylistic changes 2014-03-24 06:22:26 +11:00
Daniel Cousens
f580516c06 Removes unused variables 2014-03-24 06:22:26 +11:00
Daniel Cousens
b40374e332 Changes to new version-less ECKey API 2014-03-22 19:12:26 +11:00
Kyle Drake
40881a7dd8
add back SIGHASH code to transaction 2014-03-20 19:15:15 -07:00
Kyle Drake
28e146431c
Many cleanups to Transaction, see detailed.
Default-ize the sequence rather than use a number, and default to bytes
for input. I doubt anybody ever uses this anyways.

Remove weird convenience code, and remove wallet logic. Checking a TX's
affects on a wallet should be managed by the wallet object.

Remove parsing for the weirder SIGHASH types. People use this library
for creating SIGHASH_ALL transactions, and I don't see the need to
support these other types at the moment since this library's more used
for wallets than for hardcore bitcoin tx analysis/creation. They weren't
tested anyways.

Add note about potentially improving performance by providing
pubkey/address. Deriving from the private key is slower, that
information should probably be cached by the end user.
2014-03-20 15:40:07 -07:00
Wei Lu
2e6ef6cb85 fix and add tests for addInput 2014-03-17 18:01:09 +08:00
Wei Lu
a5ee07f7f6 Add tests to transaction deserialization
lock_time -> locktime
2014-03-17 16:31:35 +08:00
Pablo Martin
2e26a137d5 require crypto-js/sha256 instead of ./crypto-js/sha256. 2014-03-16 03:02:04 +01:00
Pablo Martin
8f383be325 fix transaction hashing (was using Message.getHash incorrectly). 2014-03-16 02:42:49 +01:00
Wei Lu
3d6b66e811 move convert methods from util to convert 2014-03-11 09:52:48 +08:00
Wei Lu
9c15fa0cbf Merge pull request #57 from bitcoinjs/upgrade-crypto-js
Use crypto-js as a module from npm
2014-03-11 09:14:49 +08:00
Wei Lu
45e55a07b0 fix transaction serialization/deserialization
[closes #58]
2014-03-09 13:46:20 +08:00
Wei Lu
a281a5ab53 migrate crypto-js to 3.1.2 2014-03-09 09:49:24 +08:00
Wei Lu
bde9b13b15 remove isArray shim
[closes #40]
2014-03-03 11:27:19 +08:00
Vitalik Buterin
7919c8cfc5 Added auto-instantiators to classes 2014-01-10 15:17:53 -05:00
Vitalik Buterin
30e8b572d6 Added deterministic signing and added a public key class. Note that getPub should now be replaced with getPub().export('bytes') 2014-01-04 13:26:03 -05:00
vub
1780f4a98f Updated deterministic wallet; theoretically works now if properly combined with server 2013-12-01 21:52:07 -05:00
vub
93e50e9433 Started work on wallet, and added hex serialization 2013-11-20 13:00:49 -05:00
vub
aa22b9d89e Added a new way of adding an output to a transaction 2013-11-02 06:51:27 -04:00
vub
a34bc9e2ea Many small improvements 2013-11-02 06:20:09 -04:00
vub
45ec63d2f1 Whoops... 2013-10-21 15:33:35 -04:00
vub
274112005f Beefed up TransactionIn constructor 2013-10-21 14:07:38 -04:00
vub
f53a4e3ffa Added sign with keys method to transaction and did lots of small cleanups 2013-10-21 14:00:31 -04:00
vub
917822541c Fixed serialization bug 2013-10-15 01:24:13 -04:00
vub
7bfd72c8c4 Replaced bigints with plain integers for transaction values 2013-10-14 07:41:21 -04:00
vub
b8023389fd Reversed txhash 2013-10-08 13:41:20 -04:00
vub
8fb725f796 Made TransactionOut take numbers as input 2013-10-08 07:38:22 -04:00
vub
2bfa783be2 Added hash flipping to serialization and deserialization 2013-10-08 07:05:21 -04:00
vub
50f6333b0e Changed i -> index in Transaction.prototype.sign 2013-10-08 06:48:31 -04:00
vub
038f8d5d99 Removed direct references to Bitcoin 2013-10-08 06:45:13 -04:00
vub
a753f069a5 Fixed bug in numToBytes and util -> conv 2013-10-08 06:34:15 -04:00
vub
f95b08a576 Replaced Crypto.util and util (was a typo) with conv 2013-10-08 05:42:28 -04:00
vub
38ea108183 Bugfix 2013-10-08 05:38:00 -04:00
vub
cb70b4425b Substituted in numToBytes 2013-10-08 03:47:18 -04:00
vub
65abb85668 Added to convert.js and some more multisig methods 2013-10-08 02:55:52 -04:00
vub
e43d23235b Added some transaction methods, and removed all internal use of base64 2013-10-07 15:27:19 -04:00
vub
9922864da4 Added deserialization, made some modifications 2013-10-07 08:21:00 -04:00
Roman Shtylman
981203e982 fix transaction processing for wallets 2013-03-02 12:00:14 -05:00
Roman Shtylman
0faac29134 start to split into node commonjs style modules
- no longer is the global Bitcoin used for modules
- cleaner and more maintainable code
- add more tests
2013-02-17 00:40:14 -05:00
Stefan Thomas
c2ce224d1b Remove debugging statements. Fixes #8. 2012-08-17 02:00:02 +02:00
Stefan Thomas
09e8c6e184 Added comments. 2012-01-11 10:41:52 +01:00
Stefan Thomas
1a7fc9d063 Fixed indents. 2012-01-11 02:40:45 +01:00
Stefan Thomas
27ceffaee3 Split getDescription() into two functions. 2011-08-18 04:57:29 +01:00
Stefan Thomas
8b32d43335 Moved sources into src/ subdirectory. 2011-08-11 18:35:23 +01:00
Renamed from transaction.js (Browse further)