From 1e38d7fd4bae3d8307fbb26f8b3126033b42a743 Mon Sep 17 00:00:00 2001
From: "John C. Vernaleo" <john@netpurgatory.com>
Date: Wed, 2 Nov 2016 18:36:32 -0400
Subject: [PATCH] Switch to gometalint in goclean

This switches `goclean` to use `gometalint` instead of running each checking tool one at a time.  The `gometalint` tool runs them concurrently.

More importantly it will allow us to easily add additional linters as desired.
---
 .travis.yml |  3 ++-
 goclean.sh  | 11 ++++++++---
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 2b06aed2..feb00f67 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -8,7 +8,8 @@ install:
   - glide install
   - go install . ./cmd/...
   - go get -v golang.org/x/tools/cmd/cover
-  - go get -v github.com/golang/lint/golint
+  - go get -v github.com/alecthomas/gometalinter
+  - gometalinter --install
 script:
   - export PATH=$PATH:$HOME/gopath/bin
   - ./goclean.sh
diff --git a/goclean.sh b/goclean.sh
index c5ae2b1c..e7fc4457 100755
--- a/goclean.sh
+++ b/goclean.sh
@@ -5,13 +5,18 @@
 # 3. go vet        (http://golang.org/cmd/vet)
 # 4. race detector (http://blog.golang.org/race-detector)
 # 5. test coverage (http://blog.golang.org/cover)
+#
+# gometaling (github.com/alecthomas/gometalinter) is used to run each each
+# static checker.
 
 set -ex
 
 # Automatic checks
-test -z "$(go fmt $(glide novendor) | tee /dev/stderr)"
-test -z "$(for package in $(glide novendor); do golint $package; done | grep -v 'ALL_CAPS\|OP_' | tee /dev/stderr)"
-test -z "$(go vet $(glide novendor) 2>&1 | tee /dev/stderr)"
+test -z "$(gometalinter --disable-all \
+--enable=gofmt \
+--enable=golint \
+--enable=vet \
+--deadline=20s $(glide novendor) | grep -v 'ALL_CAPS\|OP_' 2>&1 | tee /dev/stderr)"
 env GORACE="halt_on_error=1" go test -v -race -tags rpctest $(glide novendor)
 
 # Run test coverage on each subdirectories and merge the coverage profile.