From 951f244f872b9caff19ecd3395e487f599e16a65 Mon Sep 17 00:00:00 2001 From: Josh Rickmar Date: Tue, 24 Feb 2015 10:15:15 -0500 Subject: [PATCH] Move calcPriority to the file where it's used. --- mempool.go | 47 +++++++++++++++++++++++++++++++++++++++++++++++ mining.go | 47 ----------------------------------------------- 2 files changed, 47 insertions(+), 47 deletions(-) diff --git a/mempool.go b/mempool.go index 590e8137..a59528ea 100644 --- a/mempool.go +++ b/mempool.go @@ -828,6 +828,53 @@ func calcInputValueAge(txDesc *TxDesc, txStore blockchain.TxStore, nextBlockHeig return totalInputAge } +// minInt is a helper function to return the minimum of two ints. This avoids +// a math import and the need to cast to floats. +func minInt(a, b int) int { + if a < b { + return a + } + return b +} + +// calcPriority returns a transaction priority given a transaction and the sum +// of each of its input values multiplied by their age (# of confirmations). +// Thus, the final formula for the priority is: +// sum(inputValue * inputAge) / adjustedTxSize +func calcPriority(tx *btcutil.Tx, serializedTxSize int, inputValueAge float64) float64 { + // In order to encourage spending multiple old unspent transaction + // outputs thereby reducing the total set, don't count the constant + // overhead for each input as well as enough bytes of the signature + // script to cover a pay-to-script-hash redemption with a compressed + // pubkey. This makes additional inputs free by boosting the priority + // of the transaction accordingly. No more incentive is given to avoid + // encouraging gaming future transactions through the use of junk + // outputs. This is the same logic used in the reference + // implementation. + // + // The constant overhead for a txin is 41 bytes since the previous + // outpoint is 36 bytes + 4 bytes for the sequence + 1 byte the + // signature script length. + // + // A compressed pubkey pay-to-script-hash redemption with a maximum len + // signature is of the form: + // [OP_DATA_73 <73-byte sig> + OP_DATA_35 + {OP_DATA_33 + // <33 byte compresed pubkey> + OP_CHECKSIG}] + // + // Thus 1 + 73 + 1 + 1 + 33 + 1 = 110 + overhead := 0 + for _, txIn := range tx.MsgTx().TxIn { + // Max inputs + size can't possibly overflow here. + overhead += 41 + minInt(110, len(txIn.SignatureScript)) + } + + if overhead >= serializedTxSize { + return 0.0 + } + + return inputValueAge / float64(serializedTxSize-overhead) +} + // StartingPriority calculates the priority of this tx descriptor's underlying // transaction relative to when it was first added to the mempool. The result // is lazily computed and then cached for subsequent function calls. diff --git a/mining.go b/mining.go index 83002a47..d6dc4c6d 100644 --- a/mining.go +++ b/mining.go @@ -174,15 +174,6 @@ type BlockTemplate struct { validPayAddress bool } -// minInt is a helper function to return the minimum of two ints. This avoids -// a math import and the need to cast to floats. -func minInt(a, b int) int { - if a < b { - return a - } - return b -} - // mergeTxStore adds all of the transactions in txStoreB to txStoreA. The // result is that txStoreA will contain all of its original transactions plus // all of the transactions in txStoreB. @@ -249,44 +240,6 @@ func createCoinbaseTx(coinbaseScript []byte, nextBlockHeight int64, addr btcutil return btcutil.NewTx(tx), nil } -// calcPriority returns a transaction priority given a transaction and the sum -// of each of its input values multiplied by their age (# of confirmations). -// Thus, the final formula for the priority is: -// sum(inputValue * inputAge) / adjustedTxSize -func calcPriority(tx *btcutil.Tx, serializedTxSize int, inputValueAge float64) float64 { - // In order to encourage spending multiple old unspent transaction - // outputs thereby reducing the total set, don't count the constant - // overhead for each input as well as enough bytes of the signature - // script to cover a pay-to-script-hash redemption with a compressed - // pubkey. This makes additional inputs free by boosting the priority - // of the transaction accordingly. No more incentive is given to avoid - // encouraging gaming future transactions through the use of junk - // outputs. This is the same logic used in the reference - // implementation. - // - // The constant overhead for a txin is 41 bytes since the previous - // outpoint is 36 bytes + 4 bytes for the sequence + 1 byte the - // signature script length. - // - // A compressed pubkey pay-to-script-hash redemption with a maximum len - // signature is of the form: - // [OP_DATA_73 <73-byte sig> + OP_DATA_35 + {OP_DATA_33 - // <33 byte compresed pubkey> + OP_CHECKSIG}] - // - // Thus 1 + 73 + 1 + 1 + 33 + 1 = 110 - overhead := 0 - for _, txIn := range tx.MsgTx().TxIn { - // Max inputs + size can't possibly overflow here. - overhead += 41 + minInt(110, len(txIn.SignatureScript)) - } - - if overhead >= serializedTxSize { - return 0.0 - } - - return inputValueAge / float64(serializedTxSize-overhead) -} - // spendTransaction updates the passed transaction store by marking the inputs // to the passed transaction as spent. It also adds the passed transaction to // the store at the provided height.