From 3aaab91b9d2450212640637cebb876d699be8cd7 Mon Sep 17 00:00:00 2001 From: Akinwale Ariwodola Date: Wed, 29 May 2019 08:17:27 +0100 Subject: [PATCH 1/2] change the appearance of the uri bar input --- app/src/styles/uriBar.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/app/src/styles/uriBar.js b/app/src/styles/uriBar.js index e930e64d..2c1847df 100644 --- a/app/src/styles/uriBar.js +++ b/app/src/styles/uriBar.js @@ -19,11 +19,9 @@ const uriBarStyle = StyleSheet.create({ elevation: 4 }, uriText: { - backgroundColor: Colors.White, - borderWidth: 1, - borderColor: Colors.LightGrey, + backgroundColor: Colors.VeryLightGrey, padding: 8, - borderRadius: 4, + borderRadius: 24, fontFamily: 'Inter-UI-Regular', fontSize: 16, flex: 17 -- 2.45.3 From 5e99a2346c12f605c0e77e583cb829cd5fdcc404 Mon Sep 17 00:00:00 2001 From: Akinwale Ariwodola Date: Wed, 29 May 2019 11:52:04 +0100 Subject: [PATCH 2/2] improve no search results display --- app/src/page/search/view.js | 7 +++++-- app/src/styles/search.js | 21 ++++++++++++++++----- app/src/styles/uriBar.js | 4 +++- 3 files changed, 24 insertions(+), 8 deletions(-) diff --git a/app/src/page/search/view.js b/app/src/page/search/view.js index a37a3cd3..5b810e01 100644 --- a/app/src/page/search/view.js +++ b/app/src/page/search/view.js @@ -104,8 +104,7 @@ class SearchPage extends React.PureComponent { } - {!isSearching && (!uris || uris.length === 0) && - No results to display.} + {!isSearching && navigateToUri(navigation, uri)}/>) ) : null } + {(!uris || uris.length === 0) && + + There are no results to display for {query}. Please try a different search term. + } } diff --git a/app/src/styles/search.js b/app/src/styles/search.js index 601b7bd1..3e532472 100644 --- a/app/src/styles/search.js +++ b/app/src/styles/search.js @@ -8,7 +8,7 @@ const searchStyle = StyleSheet.create({ }, scrollContainer: { flex: 1, - marginTop: 60 + marginTop: 60, }, busyContainer: { flex: 1, @@ -16,6 +16,7 @@ const searchStyle = StyleSheet.create({ justifyContent: 'center' }, scrollPadding: { + flex: 1, paddingBottom: 16 }, resultItem: { @@ -27,7 +28,6 @@ const searchStyle = StyleSheet.create({ marginRight: 8 }, featuredResultItem: { - flex: 1, flexDirection: 'row', justifyContent: 'space-between', paddingTop: 8, @@ -42,11 +42,22 @@ const searchStyle = StyleSheet.create({ fontFamily: 'Inter-UI-Regular', fontSize: 16 }, + noResults: { + flex: 1, + width: '100%', + height: '100%', + justifyContent: 'center', + alignItems: 'center' + }, noResultsText: { - textAlign: 'center', fontFamily: 'Inter-UI-Regular', - fontSize: 14, - position: 'absolute' + fontSize: 16, + marginLeft: 16, + marginRight: 16 + }, + boldText: { + fontFamily: 'Inter-UI-SemiBold', + fontSize: 16 }, loading: { position: 'absolute' diff --git a/app/src/styles/uriBar.js b/app/src/styles/uriBar.js index 2c1847df..07986dfe 100644 --- a/app/src/styles/uriBar.js +++ b/app/src/styles/uriBar.js @@ -20,10 +20,12 @@ const uriBarStyle = StyleSheet.create({ }, uriText: { backgroundColor: Colors.VeryLightGrey, - padding: 8, borderRadius: 24, + paddingLeft: 12, + paddingRight: 12, fontFamily: 'Inter-UI-Regular', fontSize: 16, + lineHeight: 18, flex: 17 }, overlay: { -- 2.45.3