From 0397617bed5dca6f865c089e373cf6b82f75f715 Mon Sep 17 00:00:00 2001 From: btzr-io Date: Wed, 14 Jul 2021 13:44:22 -0500 Subject: [PATCH] use aria-hidden on all icons by default --- ui/component/button/view.jsx | 4 ++-- ui/component/common/icon.jsx | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/ui/component/button/view.jsx b/ui/component/button/view.jsx index c9a3ca999..b8927be06 100644 --- a/ui/component/button/view.jsx +++ b/ui/component/button/view.jsx @@ -102,7 +102,7 @@ const Button = forwardRef((props: Props, ref: any) => { const content = ( - {icon && } + {icon && } {!largestLabel && label && ( @@ -139,7 +139,7 @@ const Button = forwardRef((props: Props, ref: any) => { )} {children && children} - {iconRight && } + {iconRight && } ); diff --git a/ui/component/common/icon.jsx b/ui/component/common/icon.jsx index 7055c3fea..fec9a8062 100644 --- a/ui/component/common/icon.jsx +++ b/ui/component/common/icon.jsx @@ -73,6 +73,7 @@ class IconComponent extends React.PureComponent { size={size || (sectionIcon ? 20 : 16)} className={classnames(`icon icon--${icon}`, className, { 'color-override': iconColor })} color={color} + aria-hidden {...rest} /> );