From 140364cb67b80f278fad28a217fd5d364231c762 Mon Sep 17 00:00:00 2001
From: infiinte-persistence <inf.persistence@gmail.com>
Date: Fri, 12 Jun 2020 06:57:36 +0200
Subject: [PATCH] Fix translation issues in the Publish modal dialog.

Two issues:
1. Values not marked with __()
2. Split sentence.

For #2, it seems like there are translations that don't make sense when combined, because the values are being translated independently from full sentence in Transifex. Decided to just make it full sentences.
---
 static/app-strings.json        |  3 ++-
 ui/modal/modalPublish/view.jsx | 10 +++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/static/app-strings.json b/static/app-strings.json
index e361f0b29..fc5b8cfcb 100644
--- a/static/app-strings.json
+++ b/static/app-strings.json
@@ -679,7 +679,8 @@
   "Looks like you don't have any transactions.": "Looks like you don't have any transactions.",
   "If Sync is on, LBRY will backup your wallet and preferences. If disabled, you are responsible for keeping a backup.": "If Sync is on, LBRY will backup your wallet and preferences. If disabled, you are responsible for keeping a backup.",
   "View My Publishes": "View My Publishes",
-  "Your %publishMessage% pending on LBRY. It will take a few minutes to appear for other users.": "Your %publishMessage% pending on LBRY. It will take a few minutes to appear for other users.",
+  "Your update is now pending on LBRY. It will take a few minutes to appear for other users.": "Your update is now pending on LBRY. It will take a few minutes to appear for other users.",
+  "Your file is now pending on LBRY. It will take a few minutes to appear for other users.": "Your file is now pending on LBRY. It will take a few minutes to appear for other users.",
   "Upload will continue in the background, please do not shut down immediately. Leaving the app running helps the network, thank you!": "Upload will continue in the background, please do not shut down immediately. Leaving the app running helps the network, thank you!",
   "Are you sure want to revoke this claim?": "Are you sure want to revoke this claim?",
   "This will prevent others from resolving and accessing the content you published. It will return the LBC to your spendable balance, less a small transaction fee.": "This will prevent others from resolving and accessing the content you published. It will return the LBC to your spendable balance, less a small transaction fee.",
diff --git a/ui/modal/modalPublish/view.jsx b/ui/modal/modalPublish/view.jsx
index aba94efdb..17d24e0d1 100644
--- a/ui/modal/modalPublish/view.jsx
+++ b/ui/modal/modalPublish/view.jsx
@@ -17,8 +17,10 @@ type Props = {
 class ModalPublishSuccess extends React.PureComponent<Props> {
   render() {
     const { closeModal, clearPublish, navigate, uri, isEdit, filePath } = this.props;
-    const contentLabel = isEdit ? 'Update published' : 'File published';
-    const publishMessage = isEdit ? 'update is now' : 'file is now';
+    const contentLabel = isEdit ? __('Update published') : __('File published');
+    const publishMessage = isEdit
+      ? __('Your update is now pending on LBRY. It will take a few minutes to appear for other users.')
+      : __('Your file is now pending on LBRY. It will take a few minutes to appear for other users.');
 
     function handleClose() {
       clearPublish();
@@ -29,9 +31,7 @@ class ModalPublishSuccess extends React.PureComponent<Props> {
       <Modal isOpen type="card" contentLabel={__(contentLabel)} onAborted={handleClose}>
         <Card
           title={__('Success')}
-          subtitle={__(`Your %publishMessage% pending on LBRY. It will take a few minutes to appear for other users.`, {
-            publishMessage,
-          })}
+          subtitle={publishMessage}
           body={
             <React.Fragment>
               <div className="card--inline">