diff --git a/static/app-strings.json b/static/app-strings.json index fe3e53d47..cd45831f5 100644 --- a/static/app-strings.json +++ b/static/app-strings.json @@ -910,5 +910,12 @@ "%claimsInChannel% publishes": "%claimsInChannel% publishes", "%claimsInChannel% publish": "%claimsInChannel% publish", "Publishing": "Publishing", - "Update published": "Update published" -} + "Update published": "Update published", + "Delete this file from my computer": "Delete this file from my computer", + "Are you sure you'd like to remove %title% from LBRY?": "Are you sure you'd like to remove %title% from LBRY?", + "This will increase the overall bid amount for %title%, which will boost its ability to be discovered while active.": "This will increase the overall bid amount for %title%, which will boost its ability to be discovered while active.", + "Support %amount% LBC": "Support %amount% LBC", + "You deposited %amount% LBC as a support!": "You deposited %amount% LBC as a support!", + "/wallet": "/wallet", + "LBRY Link": "LBRY Link" +} \ No newline at end of file diff --git a/ui/analytics.js b/ui/analytics.js index c7b100d62..61e8a9740 100644 --- a/ui/analytics.js +++ b/ui/analytics.js @@ -130,10 +130,10 @@ const analytics: Analytics = { } }, videoStartEvent: (claimId, duration) => { - sendGaEvent('Media', 'StartDelay', claimId, duration); + sendGaTimingEvent('Media', 'StartDelay', Number((duration * 1000).toFixed(0)), claimId); }, videoBufferEvent: (claimId, currentTime) => { - sendGaEvent('Media', 'BufferTimestamp', claimId, currentTime); + sendGaTimingEvent('Media', 'BufferTimestamp', currentTime * 1000, claimId); }, tagFollowEvent: (tag, following, location) => { sendGaEvent(following ? 'Tag-Follow' : 'Tag-Unfollow', tag); @@ -176,13 +176,14 @@ function sendGaEvent(category, action, label, value) { } } -function sendGaTimingEvent(category: string, action: string, timeInMs: number) { +function sendGaTimingEvent(category: string, action: string, timeInMs: number, label?: string) { if (analyticsEnabled && isProduction) { ReactGA.timing( { category, variable: action, value: timeInMs, + ...(label ? { label } : {}), }, [SECOND_TRACKER_NAME] ); diff --git a/ui/component/viewers/videoViewer/view.jsx b/ui/component/viewers/videoViewer/view.jsx index 61defe185..b54858be9 100644 --- a/ui/component/viewers/videoViewer/view.jsx +++ b/ui/component/viewers/videoViewer/view.jsx @@ -222,7 +222,6 @@ function VideoViewer(props: Props) { player.off(); } }; - // include requireRedraw here so the event listener is re-added when we need to manually remove/add the video player }, [player]); return (