From 3d6ed7b1ec189e670af3a259a40f7f57e5098105 Mon Sep 17 00:00:00 2001
From: Sean Yesmunt <sean@lbry.io>
Date: Wed, 15 Apr 2020 14:11:51 -0400
Subject: [PATCH] only call email provided event for real sign ups

---
 package.json                             | 4 ++--
 ui/component/userEmailNew/view.jsx       | 9 +++++----
 ui/component/userEmailReturning/view.jsx | 2 --
 yarn.lock                                | 8 ++++----
 4 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/package.json b/package.json
index c618b615e..1a54fbe6e 100644
--- a/package.json
+++ b/package.json
@@ -130,8 +130,8 @@
     "imagesloaded": "^4.1.4",
     "json-loader": "^0.5.4",
     "lbry-format": "https://github.com/lbryio/lbry-format.git",
-    "lbry-redux": "lbryio/lbry-redux#df043f3ef6076b52cec11be76069e0c7c9c19e0a",
-    "lbryinc": "lbryio/lbryinc#12aefaa14343d2f3eac01f2683701f58e53f1848",
+    "lbry-redux": "lbryio/lbry-redux#22c9e3563ead27a0250751b6d72a678cbbe60633",
+    "lbryinc": "lbryio/lbryinc#11ebc51ab6156beb71d18494ed82e8da2e673ead",
     "lint-staged": "^7.0.2",
     "localforage": "^1.7.1",
     "lodash-es": "^4.17.14",
diff --git a/ui/component/userEmailNew/view.jsx b/ui/component/userEmailNew/view.jsx
index cc34cfc57..596815445 100644
--- a/ui/component/userEmailNew/view.jsx
+++ b/ui/component/userEmailNew/view.jsx
@@ -20,7 +20,7 @@ type Props = {
   balance: number,
   daemonSettings: { share_usage_data: boolean },
   setShareDiagnosticData: boolean => void,
-  doSignUp: (string, ?string) => void,
+  doSignUp: (string, ?string) => Promise<any>,
   clearEmailEntry: () => void,
 };
 
@@ -52,11 +52,12 @@ function UserEmailNew(props: Props) {
 
   function handleSubmit() {
     setSync(formSyncEnabled);
-    doSignUp(email, password === '' ? undefined : password);
     // @if TARGET='app'
     setShareDiagnosticData(true);
     // @endif
-    analytics.emailProvidedEvent();
+    doSignUp(email, password === '' ? undefined : password).then(() => {
+      analytics.emailProvidedEvent();
+    });
   }
 
   function handleChangeToSignIn(additionalParams) {
@@ -87,7 +88,7 @@ function UserEmailNew(props: Props) {
   return (
     <div className="main__sign-up">
       <Card
-        title={__('Join lbry.tv')}
+        title={__('Register with lbry.tv')}
         // @if TARGET='app'
         subtitle={__('An account with lbry.tv allows you to earn rewards and backup your data.')}
         // @endif
diff --git a/ui/component/userEmailReturning/view.jsx b/ui/component/userEmailReturning/view.jsx
index 5902e8c6d..613458dab 100644
--- a/ui/component/userEmailReturning/view.jsx
+++ b/ui/component/userEmailReturning/view.jsx
@@ -8,7 +8,6 @@ import { useHistory } from 'react-router-dom';
 import UserEmailVerify from 'component/userEmailVerify';
 import Card from 'component/common/card';
 import Nag from 'component/common/nag';
-import analytics from 'analytics';
 
 type Props = {
   errorMessage: ?string,
@@ -32,7 +31,6 @@ function UserEmailReturning(props: Props) {
 
   function handleSubmit() {
     doUserCheckIfEmailExists(email);
-    analytics.emailProvidedEvent();
   }
 
   function handleChangeToSignIn() {
diff --git a/yarn.lock b/yarn.lock
index 98df7b496..1885844f3 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -6139,17 +6139,17 @@ lazy-val@^1.0.4:
     yargs "^13.2.2"
     zstd-codec "^0.1.1"
 
-lbry-redux@lbryio/lbry-redux#df043f3ef6076b52cec11be76069e0c7c9c19e0a:
+lbry-redux@lbryio/lbry-redux#22c9e3563ead27a0250751b6d72a678cbbe60633:
   version "0.0.1"
-  resolved "https://codeload.github.com/lbryio/lbry-redux/tar.gz/df043f3ef6076b52cec11be76069e0c7c9c19e0a"
+  resolved "https://codeload.github.com/lbryio/lbry-redux/tar.gz/22c9e3563ead27a0250751b6d72a678cbbe60633"
   dependencies:
     proxy-polyfill "0.1.6"
     reselect "^3.0.0"
     uuid "^3.3.2"
 
-lbryinc@lbryio/lbryinc#12aefaa14343d2f3eac01f2683701f58e53f1848:
+lbryinc@lbryio/lbryinc#11ebc51ab6156beb71d18494ed82e8da2e673ead:
   version "0.0.1"
-  resolved "https://codeload.github.com/lbryio/lbryinc/tar.gz/12aefaa14343d2f3eac01f2683701f58e53f1848"
+  resolved "https://codeload.github.com/lbryio/lbryinc/tar.gz/11ebc51ab6156beb71d18494ed82e8da2e673ead"
   dependencies:
     reselect "^3.0.0"