From 4c97cb4ba4b5f4a55327d5f242708664b3a64c44 Mon Sep 17 00:00:00 2001 From: Jeffrey Fisher Date: Wed, 27 Jan 2021 22:08:19 -0800 Subject: [PATCH] Enable PDF Viewer in App Closes #2903 --- CHANGELOG.md | 1 + ui/constants/file_render_modes.js | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 83c44b1c5..45766c23f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ### Added - Zoomable image viewer in Markdown (posts and comments) _community pr!_ ([#5387](https://github.com/lbryio/lbry-desktop/pull/5387)) +- Enable PDF Viewer in App _community pr!_ ([#2903](https://github.com/lbryio/lbry-desktop/issues/2903)) ### Changed diff --git a/ui/constants/file_render_modes.js b/ui/constants/file_render_modes.js index 2fbe977bc..573d7f830 100644 --- a/ui/constants/file_render_modes.js +++ b/ui/constants/file_render_modes.js @@ -26,8 +26,7 @@ export const DOWNLOAD = 'download'; export const APPLICATION = 'application'; export const UNSUPPORTED = 'unsupported'; -// PDFs disabled on desktop until we update Electron: https://github.com/electron/electron/issues/12337 -export const UNSUPPORTED_IN_THIS_APP = IS_WEB ? [CAD, COMIC, APPLICATION] : [APPLICATION, PDF]; +export const UNSUPPORTED_IN_THIS_APP = IS_WEB ? [CAD, COMIC, APPLICATION] : [APPLICATION]; export const UNRENDERABLE_MODES = Array.from( new Set(UNSUPPORTED_IN_THIS_APP.concat([DOWNLOAD, APPLICATION, UNSUPPORTED]))