From 4d849a4821db4ccf8a2e24d71754d65ee5048150 Mon Sep 17 00:00:00 2001
From: mayeaux <instacoins@gmail.com>
Date: Thu, 16 Jun 2022 15:22:45 +0200
Subject: [PATCH] Revert "Add href links to notification menu entries (#1699)"
 (#1700)

This reverts commit 268130a91366ad171c3d1fa4b8a7b603ddaec69b.
---
 ui/component/headerNotificationButton/view.jsx | 18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/ui/component/headerNotificationButton/view.jsx b/ui/component/headerNotificationButton/view.jsx
index fd85900d4..aa9b1ad33 100644
--- a/ui/component/headerNotificationButton/view.jsx
+++ b/ui/component/headerNotificationButton/view.jsx
@@ -21,7 +21,6 @@ import UriIndicator from 'component/uriIndicator';
 import { generateNotificationTitle } from '../notification/helpers/title';
 import { generateNotificationText } from '../notification/helpers/text';
 import { parseURI } from 'util/lbryURI';
-import { NavLink } from 'react-router-dom';
 
 type Props = {
   notifications: Array<Notification>,
@@ -116,15 +115,6 @@ export default function NotificationHeaderButton(props: Props) {
     push(notificationLink);
   }
 
-  function getWebUri(notification) {
-    const { notification_parameters } = notification;
-    let notificationLink = formatLbryUrlForWeb(notification_parameters.device.target);
-    if (notification_parameters.dynamic.hash) {
-      notificationLink += '?lc=' + notification_parameters.dynamic.hash + '&view=discussion';
-    }
-    return notificationLink;
-  }
-
   function menuEntry(notification) {
     const { id, active_at, notification_rule, notification_parameters, is_read, type } = notification;
 
@@ -173,7 +163,7 @@ export default function NotificationHeaderButton(props: Props) {
     }
 
     return (
-      <NavLink onClick={() => handleNotificationClick(notification)} key={id} to={getWebUri(notification)}>
+      <a onClick={() => handleNotificationClick(notification)} key={id}>
         <div
           className={is_read ? 'menu__list--notification' : 'menu__list--notification menu__list--notification-unread'}
           key={id}
@@ -197,7 +187,7 @@ export default function NotificationHeaderButton(props: Props) {
             <Icon icon={ICONS.DELETE} sectionIcon />
           </div>
         </div>
-      </NavLink>
+      </a>
     );
   }
 
@@ -228,9 +218,9 @@ export default function NotificationHeaderButton(props: Props) {
               )}
             </div>
 
-            <NavLink onClick={handleMenuClick} to={`/$/${PAGES.NOTIFICATIONS}`}>
+            <a onClick={handleMenuClick}>
               <div className="menu__list--notifications-more">{__('View all')}</div>
-            </NavLink>
+            </a>
           </MuiMenu>
         </ClickAwayListener>
       </>