From 5f9ffd52d4cf45c13142dfaff2fab2825f5d50f0 Mon Sep 17 00:00:00 2001 From: zeppi Date: Thu, 17 Nov 2022 13:19:16 -0500 Subject: [PATCH] comment github action mac python hack --- .github/workflows/deploy.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 0c8dc2813..03e9e886f 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -39,10 +39,16 @@ jobs: if: startsWith(runner.os, 'mac') with: xcode-version: '13.1.0' - + # This is gonna be hacky. + # Github made us upgrade xcode, which would force an upgrade of electron-builder to fix mac. + # But there were bugs with copyfiles / extraFiles that kept seeing duplicates erroring on ln. + # A flag USE_HARD_LINKS=false in electron-builder.json was suggested in comments, but that broke windows builds. + # So for now we'll install python2 on mac and make sure it can find it. + # Remove this after successfully upgrading electron-builder. + # HACK part 1 - uses: Homebrew/actions/setup-homebrew@master if: startsWith(runner.os, 'mac') - + # HACK part 2 - name: Install Python2 if: startsWith(runner.os, 'mac') run: |