From 91ef5456de5e6a44fe2aa9be9123cb72b03f67a1 Mon Sep 17 00:00:00 2001 From: jessopb <36554050+jessopb@users.noreply.github.com> Date: Fri, 3 Sep 2021 11:29:23 -0400 Subject: [PATCH] Fix stale recsys and fix watchman uncaught promise when videoPlayer is not initialized (#7014) * do not set stale recsys id * no watchman send if videoplay not initialized --- ui/analytics.js | 4 ++++ ui/recsys.js | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ui/analytics.js b/ui/analytics.js index b36902941..495535dcc 100644 --- a/ui/analytics.js +++ b/ui/analytics.js @@ -120,6 +120,10 @@ async function sendAndResetWatchmanData() { return 'Can only be used with a user id'; } + if (!videoPlayer) { + return 'Video player not initialized'; + } + let timeSinceLastIntervalSend = new Date() - lastSentTime; lastSentTime = new Date(); diff --git a/ui/recsys.js b/ui/recsys.js index f5d8ae106..6a92e2bd2 100644 --- a/ui/recsys.js +++ b/ui/recsys.js @@ -110,7 +110,7 @@ const recsys = { uid: userId, // selectUser claimId: claimId, pageLoadedAt: Date.now(), - recsysId: makeSelectRecommendedRecsysIdForClaimId(claimId)(state) || recsysId, + recsysId: null, recClaimIds: [], recClickedVideoIdx: [], events: [],