From 950518257692e12228c46b81481219a15712c936 Mon Sep 17 00:00:00 2001 From: infinite-persistence Date: Thu, 19 Aug 2021 15:18:36 +0800 Subject: [PATCH] Use positive "Publish preview" text, per feedback It was phrased negatively as the feedback back then was the string should match whatever is on the actual dialog (which was "Skip preview and confirmation"). But now it looks odd when we have an additional title string. We think titles should be positively phrased, hence the change. --- static/app-strings.json | 1 + ui/component/settingContent/view.jsx | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/static/app-strings.json b/static/app-strings.json index ac86246da..5e7edab7f 100644 --- a/static/app-strings.json +++ b/static/app-strings.json @@ -1421,6 +1421,7 @@ "Est. transaction fee:": "Est. transaction fee:", "Publish confirmation": "Publish confirmation", "Skip preview and confirmation": "Skip preview and confirmation", + "Show preview and confirmation dialog before publishing content.": "Show preview and confirmation dialog before publishing content.", "Upload settings": "Upload settings", "Currently Uploading": "Currently Uploading", "Leave the app running until upload is complete": "Leave the app running until upload is complete", diff --git a/ui/component/settingContent/view.jsx b/ui/component/settingContent/view.jsx index ccb9d92d3..671c21ff0 100644 --- a/ui/component/settingContent/view.jsx +++ b/ui/component/settingContent/view.jsx @@ -157,12 +157,12 @@ export default function SettingContent(props: Props) { )} - + setClientSetting(SETTINGS.ENABLE_PUBLISH_PREVIEW, !enablePublishPreview)} /> @@ -213,4 +213,5 @@ const HELP = { SHOW_MATURE: 'Mature content may include nudity, intense sexuality, profanity, or other adult content. By displaying mature content, you are affirming you are of legal age to view mature content in your country or jurisdiction. ', MAX_PURCHASE_PRICE: 'This will prevent you from purchasing any content over a certain cost, as a safety measure.', ONLY_CONFIRM_OVER_AMOUNT: '', // [feel redundant. Disable for now] "When this option is chosen, LBRY won't ask you to confirm purchases or tips below your chosen amount.", + PUBLISH_PREVIEW: 'Show preview and confirmation dialog before publishing content.', };