From 9b5860c1bf54580e78289dd69355e5f9df3fc82a Mon Sep 17 00:00:00 2001
From: Sean Yesmunt <sean@lbry.io>
Date: Fri, 20 Mar 2020 15:09:45 -0400
Subject: [PATCH] merge CommentReply and CommentCreate

---
 static/app-strings.json             | 16 +++---
 ui/component/comment/view.jsx       | 37 ++++++++----
 ui/component/commentCreate/index.js |  8 +--
 ui/component/commentCreate/view.jsx | 44 ++++++++++++---
 ui/component/commentReply/index.js  | 20 -------
 ui/component/commentReply/view.jsx  | 88 -----------------------------
 ui/scss/component/_comments.scss    | 20 +++----
 7 files changed, 84 insertions(+), 149 deletions(-)
 delete mode 100644 ui/component/commentReply/index.js
 delete mode 100644 ui/component/commentReply/view.jsx

diff --git a/static/app-strings.json b/static/app-strings.json
index dfe3625d7..b22f52782 100644
--- a/static/app-strings.json
+++ b/static/app-strings.json
@@ -1029,11 +1029,6 @@
   "Your video has a bitrate over 6 mbps. We suggest transcoding to provide viewers the best experience.": "Your video has a bitrate over 6 mbps. We suggest transcoding to provide viewers the best experience.",
   "Your video has a bitrate over 5 mbps. We suggest transcoding to provide viewers the best experience.": "Your video has a bitrate over 5 mbps. We suggest transcoding to provide viewers the best experience.",
   "Almost there": "Almost there",
-  "Comment Acknowledgement": "Comment Acknowledgement",
-  "A few things to know before making your comment:": "A few things to know before making your comment:",
-  "Commenting is in alpha. During the alpha, all comments are sent to a LBRY, Inc. server, not the LBRY network itself.": "Commenting is in alpha. During the alpha, all comments are sent to a LBRY, Inc. server, not the LBRY network itself.",
-  "Deleting or editing comments is not currently possible. Please be mindful of this when posting.": "Deleting or editing comments is not currently possible. Please be mindful of this when posting.",
-  "When the alpha ends, we will attempt to transition comments, but do not promise to do so.": "When the alpha ends, we will attempt to transition comments, but do not promise to do so.",
   "More Channels": "More Channels",
   "Known Tags": "Known Tags",
   "You aren’t blocking any channels": "You aren’t blocking any channels",
@@ -1063,5 +1058,12 @@
   "Your wallet data will remain intact. If you sign in with a different account, the wallets will be merged. To prevent this, you need to %rename_wallet_instructions%": "Your wallet data will remain intact. If you sign in with a different account, the wallets will be merged. To prevent this, you need to %rename_wallet_instructions%",
   "rename your existing wallet": "rename your existing wallet",
   "Your wallet data will remain intact. If you sign in with a different account, the wallets will be merged. To prevent this, you need to %rename_wallet_instructions% in the lbry/wallets directory": "Your wallet data will remain intact. If you sign in with a different account, the wallets will be merged. To prevent this, you need to %rename_wallet_instructions% in the lbry/wallets directory",
-  "Your wallet data will remain intact. If you sign in with a different account, the wallets will be merged. To prevent this, you need to %rename_wallet_instructions% in the lbry/wallets directory.": "Your wallet data will remain intact. If you sign in with a different account, the wallets will be merged. To prevent this, you need to %rename_wallet_instructions% in the lbry/wallets directory."
-}
+  "Your wallet data will remain intact. If you sign in with a different account, the wallets will be merged. To prevent this, you need to %rename_wallet_instructions% in the lbry/wallets directory.": "Your wallet data will remain intact. If you sign in with a different account, the wallets will be merged. To prevent this, you need to %rename_wallet_instructions% in the lbry/wallets directory.",
+  "Your wallet": "Your wallet",
+  "Publish a file, or create a channel": "Publish a file, or create a channel",
+  "Your account": "Your account",
+  "Creator Analytics": "Creator Analytics",
+  "Channel profile picture": "Channel profile picture",
+  "(%count%)": "(%count%)",
+  "Reposts of %uri%": "Reposts of %uri%"
+}
\ No newline at end of file
diff --git a/ui/component/comment/view.jsx b/ui/component/comment/view.jsx
index 9544d95be..24daa48b5 100644
--- a/ui/component/comment/view.jsx
+++ b/ui/component/comment/view.jsx
@@ -10,7 +10,7 @@ import { Menu, MenuList, MenuButton, MenuItem } from '@reach/menu-button';
 import Icon from 'component/common/icon';
 import * as ICONS from 'constants/icons';
 import { FormField, Form } from 'component/common/form';
-import CommentReply from '../commentReply/index';
+import CommentCreate from 'component/commentCreate';
 import classnames from 'classnames';
 
 type Props = {
@@ -161,16 +161,15 @@ function Comment(props: Props) {
                   />
                 </MenuButton>
                 <MenuList className="comment__menu-list">
-                  <MenuItem className="comment__menu-option" onSelect={handleSetEditing}>
-                    {__('Edit')}
-                  </MenuItem>
-                  <MenuItem className="comment__menu-option" onSelect={handleDeleteComment}>
-                    {__('Delete')}
-                  </MenuItem>
-                  {parentId === null ? (
-                    <MenuItem className="comment__menu-option" onSelect={handleReply}>
-                      {__('Reply')}
-                    </MenuItem>
+                  {commentIsMine ? (
+                    <React.Fragment>
+                      <MenuItem className="comment__menu-option" onSelect={handleSetEditing}>
+                        {__('Edit')}
+                      </MenuItem>
+                      <MenuItem className="comment__menu-option" onSelect={handleDeleteComment}>
+                        {__('Delete')}
+                      </MenuItem>
+                    </React.Fragment>
                   ) : (
                     ''
                   )}
@@ -212,7 +211,21 @@ function Comment(props: Props) {
             </div>
           )}
         </div>
-        <div>{isReplying ? <CommentReply uri={uri} parentId={commentId} setReplying={setReplying} /> : ''}</div>
+        {!parentId && (
+          <Button button="link" className="comment__reply-button" onClick={handleReply} label={__('Reply')} />
+        )}
+        <div>
+          {isReplying ? (
+            <CommentCreate
+              uri={uri}
+              parentId={commentId}
+              onDoneReplying={() => setReplying(false)}
+              onCancelReplying={() => setReplying(false)}
+            />
+          ) : (
+            ''
+          )}
+        </div>
       </div>
     </li>
   );
diff --git a/ui/component/commentCreate/index.js b/ui/component/commentCreate/index.js
index 821baa77a..832468a3c 100644
--- a/ui/component/commentCreate/index.js
+++ b/ui/component/commentCreate/index.js
@@ -11,11 +11,9 @@ const select = (state, props) => ({
 });
 
 const perform = dispatch => ({
-  createComment: (comment, claimId, channel) => dispatch(doCommentCreate(comment, claimId, channel)),
+  createComment: (comment, claimId, channel, parentId) =>
+    dispatch(doCommentCreate(comment, claimId, channel, parentId)),
   openModal: (modal, props) => dispatch(doOpenModal(modal, props)),
 });
 
-export default connect(
-  select,
-  perform
-)(CommentCreate);
+export default connect(select, perform)(CommentCreate);
diff --git a/ui/component/commentCreate/view.jsx b/ui/component/commentCreate/view.jsx
index 70c49029e..4e9460f72 100644
--- a/ui/component/commentCreate/view.jsx
+++ b/ui/component/commentCreate/view.jsx
@@ -1,6 +1,7 @@
 // @flow
 import { CHANNEL_NEW } from 'constants/claim';
 import React, { useEffect, useState } from 'react';
+import classnames from 'classnames';
 import { FormField, Form } from 'component/common/form';
 import Button from 'component/button';
 import ChannelSection from 'component/selectChannel';
@@ -13,14 +14,27 @@ type Props = {
   uri: string,
   claim: StreamClaim,
   openModal: (id: string, { onCommentAcknowledge: () => void }) => void,
-  createComment: (string, string, string) => void,
+  createComment: (string, string, string, ?string) => void,
   channels: ?Array<ChannelClaim>,
+  parentId?: string,
+  onDoneReplying?: () => void,
+  onCancelReplying?: () => void,
 };
 
 export function CommentCreate(props: Props) {
-  const { commentingEnabled, createComment, claim, openModal, channels } = props;
+  const {
+    commentingEnabled,
+    createComment,
+    claim,
+    openModal,
+    channels,
+    parentId,
+    onDoneReplying,
+    onCancelReplying,
+  } = props;
   const { claim_id: claimId } = claim;
-  const [commentValue, setCommentValue] = usePersistedState(`comment-${claimId}`, '');
+  const isReply = !!parentId;
+  const [commentValue, setCommentValue] = React.useState('');
   const [commentAck, setCommentAck] = usePersistedState('comment-acknowledge', false);
   const [channel, setChannel] = usePersistedState('comment-channel', '');
   const [charCount, setCharCount] = useState(commentValue.length);
@@ -59,8 +73,13 @@ export function CommentCreate(props: Props) {
   }
 
   function handleSubmit() {
-    if (channel !== CHANNEL_NEW && commentValue.length) createComment(commentValue, claimId, channel);
+    if (channel !== CHANNEL_NEW && commentValue.length) {
+      createComment(commentValue, claimId, channel, parentId);
+    }
     setCommentValue('');
+    if (onDoneReplying) {
+      onDoneReplying();
+    }
   }
 
   useEffect(() => setCharCount(commentValue.length), [commentValue]);
@@ -74,8 +93,8 @@ export function CommentCreate(props: Props) {
   }
 
   return (
-    <Form onSubmit={handleSubmit}>
-      <ChannelSection channel={channel} hideAnon onChannelChange={handleChannelChange} />
+    <Form onSubmit={handleSubmit} className={classnames('comment__create', { 'comment__create--reply': isReply })}>
+      {!isReply && <ChannelSection channel={channel} hideAnon onChannelChange={handleChannelChange} />}
       <FormField
         disabled={channel === CHANNEL_NEW}
         type="textarea"
@@ -92,9 +111,20 @@ export function CommentCreate(props: Props) {
           button="primary"
           disabled={channel === CHANNEL_NEW || !commentValue.length}
           type="submit"
-          label={__('Post')}
+          label={isReply ? __('Reply') : __('Post')}
           requiresAuth={IS_WEB}
         />
+        {isReply && (
+          <Button
+            button="link"
+            label={__('Cancel')}
+            onClick={() => {
+              if (onCancelReplying) {
+                onCancelReplying();
+              }
+            }}
+          />
+        )}
       </div>
     </Form>
   );
diff --git a/ui/component/commentReply/index.js b/ui/component/commentReply/index.js
deleted file mode 100644
index dd13701ca..000000000
--- a/ui/component/commentReply/index.js
+++ /dev/null
@@ -1,20 +0,0 @@
-import { connect } from 'react-redux';
-import { doCommentCreate, makeSelectClaimForUri } from 'lbry-redux';
-import { doOpenModal } from 'redux/actions/app';
-import { CommentReply } from './view';
-import { selectUserVerifiedEmail } from 'lbryinc';
-
-const select = (state, props) => ({
-  commentingEnabled: IS_WEB ? Boolean(selectUserVerifiedEmail(state)) : true,
-  claim: makeSelectClaimForUri(props.uri)(state),
-});
-
-const perform = dispatch => ({
-  replyComment: (comment, claimId, channel, parentId) => dispatch(doCommentCreate(comment, claimId, channel, parentId)),
-  openModal: (modal, props) => dispatch(doOpenModal(modal, props)),
-});
-
-export default connect(
-  select,
-  perform
-)(CommentReply);
diff --git a/ui/component/commentReply/view.jsx b/ui/component/commentReply/view.jsx
deleted file mode 100644
index c4e2c86fd..000000000
--- a/ui/component/commentReply/view.jsx
+++ /dev/null
@@ -1,88 +0,0 @@
-// @flow
-import { CHANNEL_NEW } from 'constants/claim';
-import React, { useEffect, useState } from 'react';
-import { FormField, Form } from 'component/common/form';
-import Button from 'component/button';
-import ChannelSection from 'component/selectChannel';
-import usePersistedState from 'effects/use-persisted-state';
-import * as MODALS from 'constants/modal_types';
-import I18nMessage from '../i18nMessage/view';
-
-type Props = {
-  commentingEnabled: boolean,
-  claim: StreamClaim,
-  parentId: string,
-  openModal: (id: string, { onCommentAcknowledge: () => void }) => void,
-  replyComment: (string, string, string, string) => void,
-  setReplying: boolean => void,
-};
-
-export function CommentReply(props: Props) {
-  const { commentingEnabled, replyComment, setReplying, claim, openModal, parentId } = props;
-  const { claim_id: claimId } = claim;
-  const [commentValue, setCommentValue] = usePersistedState(`comment-${claimId}`, '');
-  const [commentAck, setCommentAck] = usePersistedState('comment-acknowledge', false);
-  const [channel, setChannel] = usePersistedState('comment-channel', 'anonymous');
-  const [charCount, setCharCount] = useState(commentValue.length);
-
-  function handleCommentChange(event) {
-    setCommentValue(event.target.value);
-  }
-
-  function handleChannelChange(channel) {
-    setChannel(channel);
-  }
-
-  function handleCommentAck() {
-    setCommentAck(true);
-  }
-
-  function onTextareaFocus() {
-    if (!commentAck) {
-      openModal(MODALS.COMMENT_ACKNOWEDGEMENT, { onCommentAcknowledge: handleCommentAck });
-    }
-  }
-
-  function handleSubmit() {
-    if (channel !== CHANNEL_NEW && commentValue.length);
-    replyComment(commentValue, claimId, channel, parentId);
-    setCommentValue('');
-  }
-
-  useEffect(() => setCharCount(commentValue.length), [commentValue]);
-
-  if (!commentingEnabled) {
-    return (
-      <I18nMessage tokens={{ sign_in_link: <Button button="link" requiresAuth label={__('sign in')} /> }}>
-        Please %sign_in_link% to comment.
-      </I18nMessage>
-    );
-  }
-
-  return (
-    <Form className="comment__reply-form" onSubmit={handleSubmit}>
-      <ChannelSection channel={channel} onChannelChange={handleChannelChange} />
-      <FormField
-        disabled={channel === CHANNEL_NEW}
-        type="textarea"
-        name="content_description"
-        label={__('Comment')}
-        onFocus={onTextareaFocus}
-        placeholder={__('Say something about this...')}
-        value={commentValue}
-        charCount={charCount}
-        onChange={handleCommentChange}
-      />
-      <div className="section__actions">
-        <Button
-          button="primary"
-          disabled={channel === CHANNEL_NEW || !commentValue.length}
-          type="submit"
-          label={__('Post')}
-          requiresAuth={IS_WEB}
-        />
-        <Button button="link" label={__('Cancel')} onClick={() => setReplying(false)} />
-      </div>
-    </Form>
-  );
-}
diff --git a/ui/scss/component/_comments.scss b/ui/scss/component/_comments.scss
index 8bd630651..6e96d6671 100644
--- a/ui/scss/component/_comments.scss
+++ b/ui/scss/component/_comments.scss
@@ -1,7 +1,3 @@
-.comments {
-  @extend .ul--no-style;
-}
-
 .comment {
   padding: var(--spacing-small) 0;
   display: flex;
@@ -11,7 +7,7 @@
   margin: 0;
 
   &:first-of-type {
-    padding-top: 0;
+    border-top: 1px solid var(--color-border);
   }
 
   &:not(:last-of-type) {
@@ -19,13 +15,17 @@
   }
 }
 
-.comment__reply {
-  border-left: 5px solid var(--color-border);
-  padding-left: var(--spacing-small);
+.comment__create--reply {
+  margin-top: var(--spacing-small);
 }
 
-.comment__reply-form {
-  border-top: 1px solid var(--color-border);
+.comment__reply {
+  border-left: 5px solid var(--color-primary-alt);
+  padding-left: var(--spacing-medium);
+  margin-left: var(--spacing-medium);
+}
+
+.comment__reply-button {
   margin-top: var(--spacing-small);
 }