Theme color fixes (master) (#6088)

* Fix error text color for dark mode.

Don't alter --color-danger since that color works fine as a backdrop for the Toast Message.

* Remove duplicates

* Fix typo

* Fix primary/secondary button and notice_message

* Fix dimmed checkbox

* #6006 Switch from 'coolGray' to 'gray'

* Fix invisible nag (missing --color-orange)

ui/scss/init/_base-theme.scss

@@ -1,5 +1,5 @@
 //
-// Colors are taken from this color pallette
+// Colors are taken from this color palette
 // https://tailwindcss.com/docs/customizing-colors
 // New colors should be also taken from the same color palette (if possible)
 //
@@ -25,17 +25,17 @@
   --color-gray-2: #e5e7eb;
   --color-gray-3: #d1d5db;
   --color-gray-4: #9ca3af;
-  --color-gray-5: #6b7280;
+  --color-gray-5: #71717a;
-  --color-gray-6: #4b5563;
+  --color-gray-6: #52525b;
-  --color-gray-7: #374151;
+  --color-gray-7: #3f3f46;
-  --color-gray-8: #1f2937;
+  --color-gray-8: #27272a;
-  --color-gray-9: #1f2c47;
+  --color-gray-9: #1f1f22;
-  --color-gray-10: #111827;
+  --color-gray-10: #18181b;
   --color-amber: #f26522;
+  --color-orange: #fb923c;
 
   // Structure
   --color-text: var(--color-black);
-  --color-text-subtitle: var(--color-gray-5);
   --color-text-inverse: #fdfdfd;
   --color-background: #fafafa;
   --color-background--splash: #212529;

ui/scss/themes/dark.scss

@@ -1,12 +1,16 @@
 [theme='dark'] {
-  // Color overides
+  // Color overrides
-  --color-secondary: #1d3b63;
+  --color-primary: #2bbb90;
+  --color-primary-alt: #3e675d;
+  --color-primary-alt-2: #065f46;
+  --color-primary-alt-3: #34e5b0;
+  --color-secondary: #204166;
   --color-secondary-alt: #dbeafe;
   --color-secondary-alt-2: #bfdbfe;
-  --color-secondary-alt-3: #172f4f;
+  --color-secondary-alt-3: #2c5c8c;
 
   // Structure
-  --color-background: var(--color-gray-10);
+  --color-background: var(--color-gray-9);
   --color-background-overlay: #11182795;
   --color-border: var(--color-gray-7);
   --color-card-background: var(--color-gray-8);
@@ -19,8 +23,8 @@
   --color-text-help: #bbbbbb;
   --color-text-warning: #212529;
   --color-text-warning--background: var(--lbry-yellow-1);
-  --color-text-error: var(--color-danger);
+  --color-text-error: #f87171;
-  --color-error: var(--color-danger-alt);
+  --color-error: #61373f;
 
   // Header
   --color-header-background: var(--color-gray-8);
@@ -29,14 +33,14 @@
   --color-header-button-active: var(--color-gray-6);
 
   // Button
-  --color-button-primary-bg: var(--color-primary);
+  --color-button-primary-bg: var(--color-primary-alt);
   --color-button-primary-bg-hover: var(--color-primary-alt-2);
-  --color-button-primary-text: var(--color-primary-alt);
+  --color-button-primary-text: var(--color-gray-2);
   --color-button-primary-hover-text: var(--color-primary-alt);
   --color-button-secondary-bg: var(--color-secondary);
   --color-button-secondary-border: var(--color-secondary);
   --color-button-secondary-bg-hover: var(--color-secondary-alt-3);
-  --color-button-secondary-text: var(--color-secondary-alt);
+  --color-button-secondary-text: var(--color-gray-2);
   --color-button-alt-bg: var(--color-gray-7);
   --color-button-alt-bg-hover: var(--color-gray-6);
   --color-button-alt-text: var(--color-gray-1);
@@ -55,7 +59,7 @@
   --color-input-bg-copyable: var(--color-gray-6);
   --color-input-border: var(--color-border);
   --color-input-border-active: var(--color-secondary);
-  --color-input-toggle: var(--color-primary);
+  --color-input-toggle: var(--color-primary-alt-3);
   --color-input-toggle-bg: var(--color-input-bg);
   --color-input-toggle-bg-hover: var(--color-secondary);
   --color-input-bg-selected: var(--color-primary-alt);
@@ -73,9 +77,9 @@
 
   // Tags
   --color-tag: var(--color-primary-alt-3);
-  --color-tag-bg: var(--color-gray-6);
+  --color-tag-bg: var(--color-gray-7);
   --color-tag-hover: var(--color-white);
-  --color-tag-bg-hover: var(--color-primary);
+  --color-tag-bg-hover: var(--color-primary-alt);
 
   // Menu
   --color-menu-background: var(--color-header-background);
@@ -110,7 +114,6 @@
   --color-tab-divider: var(--color-white);
   --color-modal-background: var(--color-card-background);
   --color-notice: #58563b;
-  --color-error: #61373f;
   --color-purchased: #ffd580;
   --color-purchased-alt: var(--color-purchased);
   --color-purchased-text: var(--color-gray-5);