From 9d48d9924d44ae3052768d7a67b9f83550b85169 Mon Sep 17 00:00:00 2001
From: infinite-persistence <inf.persistence@gmail.com>
Date: Sat, 9 Oct 2021 15:38:38 +0800
Subject: [PATCH] Comments: expand replies for LC chain before mount instead of
 after

## Issue
40 Linked comments doesn't scroll for deep replies

## Notes
Don't need an effect for this, plus it was causing the parent to not pick it up for auto-scrolling.
---
 ui/component/comment/view.jsx | 23 ++++++++---------------
 1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/ui/component/comment/view.jsx b/ui/component/comment/view.jsx
index b4816303a..6fac77383 100644
--- a/ui/component/comment/view.jsx
+++ b/ui/component/comment/view.jsx
@@ -117,12 +117,18 @@ function Comment(props: Props) {
     location: { pathname, search },
   } = useHistory();
 
+  const isInLinkedCommentChain =
+    linkedCommentId &&
+    linkedCommentAncestors[linkedCommentId] &&
+    linkedCommentAncestors[linkedCommentId].includes(commentId);
+  const showRepliesOnMount = isInLinkedCommentChain || AUTO_EXPAND_ALL_REPLIES;
+
   const [isReplying, setReplying] = React.useState(false);
   const [isEditing, setEditing] = useState(false);
   const [editedMessage, setCommentValue] = useState(message);
   const [charCount, setCharCount] = useState(editedMessage.length);
-  const [showReplies, setShowReplies] = useState(false);
-  const [page, setPage] = useState(0);
+  const [showReplies, setShowReplies] = useState(showRepliesOnMount);
+  const [page, setPage] = useState(showRepliesOnMount ? 1 : 0);
   const [advancedEditor] = usePersistedState('comment-editor-mode', false);
   const [displayDeadComment, setDisplayDeadComment] = React.useState(false);
   const hasChannels = myChannels && myChannels.length > 0;
@@ -140,19 +146,6 @@ function Comment(props: Props) {
     }
   } catch (e) {}
 
-  // Auto-expand (limited to linked-comments for now, but can be for all)
-  useEffect(() => {
-    const isInLinkedCommentChain =
-      linkedCommentId &&
-      linkedCommentAncestors[linkedCommentId] &&
-      linkedCommentAncestors[linkedCommentId].includes(commentId);
-
-    if (isInLinkedCommentChain || AUTO_EXPAND_ALL_REPLIES) {
-      setShowReplies(true);
-      setPage(1);
-    }
-  }, []); // eslint-disable-line react-hooks/exhaustive-deps
-
   useEffect(() => {
     if (isEditing) {
       setCharCount(editedMessage.length);