From c539ab91c0c9994e88c9487dd87ec9db9d318aee Mon Sep 17 00:00:00 2001
From: Jeffrey Fisher <jeff@slofish.io>
Date: Thu, 7 May 2020 12:41:20 -0700
Subject: [PATCH] Fix code review issues

---
 ui/component/socialShare/view.jsx | 95 +++++++++----------------------
 ui/scss/component/section.scss    |  1 +
 ui/util/url.js                    |  2 +-
 3 files changed, 30 insertions(+), 68 deletions(-)

diff --git a/ui/component/socialShare/view.jsx b/ui/component/socialShare/view.jsx
index 068befc76..ebf0f071b 100644
--- a/ui/component/socialShare/view.jsx
+++ b/ui/component/socialShare/view.jsx
@@ -8,7 +8,12 @@ import { generateDownloadUrl } from 'util/lbrytv';
 import useIsMobile from 'effects/use-is-mobile';
 import { FormField } from 'component/common/form';
 import { hmsToSeconds, secondsToHms } from 'util/time';
-import { generateLbryUrl, generateLbryWebUrl, generateEncodedLbryURL, generateOpenDotLbryDotComUrl } from 'util/url';
+import {
+  generateLbryContentUrl,
+  generateLbryWebUrl,
+  generateEncodedLbryURL,
+  generateOpenDotLbryDotComUrl,
+} from 'util/url';
 
 const IOS = !!navigator.platform && /iPad|iPhone|iPod/.test(navigator.platform);
 const SUPPORTS_SHARE_API = typeof navigator.share !== 'undefined';
@@ -28,47 +33,32 @@ function SocialShare(props: Props) {
   const [showExtra, setShowExtra] = React.useState(false);
   const [includeStartTime, setincludeStartTime]: [boolean, any] = React.useState(false);
   const [startTime, setStartTime]: [string, any] = React.useState(secondsToHms(position));
-  const [startTimeSeconds, setStartTimeSeconds]: [number, any] = React.useState(Math.floor(position));
+  const startTimeSeconds: number = hmsToSeconds(startTime);
   const isMobile = useIsMobile();
 
-  let canonicalUrl = 'lbry://';
-  let permanentUrl = 'lbry://';
-  let name = '';
-  let claimId = '';
-
-  if (claim) {
-    canonicalUrl = claim.canonical_url;
-    permanentUrl = claim.permanent_url;
-    name = claim.name;
-    claimId = claim.claim_id;
-  }
-
-  const isChannel = claim.value_type === 'channel';
-  const rewardsApproved = user && user.is_reward_approved;
-  const OPEN_URL = 'https://open.lbry.com/';
-  const lbryUrl: string = generateLbryUrl(canonicalUrl, permanentUrl);
-  const lbryWebUrl: string = generateLbryWebUrl(lbryUrl);
-  const [encodedLbryURL, setEncodedLbryURL]: [string, any] = React.useState(
-    generateEncodedLbryURL(OPEN_URL, lbryWebUrl, includeStartTime, startTime)
-  );
-  const [openDotLbryDotComUrl, setOpenDotLbryDotComUrl]: [string, any] = React.useState(
-    generateOpenDotLbryDotComUrl(
-      OPEN_URL,
-      lbryWebUrl,
-      canonicalUrl,
-      permanentUrl,
-      referralCode,
-      rewardsApproved,
-      includeStartTime,
-      startTime
-    )
-  );
-  const downloadUrl = `${generateDownloadUrl(name, claimId)}`;
-
   if (!claim) {
     return null;
   }
 
+  const { canonical_url: canonicalUrl, permanent_url: permanentUrl, name, claim_id: claimId } = claim;
+  const isChannel = claim.value_type === 'channel';
+  const rewardsApproved = user && user.is_reward_approved;
+  const OPEN_URL = 'https://open.lbry.com/';
+  const lbryUrl: string = generateLbryContentUrl(canonicalUrl, permanentUrl);
+  const lbryWebUrl: string = generateLbryWebUrl(lbryUrl);
+  const encodedLbryURL: string = generateEncodedLbryURL(OPEN_URL, lbryWebUrl, includeStartTime, startTimeSeconds);
+  const openDotLbryDotComUrl: string = generateOpenDotLbryDotComUrl(
+    OPEN_URL,
+    lbryWebUrl,
+    canonicalUrl,
+    permanentUrl,
+    referralCode,
+    rewardsApproved,
+    includeStartTime,
+    startTimeSeconds
+  );
+  const downloadUrl = `${generateDownloadUrl(name, claimId)}`;
+
   function handleWebShareClick() {
     if (navigator.share) {
       navigator.share({
@@ -78,35 +68,6 @@ function SocialShare(props: Props) {
     }
   }
 
-  function handleTimeCheckboxChange(checked) {
-    setincludeStartTime(checked);
-    updateUrls(checked, startTimeSeconds);
-  }
-
-  function handleTimeChange(value) {
-    setStartTime(value);
-    const startSeconds = hmsToSeconds(value);
-    setStartTimeSeconds(startSeconds);
-    updateUrls(true, startSeconds);
-  }
-
-  function updateUrls(includeStartTime, startTime) {
-    setOpenDotLbryDotComUrl(
-      generateOpenDotLbryDotComUrl(
-        OPEN_URL,
-        lbryWebUrl,
-        canonicalUrl,
-        permanentUrl,
-        referralCode,
-        rewardsApproved,
-        includeStartTime,
-        startTime
-      )
-    );
-
-    setEncodedLbryURL(generateEncodedLbryURL(OPEN_URL, lbryWebUrl, includeStartTime, startTime));
-  }
-
   return (
     <React.Fragment>
       <CopyableText label={__('LBRY Link')} copyable={openDotLbryDotComUrl} />
@@ -114,7 +75,7 @@ function SocialShare(props: Props) {
         <FormField
           type="checkbox"
           name="share_start_at_checkbox"
-          onChange={() => handleTimeCheckboxChange(!includeStartTime)}
+          onChange={() => setincludeStartTime(!includeStartTime)}
           checked={includeStartTime}
           label={__('Start at')}
         />
@@ -123,7 +84,7 @@ function SocialShare(props: Props) {
           name="share_start_at"
           value={startTime}
           disabled={!includeStartTime}
-          onChange={event => handleTimeChange(event.target.value)}
+          onChange={event => setStartTime(event.target.value)}
         />
       </div>
       <div className="section__actions">
diff --git a/ui/scss/component/section.scss b/ui/scss/component/section.scss
index 959f8b8cf..815166f41 100644
--- a/ui/scss/component/section.scss
+++ b/ui/scss/component/section.scss
@@ -141,6 +141,7 @@
 
 .section__start-at {
   display: flex;
+  align-items: center;
   margin-top: var(--spacing-large);
   fieldset-section {
     width: 6em;
diff --git a/ui/util/url.js b/ui/util/url.js
index b325e47ea..c0cb62844 100644
--- a/ui/util/url.js
+++ b/ui/util/url.js
@@ -71,7 +71,7 @@ exports.generateInitialUrl = hash => {
   return url;
 };
 
-exports.generateLbryUrl = (canonicalUrl, permanentUrl) => {
+exports.generateLbryContentUrl = (canonicalUrl, permanentUrl) => {
   return canonicalUrl ? canonicalUrl.split('lbry://')[1] : permanentUrl.split('lbry://')[1];
 };