LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Fix "muted=false + volume=0" case.

Browse source 
We need to handle two types of "mute":
- Volume icon is pressed to mute.
- Volume slider moved to 0%.
This commit is contained in:
infiinte-persistence 2020-06-11 20:55:30 +02:00 committed by Sean Yesmunt
parent 662778c47b
commit d01c20394e
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ui/component/viewers/videoViewer/internal/videojs.jsx
View file

@ -114,12 +114,15 @@ export default React.memo<Props>(function VideoJs(props: Props) {
function unmuteAndHideHint() { function unmuteAndHideHint() {
if (player) { if (player) {
player.muted(false); player.muted(false);
if (player.volume() === 0) {
player.volume(1.0);
}
} }
showTapToUnmute(false); showTapToUnmute(false);
} }
function onInitialPlay() { function onInitialPlay() {
if (player && player.muted()) { if (player && (player.muted() || player.volume() === 0)) {
// The css starts as "hidden". We make it visible here without // The css starts as "hidden". We make it visible here without
// re-rendering the whole thing. // re-rendering the whole thing.
showTapToUnmute(true); showTapToUnmute(true);