From d56b32ff192c474ff0c02f94db78f23e247ae73b Mon Sep 17 00:00:00 2001 From: btzr-io Date: Thu, 15 Jul 2021 19:13:54 -0500 Subject: [PATCH] simplify localization of claim-preview aria-label --- static/app-strings.json | 3 +-- ui/component/claimPreviewTile/view.jsx | 10 +++++----- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/static/app-strings.json b/static/app-strings.json index 5f1059235..a23c4413b 100644 --- a/static/app-strings.json +++ b/static/app-strings.json @@ -2054,7 +2054,6 @@ "Item removed from Watch Later": "Item removed from Watch Later", "Skip Navigation": "Skip Navigation", "In Favorites": "In Favorites", - "%title% by %channelTitle%, %mediaDuration%": "%title% by %channelTitle%, %mediaDuration%", - "%title% by %channelTitle%": "%title% by %channelTitle%", + "by %channelTitle%": "by %channelTitle%", "--end--": "--end--" } diff --git a/ui/component/claimPreviewTile/view.jsx b/ui/component/claimPreviewTile/view.jsx index c238b44fb..2bd427896 100644 --- a/ui/component/claimPreviewTile/view.jsx +++ b/ui/component/claimPreviewTile/view.jsx @@ -122,11 +122,11 @@ function ClaimPreviewTile(props: Props) { let ariaLabelData = title; if (!isChannel && channelTitle) { - if (mediaDuration) { - ariaLabelData = __('%title% by %channelTitle%, %mediaDuration%', { title, channelTitle, mediaDuration }); - } else { - ariaLabelData = __('%title% by %channelTitle%', { title, channelTitle }); - } + ariaLabelData += ' ' + __('by %channelTitle%', { channelTitle }); + } + + if (mediaDuration) { + ariaLabelData += ' ' + mediaDuration; } function handleClick(e) {