From dabdc980a1ff1446d03353192e19f9291340ca88 Mon Sep 17 00:00:00 2001 From: infinite-persistence Date: Thu, 25 Feb 2021 14:24:34 +0800 Subject: [PATCH] Fix 'makeSelectIsPlaying' to look at 'playing' instead of 'primary'. ## Issue 4959: Deleting MD from downloads list causes spinning icon to run forever 5077: player doesn't close when video deleted --- ui/redux/selectors/content.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/redux/selectors/content.js b/ui/redux/selectors/content.js index 2e1b355db..fe6c47db0 100644 --- a/ui/redux/selectors/content.js +++ b/ui/redux/selectors/content.js @@ -29,7 +29,7 @@ export const selectPlayingUri = createSelector(selectState, (state) => state.pla export const selectPrimaryUri = createSelector(selectState, (state) => state.primaryUri); export const makeSelectIsPlaying = (uri: string) => - createSelector(selectPrimaryUri, (primaryUri) => primaryUri === uri); + createSelector(selectPlayingUri, (playingUri) => playingUri && playingUri.uri === uri); export const makeSelectIsPlayerFloating = (location: UrlLocation) => createSelector(selectPrimaryUri, selectPlayingUri, selectClaimsByUri, (primaryUri, playingUri, claimsByUri) => {