LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Sanitize urls with single quotation marks

Browse source 
This fixes behavior for URLs with single quotes within them.
The behavior for a url like `https://severalglamorousthing.426729.repl.co/google's%20logo.png` would be no background at all; the CSS rule would change to `background-image: url((unknown));`.
This fixes the problem and adds `\` to every `'` in the image url.
The behavior of the repo with this fix would be a conversion of the url provided above to  `https://severalglamorousthing.426729.repl.co/google\'s%20logo.png`, which can be put into `\`url('${url}')\`` without breaking the CSS rule.
This commit is contained in:
Sesamestrong 2019-10-20 19:24:55 -04:00 committed by Sean Yesmunt
parent 122811d768
commit dbaf98412f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/ui/component/cardMedia/view.jsx
View file

@ -18,7 +18,7 @@ class CardMedia extends React.PureComponent<Props> {
} }
const url = thumbnail || Placeholder; const url = thumbnail || Placeholder;
return <div style={{ backgroundImage: `url('${url}')` }} className={className} />; return <div style={{ backgroundImage: `url('${url.replace(/'/g,"\\'")}')` }} className={className} />;
} }
} }