From 445e8430f4ab448a6f950e7077aaaa1255c8f8fc Mon Sep 17 00:00:00 2001 From: Sean Yesmunt Date: Thu, 13 Dec 2018 11:26:51 -0500 Subject: [PATCH 1/7] fix: subscribe button on search page --- src/renderer/component/channelTile/view.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/renderer/component/channelTile/view.jsx b/src/renderer/component/channelTile/view.jsx index 6bde45cd8..106c8ad11 100644 --- a/src/renderer/component/channelTile/view.jsx +++ b/src/renderer/component/channelTile/view.jsx @@ -42,7 +42,7 @@ class ChannelTile extends React.PureComponent { let subscriptionUri; if (claim) { channelName = claim.name; - subscriptionUri = claim.permanent_url; + subscriptionUri = `lbry://${claim.permanent_url}`; } const onClick = () => navigate('/show', { uri }); From 1d8b1290252df61a49bfd3a59543d1aa71e02239 Mon Sep 17 00:00:00 2001 From: Sean Yesmunt Date: Thu, 13 Dec 2018 11:51:37 -0500 Subject: [PATCH 2/7] fix: hide reward code modal after success --- src/renderer/index.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/renderer/index.js b/src/renderer/index.js index 83b72db69..8e2adb243 100644 --- a/src/renderer/index.js +++ b/src/renderer/index.js @@ -15,6 +15,7 @@ import { doDaemonReady, doAutoUpdate, doOpenModal, + doHideModal, } from 'redux/actions/app'; import { doToast, doBlackListedOutpointsSubscribe, isURIValid } from 'lbry-redux'; import { doNavigate } from 'redux/actions/navigation'; @@ -88,6 +89,10 @@ rewards.setCallback('rewardApprovalRequired', () => { app.store.dispatch(doOpenModal(MODALS.REWARD_APPROVAL_REQUIRED)); }); +rewards.setCallback('claimRewardSuccess', () => { + app.store.dispatch(doHideModal(MODALS.REWARD_APPROVAL_REQUIRED)); +}); + ipcRenderer.on('open-uri-requested', (event, uri, newSession) => { if (uri && uri.startsWith('lbry://')) { if (uri.startsWith('lbry://?verify=')) { From ddbd69a70c3a95ec34614bbf462af83d12c18b19 Mon Sep 17 00:00:00 2001 From: Sean Yesmunt Date: Thu, 13 Dec 2018 12:02:25 -0500 Subject: [PATCH 3/7] fix: update electron to 2.0.14 to prevent ubuntu 18 segfault --- package.json | 2 +- yarn.lock | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 43a0f0d96..6cf8de388 100644 --- a/package.json +++ b/package.json @@ -99,7 +99,7 @@ "decompress": "^4.2.0", "del": "^3.0.0", "devtron": "^1.4.0", - "electron": "^2.0.6", + "electron": "^2.0.14", "electron-builder": "^20.22.0", "electron-devtools-installer": "^2.2.3", "electron-publisher-s3": "^20.8.1", diff --git a/yarn.lock b/yarn.lock index c818642af..0a835d68f 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3185,9 +3185,9 @@ electron-window-state@^4.1.1: jsonfile "^2.2.3" mkdirp "^0.5.1" -electron@^2.0.6: - version "2.0.6" - resolved "https://registry.yarnpkg.com/electron/-/electron-2.0.6.tgz#8e5c1bd2ebc08fa7a6ee906de3753c1ece9d7300" +electron@^2.0.14: + version "2.0.14" + resolved "https://registry.yarnpkg.com/electron/-/electron-2.0.14.tgz#fad6766645e7c0cd10b4ae822d3167959735a870" dependencies: "@types/node" "^8.0.24" electron-download "^3.0.1" From 74305501af90b9cd8b136ec0fa0922dc504b654b Mon Sep 17 00:00:00 2001 From: Sean Yesmunt Date: Thu, 13 Dec 2018 12:13:14 -0500 Subject: [PATCH 4/7] update changelog --- CHANGELOG.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 666f8cf82..dd12400da 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,18 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ## [Unreleased] +### Added + +### Changed + +### Fixed + * Channel subscribe button on search page ([#2146](https://github.com/lbryio/lbry-desktop/pull/2146)) + * Close modal after redeeming reward code ([#2146](https://github.com/lbryio/lbry-desktop/pull/2146)) + * Update Electron to prevent segfault on Ubuntu@18.10 ([#2146](https://github.com/lbryio/lbry-desktop/pull/2146)) + + +## [0.26.0] - 2018-12-12 + ### Added * Redemption of custom reward codes via Rewards page ([#1935](https://github.com/lbryio/lbry-desktop/pull/1935)) * Ability to manage email preferences from Help page ([#1929](https://github.com/lbryio/lbry-desktop/pull/1929)) From 721262bd397018ec706034d752e65555d533dd26 Mon Sep 17 00:00:00 2001 From: Sean Yesmunt Date: Thu, 13 Dec 2018 17:38:51 -0500 Subject: [PATCH 5/7] copy: clearer subscription text --- .../page/subscriptions/internal/first-run.jsx | 23 +++++++++---------- 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/src/renderer/page/subscriptions/internal/first-run.jsx b/src/renderer/page/subscriptions/internal/first-run.jsx index 12771bdda..058fd39b7 100644 --- a/src/renderer/page/subscriptions/internal/first-run.jsx +++ b/src/renderer/page/subscriptions/internal/first-run.jsx @@ -43,18 +43,17 @@ export default (props: Props) => {