LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Don't run filters unless necessary

Browse source 
The loop was executed over the entire `tileUris` regardless of whether `excludeUris` existed.
This commit is contained in:
infinite-persistence 2022-03-20 15:13:30 +08:00 committed by Thomas Zarebczan
parent c4d6fa9ff0
commit e634c728f0
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ui/component/claimList/view.jsx
View file

@ -114,14 +114,18 @@ export default function ClaimList(props: Props) {
const urisLength = (uris && uris.length) || 0; const urisLength = (uris && uris.length) || 0;
let tileUris = (prefixUris || []).concat(uris || []); let tileUris = (prefixUris || []).concat(uris || []);
tileUris = tileUris.filter((uri) => !excludeUris.includes(uri));
if (excludeUris && excludeUris.length) {
tileUris = tileUris.filter((uri) => !excludeUris.includes(uri));
}
if (prefixUris && prefixUris.length) tileUris.splice(prefixUris.length * -1, prefixUris.length); if (prefixUris && prefixUris.length) tileUris.splice(prefixUris.length * -1, prefixUris.length);
const totalLength = tileUris.length; const totalLength = tileUris.length;
if (maxClaimRender) tileUris = tileUris.slice(0, maxClaimRender); if (maxClaimRender) tileUris = tileUris.slice(0, maxClaimRender);
let sortedUris = (urisLength > 0 && (currentSort === SORT_NEW ? tileUris : tileUris.slice().reverse())) || []; const sortedUris = (urisLength > 0 && (currentSort === SORT_NEW ? tileUris : tileUris.slice().reverse())) || [];
React.useEffect(() => { React.useEffect(() => {
if (typeof loadedCallback === 'function') loadedCallback(totalLength); if (typeof loadedCallback === 'function') loadedCallback(totalLength);