From fa1b1737bbe735f6c67e52cc549aa241210ec78c Mon Sep 17 00:00:00 2001
From: btzr-io <btzr.io@gmail.com>
Date: Fri, 30 Jul 2021 00:00:33 -0500
Subject: [PATCH] fix inconsistent theme css vars: fixes #6738

---
 ui/scss/component/menu-button.scss           | 7 ++-----
 ui/scss/init/_base-theme.scss                | 3 +--
 ui/scss/themes/dark.scss                     | 3 +--
 web/scss/themes/lbrytv/dark.scss             | 1 +
 web/scss/themes/odysee/init/_base-theme.scss | 1 +
 5 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/ui/scss/component/menu-button.scss b/ui/scss/component/menu-button.scss
index bb94ec35e..5f32d66ad 100644
--- a/ui/scss/component/menu-button.scss
+++ b/ui/scss/component/menu-button.scss
@@ -51,10 +51,7 @@
   padding: 0.3rem;
 
   .icon {
-    stroke: var(--color-menu);
-  }
-
-  .comment__menu-icon--hovering {
+    stroke: var(--color-menu-icon);
   }
 
   &:focus,
@@ -62,7 +59,7 @@
     opacity: 1;
     background-color: var(--color-button-alt-bg);
     .icon {
-      stroke: var(--color-menu-hovering);
+      stroke: var(--color-menu-icon-active);
     }
   }
 }
diff --git a/ui/scss/init/_base-theme.scss b/ui/scss/init/_base-theme.scss
index 4a34619d0..58ca7b7a5 100644
--- a/ui/scss/init/_base-theme.scss
+++ b/ui/scss/init/_base-theme.scss
@@ -124,8 +124,7 @@
   --color-menu-background: var(--color-header-background);
   --color-menu-background--active: var(--color-card-background-highlighted);
   --color-menu-icon: var(--color-navigation-link);
-  --color-menu: var(--color-gray-3);
-  --color-menu-hovering: var(--color-gray-6);
+  --color-menu-icon-active: var(--color-gray-6);
 
   // Comments
   --color-comment-highlighted: #fff2d9;
diff --git a/ui/scss/themes/dark.scss b/ui/scss/themes/dark.scss
index edc0bbf7c..bebc2af07 100644
--- a/ui/scss/themes/dark.scss
+++ b/ui/scss/themes/dark.scss
@@ -90,8 +90,7 @@
   --color-menu-background: var(--color-header-background);
   --color-menu-background--active: var(--color-gray-7);
   --color-menu-icon: var(--color-gray-4);
-  --color-menu: var(--color-gray-5);
-  --color-menu-hovering: var(--color-gray-2);
+  --color-menu-icon-active: var(--color-gray-2);
 
   // Comments
   --color-comment-threadline: #434b54;
diff --git a/web/scss/themes/lbrytv/dark.scss b/web/scss/themes/lbrytv/dark.scss
index b244eefa6..ab79d895f 100644
--- a/web/scss/themes/lbrytv/dark.scss
+++ b/web/scss/themes/lbrytv/dark.scss
@@ -90,6 +90,7 @@
   --color-menu-background: var(--color-header-background);
   --color-menu-background--active: var(--color-gray-7);
   --color-menu-icon: var(--color-gray-4);
+  --color-menu-icon-active: var(--color-gray-2);
 
   // Comments
   --color-comment-menu: var(--color-gray-5);
diff --git a/web/scss/themes/odysee/init/_base-theme.scss b/web/scss/themes/odysee/init/_base-theme.scss
index 02313f1e1..76096b53c 100644
--- a/web/scss/themes/odysee/init/_base-theme.scss
+++ b/web/scss/themes/odysee/init/_base-theme.scss
@@ -124,6 +124,7 @@
   --color-menu-background: var(--color-header-background);
   --color-menu-background--active: var(--color-card-background-highlighted);
   --color-menu-icon: var(--color-navigation-link);
+  --color-menu-icon-active: var(--color-navigation-link);
 
   // Comments
   --color-comment-menu: var(--color-gray-3);