add review changes

This commit is contained in:
jessop 2020-01-24 10:44:37 -05:00 committed by Sean Yesmunt
parent 75410392d8
commit fab7dfdb41
2 changed files with 2 additions and 6 deletions

View file

@ -51,8 +51,7 @@
"electron-updater": "^4.1.2", "electron-updater": "^4.1.2",
"express": "^4.17.1", "express": "^4.17.1",
"if-env": "^1.0.4", "if-env": "^1.0.4",
"keytar": "^4.4.1", "keytar": "^4.4.1"
"videojs-event-tracking": "^1.0.1"
}, },
"devDependencies": { "devDependencies": {
"@babel/core": "^7.0.0", "@babel/core": "^7.0.0",
@ -188,6 +187,7 @@
"tree-kill": "^1.1.0", "tree-kill": "^1.1.0",
"unist-util-visit": "^1.4.1", "unist-util-visit": "^1.4.1",
"video.js": "^7.2.2", "video.js": "^7.2.2",
"videojs-event-tracking": "^1.0.1",
"villain-react": "^1.0.6", "villain-react": "^1.0.6",
"wavesurfer.js": "^2.2.1", "wavesurfer.js": "^2.2.1",
"webpack": "^4.28.4", "webpack": "^4.28.4",

View file

@ -213,13 +213,9 @@ function VideoViewer(props: Props) {
function doTrackingFirstPlay(e: Event, data: any) { function doTrackingFirstPlay(e: Event, data: any) {
analytics.videoStartEvent(claimId, data.secondsToLoad); analytics.videoStartEvent(claimId, data.secondsToLoad);
} }
function doError(e: Event) {
console.log('ERROR', e);
}
if (player) { if (player) {
player.on('tracking:buffered', (e, d) => doTrackingBuffered(e, d)); player.on('tracking:buffered', (e, d) => doTrackingBuffered(e, d));
player.on('tracking:firstplay', (e, d) => doTrackingFirstPlay(e, d)); player.on('tracking:firstplay', (e, d) => doTrackingFirstPlay(e, d));
player.on('error', e => doError(e));
} }
return () => { return () => {
if (player) { if (player) {