Commit graph

61 commits

Author SHA1 Message Date
infiinte-persistence
2754c962a4 Inf-scroll: Fix glitch when results are exactly the page size.
## Issue
Fixes 2675 `Claim search with exactly 20 results keep fetching next page`

## Changes
Use `claimSearchResultLastPageReached` (I didn't know it existed back then).

The unnecessary "loading" refresh will still happen one time, but at least now it doesn't happen every time we scroll to the bottom (and incorrectly incrementing 'page').
2020-07-14 16:05:42 -04:00
Sean Yesmunt
fa7f74f979 bring in comments/blocked code from 'lbry-redux' 2020-07-14 15:57:19 -04:00
infiinte-persistence
860e5f097c Inf-scroll: Handle case of "pop from claim"
This is a follow-up on PR-4392.

## Issue:
The previous PR covered "pop from within the same page but with different query/order", but missed "pop after entering a claim".

1. Click `Your Tags`.
2. Set order to `New`.
3. Restart app or reload (crucial step)
4. Click `Your Tags`.
5. Click any claim.
6. `Back`. The order incorrectly resets to `Trending` -- it should stay at `New`.
2020-07-13 14:30:58 -04:00
Suisse00
406ca3b998 Un hardcoded price filter label options 2020-07-03 17:05:23 -04:00
infiinte-persistence
87e53db699 Don't expand search filters automatically if popping from Back action.
The existing behavior of automatically expanding when needed && when entering the page is still maintained.
2020-07-01 11:11:47 -04:00
infiinte-persistence
ad37edf681 Inf-scroll: Fix scroll not working when navigating back from claim.
## Fixes:
3071: "Infinite scroll stops working when navigating to file page / back"

## The Issue:
In the POP operation, the `page` value is back to 1 due to the initializer `useState(1)`. If the results cache already contained more than 1 page's worth, then the rest of the logic thinks there's nothing to do.

## The Fix:
Previous fixes to Inf-Scroll added a "page correction" code to handle the mismatch. This fix simply adds this scenario to the list of scenarios to perform the correction.
2020-07-01 11:11:47 -04:00
Sean Yesmunt
41abbcc861 Revert "bring in blocked redux code from lbry-redux"
This reverts commit b9f3146180.
2020-06-23 16:21:40 -04:00
Sean Yesmunt
b9f3146180 bring in blocked redux code from lbry-redux 2020-06-23 16:01:20 -04:00
infiinte-persistence
1cd18ac9f4 Inf-scroll: (1) Reset to top (2) Fix "page vs. results" being out of sync.
--- Issues:
(1) #-2669: Page does not restore to top when navigating new tags.

(2) "Encountered children with the same key" error (duplicate entries shown).
https://github.com/lbryio/lbry-desktop/issues/4367#issuecomment-645449206

--- Changes:
(1) Ignore the history if it's a new query (i.e. explicitly clicked). The BACK history will still behave as normal (doesn't reset to top).

(2) Previously, the `page` variable will continue to increment as you scroll and stay within the page (e.g. Trending vs New, or clicked another Tag). As you move between queries, we hit a scenario where `page` is significantly under or over the latest retrieved `claimSearchResult.length`. This messes up the rest of the code.

Fix by correcting the value of `page` according to the current `claimSearchResult.length` when necessary.
2020-06-22 09:31:05 -04:00
Sean Yesmunt
fa246a7f1f move channel search into ChannelContent component 2020-06-18 12:19:21 -04:00
infiinte-persistence
bbda69dc5f Inf-scroll: Don't add pages when no more results are available.
--- The bad scenario:
A less popular tag like 'kanji' yields only 23 results today. The code continues to increase the page count. We'll either see some blank page glitches at the bottom, or repeated entries being shown.

--- The fix:
Assume that an unfilled page means "no more results" and stop incrementing the page. This seems true based on empirical evidence.
2020-06-16 16:59:00 -04:00
infiinte-persistence
9d6af38a21 Persist trending selectors between tags.
---The issue:
When switching between tags, the selector defaults back to Trending even though you had another option already selected.

---Changes:
- 'orderParamUser' will store the last user state persistently. The persistent state is also made unique for each page (i.e. Your Tags and All Content will be unique).

- If the parent component passes in a specific order, that will be respected and will also become the new persisted value. One example is "Your Following", where it always starts at 'New'.

- Handled navigation history correctly
The test case:
   - Enter "Your Tags" (assume start at 'Trending')
   - Click 'New'
   - Click 'Top'
   - Back
   - Back (it should return to 'Trending')
As the top page history does not have any "?order=" value, we ended up with a no-op for the last Back. 'orderParamEntry' is added to handle this.
2020-06-16 16:36:23 -04:00
Sean Yesmunt
c2abcf110c
Paid content on lbry.tv (#4197) 2020-05-21 11:38:28 -04:00
Sean Yesmunt
919f82ba94 purchases page, cleanup on pages with <ClaimList /> 2020-05-11 12:31:22 -04:00
jessop
867b5eb134 two bugfixes: i18n tags, all reposts loading loop 2020-04-29 15:49:14 -04:00
jessop
a411ec9b47 reenable reposts
reenable reposts and track for emails

review changes

change showReposts to hideReposts due to persist hydrate issue

bugfix

bugfix
2020-04-28 10:25:05 -04:00
Sean Yesmunt
2ed3623b59 make invite string more manageable for translations 2020-04-22 15:45:35 -04:00
Mr. X
7893512e2b feat: Invited Link Displays Channel Content 2020-04-22 15:45:35 -04:00
jessop
24eb0c2aea review changes 2020-04-15 11:12:29 -04:00
Sean Yesmunt
25bf9290e1 only show timed out message when claim_search times out 2020-03-31 12:09:15 -04:00
Sean Yesmunt
c4fc2993d5 initial commit for inline video ads 2020-03-30 09:40:10 -04:00
Sean Yesmunt
6e953c098c fix reposts page when navigating directly by url 2020-03-24 12:32:44 -04:00
Jeremy Kauffman
73d2eebb07 display repost counts on file pages, link to all reposts 2020-03-19 13:56:45 -04:00
jessop
d9e65e8328 select tags before channels and filter channels by tag
moartags

CS tags followed category
continue button,
Remove card header on tags select

limitShow tags count

tags limit fix

debug cs tags highlighting

bugfix

yarnlock
2020-03-16 16:47:22 -04:00
jessop
a07fb2514e sync tags with lbry on startup and change 2020-03-11 21:47:48 -04:00
jessop
60e74ad4a7 fixes defaults for channel follow intro 2020-03-01 17:56:47 -05:00
jessop
5e1ba4aaf5 claim search options tweaks
add image, bodel, binary
fix duration reset/disable
2020-02-29 12:24:13 -05:00
Sean Yesmunt
0e1e67cb9d disable repost setting 2020-02-28 17:36:22 -05:00
Sean Yesmunt
98e0e57de7 fix typo 2020-02-28 17:13:35 -05:00
Sean Yesmunt
ffd2c4f793 hide claimList filters on channel discovery and sign in pages 2020-02-28 16:55:48 -05:00
jessop
8b261b57ff freshness default 2020-02-28 13:30:29 -05:00
jessop
9dc9d50e19 add options card to claim search
changes

almost done

wip

wip

more

changes after comment

detect custom qs and show options

ux and mobile styling

bugfix

console logs

appstrings
2020-02-28 13:30:29 -05:00
Sean Yesmunt
ef2171e457 use lbry-redux constants for view settings 2020-02-28 12:37:43 -05:00
Sean Yesmunt
565cbb2502 default claim_type to "stream", "channel", and "repost" 2020-02-28 12:37:43 -05:00
Lukewh
26168670dd Repost settings 2020-02-28 12:37:43 -05:00
Sean Yesmunt
cb89b05646 fix infinite scroll on channel discovery page 2020-02-28 09:37:31 -05:00
Sean Yesmunt
cc94cb6745 hide block button on channel discovery page 2020-02-28 09:37:31 -05:00
Sean Yesmunt
3e08d8e231 basic channel discovery in first run 2020-02-28 09:37:31 -05:00
Sean Yesmunt
dc38c8f809 add claim_type support to tags page 2020-02-21 11:39:31 -05:00
Sean Yesmunt
2619adb880 add supports to 'top' page 2020-02-12 15:34:59 -05:00
Sean Yesmunt
6a529d55ba mvp for 'top' page 2020-02-11 15:02:29 -05:00
Thomas Zarebczan
dacdc59b93 fix: temp hack for future content
This at least would work on the new/trending + all content page until the SDK Fixes it.
2020-01-29 10:14:57 -05:00
Thomas Zarebczan
3aa04f278b fix: fix hack on New + following/tags page
Would never hit the 2nd condition.
2020-01-28 10:30:44 -05:00
Sean Yesmunt
e0a04afea4 only pass not_channel_ids if there are no channel_ids passed in to claim_search 2020-01-24 15:43:07 -05:00
Sean Yesmunt
7a9fd8488b add second release_time hack for people with more than 20 channels 2020-01-24 15:38:33 -05:00
Sean Yesmunt
9aab2092e6 additional comment info 2020-01-24 11:34:05 -05:00
Sean Yesmunt
d236712134 add comment 2020-01-24 11:34:05 -05:00
Thomas Zarebczan
9a1a3d7fa6 Fix: improve release time claim search
To improve search performance, assume we want content from the past year when viewing new and trending. Also pass rounded values to top so queries don't re-execute incorrectly.
2020-01-24 11:34:05 -05:00
Jeremy Kauffman
ebe41202a9 i18n change I forgot to push 2020-01-16 15:06:07 -05:00
Sean Yesmunt
c29be5b7ec automatically get free images and display as thumbnails 2020-01-13 14:38:14 -05:00