Automatic dark mode #733

New issue

Closed

opened 2017-11-12 07:57:25 +01:00 by neb-b · 8 comments

neb-b commented

2017-11-12 07:57:25 +01:00

(Migrated from github.com)

Something like this (terrible mock up)
screen shot 2017-11-13 at 5 15 09 pm

We should offer an option to switch to the dark mode automatically. This would automatically switch to dark mode after some time (9pm). Extended functionality could be allowing the user to set the time at which the theme switches over. Something like this (terrible mock up) <img width="348" alt="screen shot 2017-11-13 at 5 15 09 pm" src="https://user-images.githubusercontent.com/16882830/32752356-dc68683c-c896-11e7-8d96-4f4e70c1fb84.png">

liamcardenas commented

2017-11-20 22:18:23 +01:00

(Migrated from github.com)

Can you make sure to explain what automatic dark mode is in app?

neb-b commented

2017-11-20 22:38:27 +01:00

(Migrated from github.com)

Yeah. Will definitely have some explanation next to the toggle.

On Mon, Nov 20, 2017 at 4:18 PM Liam Cardenas notifications@github.com
wrote:

Can you make sure to explain what automatic dark mode is in app?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/issues/733#issuecomment-345834977,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQGcjn0goG2F__-cJ2udvsAJea_m6G_Gks5s4ey8gaJpZM4Qax--
.

Yeah. Will definitely have some explanation next to the toggle. On Mon, Nov 20, 2017 at 4:18 PM Liam Cardenas <notifications@github.com> wrote: > Can you make sure to explain what automatic dark mode is in app? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-app/issues/733#issuecomment-345834977>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AQGcjn0goG2F__-cJ2udvsAJea_m6G_Gks5s4ey8gaJpZM4Qax--> > . >

MSFTserver commented

2018-01-07 23:49:35 +01:00

(Migrated from github.com)

I'm about to start looking at the app again if this isn't being worked on id be glad to help shouldnt be hard detecting a user's local time settings a theme to trigger certain times using a cache system since its web based app

neb-b commented

2018-01-08 05:38:23 +01:00

(Migrated from github.com)

Yeah I think this would be a great feature to have. Agreed that it
shouldn't be too difficult.

On Jan 7, 2018 2:49 PM, "MSFTserver" notifications@github.com wrote:

I'm about to start looking at the app again if this isn't being worked on
id be glad to help shouldnt be hard detecting a user's local time settings
a theme to trigger certain times using a cache system since its web based
app

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/issues/733#issuecomment-355859560,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQGcjg2HoO7XzSmlKgPElPFDtNPlAJgSks5tIUoBgaJpZM4Qax--
.

Yeah I think this would be a great feature to have. Agreed that it shouldn't be too difficult. On Jan 7, 2018 2:49 PM, "MSFTserver" <notifications@github.com> wrote: > I'm about to start looking at the app again if this isn't being worked on > id be glad to help shouldnt be hard detecting a user's local time settings > a theme to trigger certain times using a cache system since its web based > app > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-app/issues/733#issuecomment-355859560>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AQGcjg2HoO7XzSmlKgPElPFDtNPlAJgSks5tIUoBgaJpZM4Qax--> > . >

Arrowana commented

2018-01-13 12:11:16 +01:00

(Migrated from github.com)

I would like to implement this, I might take a bit of time as this will be my first feature implementation (not familiar with electron).

The theme dropdown will be greyed-out when "automatic dark mode" is enabled (checked).

I would like to implement this, I might take a bit of time as this will be my first feature implementation (not familiar with electron). The theme dropdown will be greyed-out when "automatic dark mode" is enabled (checked).

Arrowana commented

2018-01-14 10:17:02 +01:00

(Migrated from github.com)

I have the basic idea working
Arrowana/lbry-app@8eb7f58988

I am not sure about the required value I added in the settings store: isNight
There isn't any appropriate place where this could be stored

I have the basic idea working https://github.com/Arrowana/lbry-app/commit/8eb7f589889285defeb11dd4889704a9ca6186fd I am not sure about the required value I added in the settings store: isNight There isn't any appropriate place where this could be stored

🎉 1

neb-b commented

2018-01-14 10:41:24 +01:00

(Migrated from github.com)

@Arrowana Awesome! Can you make a PR for you changes? I have a few comments but it looks great.

tzarebczan commented

2018-02-05 19:44:45 +01:00

(Migrated from github.com)

Closed via https://github.com/lbryio/lbry-app/pull/950