diff --git a/CHANGELOG.md b/CHANGELOG.md index f9fe830fe..be6756066 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -56,6 +56,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/). * URI and outpoint not being passed properly to API ([#1494](https://github.com/lbryio/lbry-app/issues/1494)) * Incorrect markdown preview on url with parentheses ([#1570](https://github.com/lbryio/lbry-app/issues/1570)) * Fix Linux upgrade path and add manual installation note ([#1606](https://github.com/lbryio/lbry-app/issues/1606)) + * Fix can type in unfocused fields while publishing without selecting file ([#1456](https://github.com/lbryio/lbry-app/issues/1456)) diff --git a/src/renderer/component/wunderbar/internal/autocomplete.jsx b/src/renderer/component/wunderbar/internal/autocomplete.jsx index 87c2ec46e..da67431ad 100644 --- a/src/renderer/component/wunderbar/internal/autocomplete.jsx +++ b/src/renderer/component/wunderbar/internal/autocomplete.jsx @@ -190,8 +190,9 @@ export default class Autocomplete extends React.Component { background: 'rgba(255, 255, 255, 0.9)', padding: '2px 0', fontSize: '90%', - position: 'absolute', + position: 'fixed', overflow: 'hidden', + maxHeight: '50%', // TODO: don't cheat, let it flow to the bottom, }, autoHighlight: true, selectOnBlur: false, @@ -409,13 +410,12 @@ export default class Autocomplete extends React.Component { const node = this.refs.input; const rect = node.getBoundingClientRect(); const computedStyle = global.window.getComputedStyle(node); - // const marginBottom = parseInt(computedStyle.marginBottom, 10) || 0; + const marginBottom = parseInt(computedStyle.marginBottom, 10) || 0; const marginLeft = parseInt(computedStyle.marginLeft, 10) || 0; const marginRight = parseInt(computedStyle.marginRight, 10) || 0; this.setState({ - // We may need these if we go back to a fixed header - // menuTop: rect.bottom + marginBottom, - // menuLeft: rect.left + marginLeft, + menuTop: rect.bottom + marginBottom, + menuLeft: rect.left + marginLeft, menuWidth: rect.width + marginLeft + marginRight, }); } diff --git a/src/renderer/component/wunderbar/view.jsx b/src/renderer/component/wunderbar/view.jsx index 5c3917a09..2ee8dfb19 100644 --- a/src/renderer/component/wunderbar/view.jsx +++ b/src/renderer/component/wunderbar/view.jsx @@ -92,7 +92,7 @@ class WunderBar extends React.PureComponent { item.value} diff --git a/src/renderer/scss/component/_card.scss b/src/renderer/scss/component/_card.scss index 41ffd5473..995a37cba 100644 --- a/src/renderer/scss/component/_card.scss +++ b/src/renderer/scss/component/_card.scss @@ -66,6 +66,7 @@ .card--disabled { opacity: 0.3; + pointer-events: none; } .card__media { diff --git a/src/renderer/scss/component/_search.scss b/src/renderer/scss/component/_search.scss index 7e1c460f3..74e4eeca5 100644 --- a/src/renderer/scss/component/_search.scss +++ b/src/renderer/scss/component/_search.scss @@ -10,7 +10,6 @@ position: absolute; left: 10px; top: 10px; - z-index: 1; } }