From 5fd72af0f82f36fc4ddb5a873e9621b0194ec42d Mon Sep 17 00:00:00 2001 From: Sean Yesmunt Date: Wed, 20 Jun 2018 18:58:55 -0400 Subject: [PATCH 1/3] fix: stick autocomplete --- .../component/wunderbar/internal/autocomplete.jsx | 10 +++++----- src/renderer/component/wunderbar/view.jsx | 2 +- src/renderer/scss/component/_search.scss | 1 + 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/renderer/component/wunderbar/internal/autocomplete.jsx b/src/renderer/component/wunderbar/internal/autocomplete.jsx index da67431ad..87c2ec46e 100644 --- a/src/renderer/component/wunderbar/internal/autocomplete.jsx +++ b/src/renderer/component/wunderbar/internal/autocomplete.jsx @@ -190,9 +190,8 @@ export default class Autocomplete extends React.Component { background: 'rgba(255, 255, 255, 0.9)', padding: '2px 0', fontSize: '90%', - position: 'fixed', + position: 'absolute', overflow: 'hidden', - maxHeight: '50%', // TODO: don't cheat, let it flow to the bottom, }, autoHighlight: true, selectOnBlur: false, @@ -410,12 +409,13 @@ export default class Autocomplete extends React.Component { const node = this.refs.input; const rect = node.getBoundingClientRect(); const computedStyle = global.window.getComputedStyle(node); - const marginBottom = parseInt(computedStyle.marginBottom, 10) || 0; + // const marginBottom = parseInt(computedStyle.marginBottom, 10) || 0; const marginLeft = parseInt(computedStyle.marginLeft, 10) || 0; const marginRight = parseInt(computedStyle.marginRight, 10) || 0; this.setState({ - menuTop: rect.bottom + marginBottom, - menuLeft: rect.left + marginLeft, + // We may need these if we go back to a fixed header + // menuTop: rect.bottom + marginBottom, + // menuLeft: rect.left + marginLeft, menuWidth: rect.width + marginLeft + marginRight, }); } diff --git a/src/renderer/component/wunderbar/view.jsx b/src/renderer/component/wunderbar/view.jsx index 2ee8dfb19..5c3917a09 100644 --- a/src/renderer/component/wunderbar/view.jsx +++ b/src/renderer/component/wunderbar/view.jsx @@ -92,7 +92,7 @@ class WunderBar extends React.PureComponent { item.value} diff --git a/src/renderer/scss/component/_search.scss b/src/renderer/scss/component/_search.scss index 74e4eeca5..7e1c460f3 100644 --- a/src/renderer/scss/component/_search.scss +++ b/src/renderer/scss/component/_search.scss @@ -10,6 +10,7 @@ position: absolute; left: 10px; top: 10px; + z-index: 1; } } -- 2.45.2 From 68d766e670b9018aff6f488b1b97d23cbb64b61a Mon Sep 17 00:00:00 2001 From: btzr-io Date: Wed, 20 Jun 2018 17:27:35 -0600 Subject: [PATCH 2/3] block pointer events of disabled cards #1456 --- src/renderer/scss/component/_card.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/src/renderer/scss/component/_card.scss b/src/renderer/scss/component/_card.scss index 41ffd5473..995a37cba 100644 --- a/src/renderer/scss/component/_card.scss +++ b/src/renderer/scss/component/_card.scss @@ -66,6 +66,7 @@ .card--disabled { opacity: 0.3; + pointer-events: none; } .card__media { -- 2.45.2 From 611a890888951890ed61e0818dc07ae4bb9369f3 Mon Sep 17 00:00:00 2001 From: Baltazar Gomez Date: Wed, 20 Jun 2018 18:41:03 -0600 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f9fe830fe..be6756066 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -56,6 +56,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/). * URI and outpoint not being passed properly to API ([#1494](https://github.com/lbryio/lbry-app/issues/1494)) * Incorrect markdown preview on url with parentheses ([#1570](https://github.com/lbryio/lbry-app/issues/1570)) * Fix Linux upgrade path and add manual installation note ([#1606](https://github.com/lbryio/lbry-app/issues/1606)) + * Fix can type in unfocused fields while publishing without selecting file ([#1456](https://github.com/lbryio/lbry-app/issues/1456)) -- 2.45.2