LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Newnew #2144

Merged
neb-b merged 8 commits from newnew into master 2018-12-19 06:44:54 +01:00
Conversation 0 Commits 8 Files changed 126 +4435 -13771
126 changed files with 4435 additions and 13771 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
package.json
View file

@ -46,6 +46,7 @@
"electron-log": "^2.2.12",
"electron-updater": "^2.23.3",
"electron-window-state": "^4.1.1",
"filewatcher-webpack-plugin": "^1.2.0",
"find-process": "^1.1.0",
"formik": "^0.10.4",
"hast-util-sanitize": "^1.1.2",
@ -89,6 +90,7 @@
},
"devDependencies": {
"@lbry/color": "^1.0.2",
"@lbry/components": "^1.5.1",
"axios": "^0.18.0",
"babel-eslint": "^8.2.2",
"babel-plugin-module-resolver": "^3.1.1",
@ -113,7 +115,6 @@
"eslint-plugin-jsx-a11y": "^6.0.3",
"eslint-plugin-prettier": "^2.6.0",
"eslint-plugin-react": "^7.7.0",
"filewatcher-webpack-plugin": "^1.2.0",
"flow-bin": "^0.69.0",
"flow-typed": "^2.3.0",
"husky": "^0.14.3",

1
src/main/index.js
View file

@ -67,7 +67,6 @@ app.on('ready', async () => {
// Windows WMIC returns lbrynet start with 2 spaces. https://github.com/yibn2008/find-process/issues/18
const processListArgs = process.platform === 'win32' ? 'lbrynet start' : 'lbrynet start';
const processList = await findProcess('name', processListArgs);
const isDaemonRunning = processList.length > 0;
if (!isDaemonRunning) {

2
src/renderer/component/address/view.jsx
View file

@ -23,7 +23,7 @@ export default class Address extends React.PureComponent<Props> {
const { address, doToast } = this.props;
return (
<FormRow verticallyCentered padded stretch>
<FormRow verticallyCentered stretch>
<input
className="input-copyable form-field__input"
readOnly

1
src/renderer/component/app/view.jsx
View file

@ -89,6 +89,7 @@ class App extends React.PureComponent<Props> {
scrollListener() {
const { recordScroll } = this.props;
if (this.mainContent) {
recordScroll(this.mainContent.scrollTop);
}

12
src/renderer/component/button/view.jsx
View file

@ -23,7 +23,8 @@ type Props = {
noPadding: ?boolean, // to remove padding and allow circular buttons
uppercase: ?boolean,
iconColor?: string,
tourniquet: ?boolean, // to shorten the button and ellipsis, only use for links
iconSize?: number,
constrict: ?boolean, // to shorten the button and ellipsis, only use for links
};
class Button extends React.PureComponent<Props> {
@ -51,7 +52,8 @@ class Button extends React.PureComponent<Props> {
noPadding,
uppercase,
iconColor,
tourniquet,
iconSize,
constrict,
...otherProps
} = this.props;
@ -71,7 +73,7 @@ class Button extends React.PureComponent<Props> {
'btn--link': button === 'link',
'btn--external-link': button === 'link' && href,
'btn--uppercase': uppercase,
'btn--tourniquet': tourniquet,
'btn--constrict': constrict,
}
: 'btn--no-style',
className
@ -87,10 +89,10 @@ class Button extends React.PureComponent<Props> {
const content = (
<span className="btn__content">
{icon && <Icon icon={icon} iconColor={iconColor} />}
{icon && <Icon icon={icon} iconColor={iconColor} size={iconSize} />}
{label && <span className="btn__label">{label}</span>}
{children && children}
{iconRight && <Icon icon={iconRight} iconColor={iconColor} />}
{iconRight && <Icon icon={iconRight} iconColor={iconColor} size={iconSize} />}
</span>
);

16
src/renderer/component/cardMedia/view.jsx
View file

@ -1,6 +1,6 @@
// @flow
import React from 'react';
import classnames from 'classnames';
import Native from 'native';
type Props = {
thumbnail: ?string, // externally sourced image
@ -12,13 +12,13 @@ class CardMedia extends React.PureComponent<Props> {
return (
<div
style={thumbnail ? { backgroundImage: `url('${thumbnail}')` } : {}}
className={classnames('card__media', {
'card__media--no-img': !thumbnail,
})}
>
{!thumbnail && <span className="card__media-text">LBRY</span>}
</div>
style={
thumbnail
? { backgroundImage: `url('${thumbnail}')` }
: { backgroundImage: `url('${Native.imagePath('placeholder.png')}')` }
}
className="media__thumb"
/>
);
}
}

66
src/renderer/component/categoryList/view.jsx
View file

@ -7,7 +7,6 @@ import ToolTip from 'component/common/tooltip';
import FileCard from 'component/fileCard';
import Button from 'component/button';
import SubscribeButton from 'component/subscribeButton';
import classnames from 'classnames';
type Props = {
category: string,
@ -17,7 +16,6 @@ type Props = {
channelClaims: ?Array<Claim>,
fetchChannel: string => void,
obscureNsfw: boolean,
isSubComponent: boolean,
};
type State = {
@ -28,7 +26,6 @@ type State = {
class CategoryList extends PureComponent<Props, State> {
static defaultProps = {
categoryLink: '',
isSubComponent: false,
};
constructor() {
@ -210,32 +207,29 @@ class CategoryList extends PureComponent<Props, State> {
}
render() {
const {
category,
categoryLink,
names,
channelClaims,
obscureNsfw,
isSubComponent,
} = this.props;
const { category, categoryLink, names, channelClaims, obscureNsfw } = this.props;
const { canScrollNext, canScrollPrevious } = this.state;
const isCommunityTopBids = category.match(/^community/i);
const showScrollButtons = isCommunityTopBids ? !obscureNsfw : true;
// isSubComponent is a hack, this component should be able to handle this with proper overflow styling
return (
<div className="card-row">
<div
className={classnames('card-row__header', {
'card-row__header--sub-component': isSubComponent,
})}
>
<div className="card-row__title">
<section className="media-group--row">
<header className="media-group__header">
<div className="media-group__header-title">
{categoryLink ? (
<div className="card__actions card__actions--no-margin">
<Button label={category} navigate="/show" navigateParams={{ uri: categoryLink }} />
<SubscribeButton uri={`lbry://${categoryLink}`} showSnackBarOnSubscribe />
<div className="channel-info__actions">
<div className="channel-info__actions__group">
<Button
label={category}
navigate="/show"
navigateParams={{ uri: categoryLink }}
/>
<SubscribeButton
button="alt"
showSnackBarOnSubscribe
uri={`lbry://${categoryLink}`}
/>
</div>
</div>
) : (
category
@ -250,38 +244,30 @@ class CategoryList extends PureComponent<Props, State> {
)}
</div>
{showScrollButtons && (
<div
className={classnames('card-row__scroll-btns', {
'card-row__scroll-btns--sub-component': isSubComponent,
})}
>
<nav className="media-group__header-navigation">
<Button
className="btn--arrow"
disabled={!canScrollPrevious}
onClick={this.handleScrollPrevious}
icon={ICONS.ARROW_LEFT}
/>
<Button
className="btn--arrow"
disabled={!canScrollNext}
onClick={this.handleScrollNext}
icon={ICONS.ARROW_RIGHT}
neb-b commented 2018-12-12 20:10:58 +01:00 (Migrated from github.com)
Review
Copy link

The spacing between the border-bottom and the content is not consistent
screen shot 2018-12-12 at 2 09 18 pm

The spacing between the `border-bottom` and the content is not consistent <img width="400" alt="screen shot 2018-12-12 at 2 09 18 pm" src="https://user-images.githubusercontent.com/16882830/49892753-b8077700-fe17-11e8-8e4e-8897b27dec5d.png">
NetOpWibby commented 2018-12-13 19:15:56 +01:00 (Migrated from github.com)
Review
Copy link

This is probably due to the additional icon div that appears when you have something downloaded. If you scroll, do you see icons?

This is probably due to the additional icon div that appears when you have something downloaded. If you scroll, do you see icons?
neb-b commented 2018-12-13 21:02:02 +01:00 (Migrated from github.com)
Review
Copy link

Yeah it is. Should this always keep a space for that div? If you start downloading something, then go to the home page before it starts, it jumps when the icon is added.

Yeah it is. Should this always keep a space for that div? If you start downloading something, then go to the home page before it starts, it jumps when the icon is added.
NetOpWibby commented 2018-12-13 21:16:11 +01:00 (Migrated from github.com)
Review
Copy link

I'll add a height to it so the jumping doesn't happen.

I'll add a height to it so the jumping doesn't happen.
/>
</div>
</nav>
)}
</div>
</header>
{obscureNsfw && isCommunityTopBids ? (
<div className="card-row__message help">
<p className="media__message media__message--help">
{__(
'The community top bids section is only visible if you allow mature content in the app. You can change your content viewing preferences'
)}{' '}
<Button button="link" navigate="/settings" label={__('here')} />.
</div>
</p>
) : (
<div
className={classnames('card-row__scrollhouse', {
'card-row__scrollhouse--sub-component': isSubComponent,
})}
<ul
className="media-scrollhouse"
ref={ref => {
this.rowItems = ref;
}}
@ -314,9 +300,9 @@ class CategoryList extends PureComponent<Props, State> {
new Array(10).fill(1).map((x, i) => <FileCard placeholder key={i} />)
/* eslint-enable react/no-array-index-key */
}
</div>
</ul>
)}
</div>
</section>
);
}
}

32
src/renderer/component/channelTile/view.jsx
View file

@ -9,11 +9,13 @@ import type { Claim } from 'types/claim';
type Props = {
uri: string,
isResolvingUri: boolean,
isSearchResult: boolean,
totalItems: number,
size: string,
claim: ?Claim,
resolveUri: string => void,
navigate: (string, ?{}) => void,
buttonStyle: string,
};
class ChannelTile extends React.PureComponent<Props> {
@ -36,7 +38,16 @@ class ChannelTile extends React.PureComponent<Props> {
}
render() {
const { claim, navigate, isResolvingUri, totalItems, uri, size } = this.props;
const {
claim,
navigate,
isResolvingUri,
isSearchResult,
totalItems,
uri,
size,
buttonStyle,
} = this.props;
let channelName;
let subscriptionUri;
@ -51,20 +62,21 @@ class ChannelTile extends React.PureComponent<Props> {
<section
onClick={onClick}
role="button"
className={classnames('file-tile card--link', {
'file-tile--small': size === 'small',
'file-tile--large': size === 'large',
className={classnames('media-tile card--link', {
'media--search-result': isSearchResult,
'media--small': size === 'small',
'media--large': size === 'large',
})}
>
<CardMedia title={channelName} thumbnail={null} />
<div className="file-tile__info">
{isResolvingUri && <div className="file-tile__title">{__('Loading...')}</div>}
<div className="media__info">
{isResolvingUri && <div className="media__title">{__('Loading...')}</div>}
{!isResolvingUri && (
<React.Fragment>
<div className="file-tile__title">
<div className="media__title">
neb-b commented 2018-12-12 21:24:30 +01:00 (Migrated from github.com)
Review
Copy link

This is misaligned on the search page
screen shot 2018-12-12 at 3 22 17 pm

This is misaligned on the search page <img width="400" alt="screen shot 2018-12-12 at 3 22 17 pm" src="https://user-images.githubusercontent.com/16882830/49896640-f5710200-fe21-11e8-9aea-a59785d269c0.png">
<TruncatedText text={channelName || uri} lines={1} />
</div>
<div className="card__subtitle">
<div className="media__subtitle">
{totalItems > 0 && (
<span>
{totalItems} {totalItems === 1 ? 'file' : 'files'}
@ -75,8 +87,8 @@ class ChannelTile extends React.PureComponent<Props> {
</React.Fragment>
)}
{subscriptionUri && (
<div className="card__actions">
<SubscribeButton uri={subscriptionUri} />
<div className="media__actions">
<SubscribeButton buttonStyle="inverse" uri={subscriptionUri} />
</div>
)}
</div>

17
src/renderer/component/common/credit-amount.jsx
View file

@ -13,7 +13,6 @@ type Props = {
large?: boolean,
showLBC?: boolean,
fee?: boolean,
inheritStyle?: boolean,
badge?: boolean,
};
@ -37,7 +36,6 @@ class CreditAmount extends React.PureComponent<Props> {
isEstimate,
fee,
showLBC,
inheritStyle,
badge,
} = this.props;
@ -66,7 +64,11 @@ class CreditAmount extends React.PureComponent<Props> {
}
if (showLBC) {
amountText = `${amountText} ${__('LBC')}`;
amountText = (
<span>
{amountText} {__('LBC')}
</span>
);
}
if (fee) {
@ -77,14 +79,11 @@ class CreditAmount extends React.PureComponent<Props> {
return (
<span
title={fullPrice}
className={classnames('credit-amount', {
'credit-amount--large': large,
// TODO: remove inheritStyle prop
// It just complicates things
'credit-amount--inherit': inheritStyle,
className={classnames('badge', {
badge,
'badge--cost': badge && !isFree,
'badge--cost': (badge && !isFree) || amount > 0,
'badge--free': badge && isFree,
'badge--large': large,
})}
>
{amountText}

2
src/renderer/component/common/form-components/form-field.jsx
View file

@ -68,9 +68,11 @@ export class FormField extends React.PureComponent<Props> {
if (type) {
if (type === 'select') {
input = (
<div className="form-field__select-wrapper">
<select className="form-field__select" id={name} {...inputProps}>
{children}
</select>
</div>
);
} else if (type === 'markdown') {
const handleEvents = {

96
src/renderer/component/common/icon-custom.jsx Normal file
View file

@ -0,0 +1,96 @@
// @flow
import * as ICONS from 'constants/icons';
import React from 'react';
// Returns a react component
const buildIcon = iconStrokes => ({ size = 24, color = 'currentColor', ...otherProps }) => (
<svg
xmlns="http://www.w3.org/2000/svg"
viewBox="0 0 24 24"
width={size}
height={size}
fill="none"
stroke={color}
strokeWidth="2"
strokeLinecap="round"
strokeLinejoin="round"
{...otherProps}
>
{iconStrokes}
</svg>
);
export const customIcons = {
[ICONS.ARROW_LEFT]: buildIcon(
<g fill="none" fillRule="evenodd" strokeLinecap="round">
<path d="M4, 12 L21, 12" />
<polyline
strokeLinejoin="round"
transform="translate(7.000000, 12.000000) scale(-1, 1) translate(-7.000000, -12.000000)"
points="3 4 11 12 3 20"
/>
</g>
),
[ICONS.ARROW_RIGHT]: buildIcon(
<g fill="none" fillRule="evenodd" strokeLinecap="round">
<path d="M3, 12 L20, 12" />
<polyline strokeLinejoin="round" points="13 4 21 12 13 20" />
</g>
),
[ICONS.EYE]: buildIcon(
<g fill="none" fillRule="evenodd">
<path
d="M2, 12 C2, 12 5, 5 12, 5 C19, 5 22, 12 22, 12 C22, 12 19, 19 12, 19 C5, 19 2, 12 2, 12 Z"
strokeLinejoin="round"
/>
<circle cx="12" cy="12" r="3" />
<path d="M12, 5 L12, 3" strokeLinecap="round" />
<path d="M18, 6.5 L19, 5" strokeLinecap="round" />
<path d="M21, 10 L22.5, 9" strokeLinecap="round" />
<path
d="M1.5, 10 L3, 9"
strokeLinecap="round"
transform="translate(2.250000, 9.500000) scale(1, -1) translate(-2.250000, -9.500000)"
/>
<path
d="M5, 6.5 L6, 5"
strokeLinecap="round"
transform="translate(5.500000, 5.750000) scale(-1, 1) translate(-5.500000, -5.750000)"
/>
</g>
),
[ICONS.HOME]: buildIcon(
<g strokeWidth="2" fill="none" fillRule="evenodd" strokeLinecap="round" strokeLinejoin="round">
<path d="M1, 11 L12, 2 C12, 2 22.9999989, 11.0000005 23, 11" />
<path d="M3, 10 C3, 10 3, 10.4453982 3, 10.9968336 L3, 20.0170446 C3, 20.5675806 3.43788135, 21.0138782 4.00292933, 21.0138781 L8.99707067, 21.0138779 C9.55097324, 21.0138779 10, 20.5751284 10, 20.0089602 L10, 15.0049177 C10, 14.449917 10.4433532, 14 11.0093689, 14 L12.9906311, 14 C13.5480902, 14 14, 14.4387495 14, 15.0049177 L14, 20.0089602 C14, 20.5639609 14.4378817, 21.0138779 15.0029302, 21.0138779 L19.9970758, 21.0138781 C20.5509789, 21.0138782 21.000006, 20.56848 21.000006, 20.0170446 L21.0000057, 10" />
</g>
),
[ICONS.MENU]: buildIcon(
<path
d="M3.5, 7 C3.5, 7.27910535 3.72002141, 7.5 3.99339768, 7.5 L20.0066023, 7.5 C20.2782464, 7.5 20.5, 7.27680164 20.5, 7 C20.5, 6.72089465 20.2799786, 6.5 20.0066023, 6.5 L3.99339768, 6.5 C3.72175357, 6.5 3.5, 6.72319836 3.5, 7 Z M3.5, 12 C3.5, 12.2791054 3.72002141, 12.5 3.99339768, 12.5 L20.0066023, 12.5 C20.2782464, 12.5 20.5, 12.2768016 20.5, 12 C20.5, 11.7208946 20.2799786, 11.5 20.0066023, 11.5 L3.99339768, 11.5 C3.72175357, 11.5 3.5, 11.7231984 3.5, 12 Z M3.5, 17 C3.5, 17.2791054 3.72002141, 17.5 3.99339768, 17.5 L20.0066023, 17.5 C20.2782464, 17.5 20.5, 17.2768016 20.5, 17 C20.5, 16.7208946 20.2799786, 16.5 20.0066023, 16.5 L3.99339768, 16.5 C3.72175357, 16.5 3.5, 16.7231984 3.5, 17 Z"
fill="none"
fillRule="evenodd"
strokeWidth="1"
/>
),
[ICONS.PLAY]: buildIcon(
<g fill="white" fillRule="evenodd" strokeLinejoin="round">
<polygon points="5 21 5 3 21 12" />
</g>
),
[ICONS.UPLOAD]: buildIcon(
<g fill="none" fillRule="evenodd" strokeLinecap="round">
<path
d="M8, 18 L5, 18 L5, 18 C2.790861, 18 1, 16.209139 1, 14 C1, 11.790861 2.790861, 10 5, 10 C5.35840468, 10 5.70579988, 10.0471371 6.03632437, 10.1355501 C6.01233106, 9.92702603 6, 9.71495305 6, 9.5 C6, 6.46243388 8.46243388, 4 11.5, 4 C14.0673313, 4 16.2238156, 5.7590449 16.8299648, 8.1376465 C17.2052921, 8.04765874 17.5970804, 8 18, 8 C20.7614237, 8 23, 10.2385763 23, 13 C23, 15.7614237 20.7614237, 18 18, 18 L16, 18"
strokeLinejoin="round"
/>
<path d="M12, 13 L12, 21" />
<polyline
strokeLinejoin="round"
transform="translate(12.000000, 12.500000) scale(1, -1) translate(-12.000000, -12.500000)"
points="15 11 12 14 9 11"
/>
</g>
),
};

9
src/renderer/component/common/icon.jsx
View file

@ -3,6 +3,7 @@ import * as ICONS from 'constants/icons';
import React from 'react';
import * as FeatherIcons from 'react-feather';
import Tooltip from 'component/common/tooltip';
import { customIcons } from './icon-custom';
// It would be nice to standardize this somehow
// These are copied from `scss/vars`, can they both come from the same source?
@ -44,7 +45,7 @@ class IconComponent extends React.PureComponent<Props> {
render() {
const { icon, tooltip, iconColor, size } = this.props;
const Icon = FeatherIcons[icon];
const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];
if (!Icon) {
return null;
@ -55,11 +56,7 @@ class IconComponent extends React.PureComponent<Props> {
color = this.getIconColor(iconColor);
}
let iconSize = size || 14;
// Arrow ICONS are quite a bit smaller than the other ICONS we use
if (icon === ICONS.ARROW_LEFT || icon === ICONS.ARROW_RIGHT) {
iconSize = 20;
}
const iconSize = size || 14;
let tooltipText;
if (tooltip) {

2
src/renderer/component/common/lbc-symbol.jsx
View file

@ -1,6 +1,6 @@
neb-b commented 2018-12-12 19:56:38 +01:00 (Migrated from github.com)
Review
Copy link

We should use this component with the wallet balance in the header.

We should use this component with the wallet balance in the header.
neb-b commented 2018-12-12 19:56:38 +01:00 (Migrated from github.com)
Review
Copy link

We should use this component with the wallet balance in the header.

We should use this component with the wallet balance in the header.
// @flow
import React from 'react';
const LbcSymbol = () => <span>LBC</span>;
neb-b commented 2018-12-12 19:56:38 +01:00 (Migrated from github.com)
Review
Copy link

We should use this component with the wallet balance in the header.

We should use this component with the wallet balance in the header.
const LbcSymbol = () => <span> LBC</span>; // ℄
neb-b commented 2018-12-12 19:56:38 +01:00 (Migrated from github.com)
Review
Copy link

We should use this component with the wallet balance in the header.

We should use this component with the wallet balance in the header.
export default LbcSymbol;

neb-b commented 2018-12-12 19:56:38 +01:00 (Migrated from github.com)
Review
Copy link

We should use this component with the wallet balance in the header.

We should use this component with the wallet balance in the header.
neb-b commented 2018-12-12 19:56:38 +01:00 (Migrated from github.com)
Review
Copy link

We should use this component with the wallet balance in the header.

We should use this component with the wallet balance in the header.

1
src/renderer/component/expandable/view.jsx
View file

@ -48,6 +48,7 @@ export default class Expandable extends PureComponent<Props, State> {
</div>
<Button
button="link"
className="expandable__button"
label={expanded ? __('Less') : __('More')}
onClick={this.handleClick}
/>

50
src/renderer/component/fileCard/view.jsx
View file

@ -1,6 +1,6 @@
// @flow
import type { Claim, Metadata } from 'types/claim';
import * as ICONS from 'constants/icons';
import * as icons from 'constants/icons';
import * as React from 'react';
import { normalizeURI, convertToShareLink } from 'lbry-redux';
import CardMedia from 'component/cardMedia';
@ -27,14 +27,12 @@ type Props = {
isResolvingUri: boolean,
/* eslint-enable react/no-unused-prop-types */
isSubscribed: boolean,
showSubscribedLogo: boolean,
isNew: boolean,
placeholder: boolean,
};
class FileCard extends React.PureComponent<Props> {
static defaultProps = {
showSubscribedLogo: false,
placeholder: false,
};
@ -66,7 +64,6 @@ class FileCard extends React.PureComponent<Props> {
pending,
isSubscribed,
isNew,
showSubscribedLogo,
isResolvingUri,
placeholder,
} = this.props;
@ -79,12 +76,12 @@ class FileCard extends React.PureComponent<Props> {
if ((!claim && !pending) || placeholder) {
return (
<div className="card card--small">
<div className="card--placeholder card__media" />
<div className="card--placeholder placeholder__title" />
<div className="card--placeholder placeholder__channel" />
<div className="card--placeholder placeholder__date" />
</div>
<li className="media-card media--placeholder small">
<div className="media__thumb media__thumb--placeholder" />
<div className="media__title media__title--placeholder" />
<div className="media__channel media__channel--placeholder" />
<div className="media__date media__date--placeholder" />
</li>
);
}
@ -107,39 +104,34 @@ class FileCard extends React.PureComponent<Props> {
// We should be able to tab through cards
/* eslint-disable jsx-a11y/click-events-have-key-events */
return (
<section
<li
tabIndex="0"
role="button"
onClick={!pending ? () => navigate('/show', { uri }) : () => {}}
className={classnames('card card--small', {
'card--link': !pending,
'card--pending': pending,
className={classnames('media-card', {
'media--link': !pending,
'media--pending': pending,
})}
onContextMenu={handleContextMenu}
>
<CardMedia thumbnail={thumbnail} />
<div className="card__title card__title--file-card">
<div className="media__title">
<TruncatedText text={title} lines={2} />
</div>
<div className="card__subtitle">
<div className="media__subtitle">
{pending ? <div>Pending...</div> : <UriIndicator uri={uri} link />}
</div>
<div className="card__subtitle card--space-between">
<div className="media__date">
<DateTime timeAgo block={height} />
<div className="card__file-properties">
</div>
<div className="media__properties">
<FilePrice hideFree uri={uri} />
{isRewardContent && <Icon iconColor="red" icon={ICONS.FEATURED} />}
{showSubscribedLogo && isSubscribed && <Icon icon={ICONS.HEART} />}
{fileInfo && <Icon icon={ICONS.LOCAL} />}
{isRewardContent && <Icon iconColor="red" icon={icons.FEATURED} />}
{isSubscribed && <Icon icon={icons.HEART} />}
{fileInfo && <Icon icon={icons.LOCAL} />}
{isNew && <span className="badge badge--alert">{__('NEW')}</span>}
</div>
</div>
{isNew && (
<div className="card__subtitle">
<span className="badge badge--alert">{__('NEW')}</span>
</div>
)}
</section>
</li>
);
/* eslint-enable jsx-a11y/click-events-have-key-events */
}

21
src/renderer/component/fileDetails/view.jsx
View file

@ -69,14 +69,14 @@ class FileDetails extends PureComponent<Props> {
<Expandable>
{description && (
<Fragment>
<div className="card__subtext-title">About</div>
<div className="card__subtext">
<div className="media__info-title">About</div>
<div className="media__info-text">
<MarkdownPreview content={description} promptLinks />
</div>
</Fragment>
)}
<div className="card__subtext-title">Info</div>
<div className="card__subtext">
<div className="media__info-title">Info</div>
<div className="media__info-text">
<div>
{__('Content-Type')}
{': '}
@ -105,9 +105,10 @@ class FileDetails extends PureComponent<Props> {
)}
</div>
</Expandable>
<div className="card__content">
<div className="card__subtext-title">Comments</div>
<div className="card__actions card__actions--center">
<div className="media__info-title">Comments</div>
<div className="card__actions">
<Button
data-id="add-comment"
disabled={hasClickedComment}
@ -116,16 +117,14 @@ class FileDetails extends PureComponent<Props> {
onClick={this.handleCommentClick}
/>
</div>
<br />
{hasClickedComment && (
<p className="main--for-content">
{user
? __(
'Your support has been added. You will be notified when comments are available.'
)
? __('Your support has been added. You will be notified when comments are available.')
: __('Your support has been added. Comments are coming soon.')}
</p>
)}
</div>
</Fragment>
);
}

5
src/renderer/component/fileList/view.jsx
View file

@ -174,7 +174,10 @@ class FileList extends React.PureComponent<Props> {
</FormField>
</div>
)}
<div className="card__list card__content">{content}</div>
<section className="media-group--list">
<div className="card__list">{content}</div>
</section>
</section>
);
}

26
src/renderer/component/fileListSearch/view.jsx
View file

@ -35,33 +35,35 @@ class FileListSearch extends React.PureComponent<Props> {
query && (
<React.Fragment>
<div className="search__results">
<div className="search-result__row">
<div className="file-list__header">{__('Search Results')}</div>
<section className="search__results-section">
<div className="search__results-title">{__('Search Results')}</div>
<HiddenNsfwClaims uris={uris} />
{!isSearching && fileResults.length ? (
fileResults.map(uri => <FileTile key={uri} uri={uri} />)
fileResults.map(uri => <FileTile isSearchResult key={uri} uri={uri} />)
) : (
<NoResults />
)}
</div>
</section>
<div className="search-result__row">
<div className="file-list__header">{__('Channels')}</div>
<section className="search__results-section">
<div className="search__results-title">{__('Channels')}</div>
{!isSearching && channelResults.length ? (
channelResults.map(uri => <ChannelTile key={uri} uri={uri} />)
channelResults.map(uri => <ChannelTile isSearchResult key={uri} uri={uri} />)
) : (
<NoResults />
)}
</div>
</section>
<div className="search-result__row">
<div className="file-list__header">{__('Your downloads')}</div>
<section className="search__results-section">
<div className="search__results-title">{__('Your downloads')}</div>
{downloadUris && downloadUris.length ? (
downloadUris.map(uri => <FileTile hideNoResult key={uri} uri={uri} />)
downloadUris.map(uri => (
<FileTile hideNoResult isSearchResult key={uri} uri={uri} />
))
) : (
<NoResults />
)}
</div>
</section>
</div>
</React.Fragment>
)

36
src/renderer/component/fileTile/view.jsx
View file

@ -16,6 +16,7 @@ type Props = {
obscureNsfw: boolean,
claimIsMine: boolean,
isDownloaded: boolean,
isSearchResult: boolean,
uri: string,
isResolvingUri: boolean,
rewardedContentClaimIds: Array<string>,
@ -62,7 +63,7 @@ class FileTile extends React.PureComponent<Props> {
const isRewardContent = claim && rewardedContentClaimIds.includes(claim.claim_id);
return (
<div className={classnames('card__file-properties', { card__subtitle: size === 'large' })}>
<div className={classnames('media__properties', { card__subtitle: size === 'large' })}>
<FilePrice hideFree uri={uri} />
{isNew && <span className="badge badge--alert icon">{__('NEW')}</span>}
{isSubscribed && <Icon icon={ICONS.HEART} />}
@ -77,6 +78,7 @@ class FileTile extends React.PureComponent<Props> {
claim,
metadata,
isResolvingUri,
isSearchResult,
navigate,
obscureNsfw,
claimIsMine,
@ -91,16 +93,15 @@ class FileTile extends React.PureComponent<Props> {
if (!claim && isResolvingUri) {
return (
<div
className={classnames('file-tile', {
'file-tile--small': size === 'small',
'file-tile--large': size === 'large',
className={classnames('media-tile', {
large: size === 'large',
})}
>
<div className="card--placeholder card__media" />
<div className="card__placeholder card__media" />
<div className="file-tile__info">
<div className="card--placeholder placeholder__title--tile" />
<div className="card--placeholder placeholder__channel" />
<div className="card--placeholder placeholder__date" />
<div className="card__placeholder title" />
<div className="card__placeholder channel" />
<div className="card__placeholder date" />
</div>
</div>
);
@ -133,9 +134,10 @@ class FileTile extends React.PureComponent<Props> {
return !name && hideNoResult ? null : (
<section
className={classnames('file-tile card--link', {
'file-tile--small': size === 'small',
'file-tile--large': size === 'large',
className={classnames('media-tile card--link', {
'media--search-result': isSearchResult,
'media--small': size === 'small',
'media--large': size === 'large',
})}
onClick={onClick}
onKeyUp={onClick}
@ -143,21 +145,23 @@ class FileTile extends React.PureComponent<Props> {
tabIndex="0"
>
<CardMedia title={title || name} thumbnail={thumbnail} />
<div className="file-tile__info">
<div className="file-tile__title">
<div className="media__info">
<div className="media__title">
{(title || name) && (
<TruncatedText text={title || name} lines={size === 'small' ? 2 : 3} />
)}
</div>
<div className="card__subtitle">
<div className="media__subtitle">
<UriIndicator uri={uri} link />
</div>
<div className="card__subtitle card--space-between">
<div className="media__subtitle card--space-between">
<div className="media__date">
<DateTime timeAgo block={height} />
</div>
{size !== 'large' && this.renderFileProperties()}
</div>
{displayDescription && (
<div className="card__subtext">
<div className="media__subtext">
<TruncatedText text={description} lines={size === 'large' ? 4 : 3} />
</div>
)}

20
src/renderer/component/fileViewer/internal/play-button.jsx
View file

@ -1,7 +1,8 @@
// @flow
import * as ICONS from 'constants/icons';
import classnames from 'classnames';
import React from 'react';
import Button from 'component/button';
import * as ICONS from 'constants/icons';
type Props = {
play: () => void,
@ -15,10 +16,21 @@ class VideoPlayButton extends React.PureComponent<Props> {
const { fileInfo, mediaType, isLoading, play } = this.props;
const disabled = isLoading || fileInfo === undefined;
const doesPlayback = ['audio', 'video'].indexOf(mediaType) !== -1;
const icon = doesPlayback ? ICONS.PLAY : ICONS.EYE;
const label = doesPlayback ? __('Play') : __('View');
return <Button button="primary" disabled={disabled} label={label} icon={icon} onClick={play} />;
const icon = doesPlayback ? ICONS.PLAY : ICONS.EYE;
return (
<Button
disabled={disabled}
label={label}
icon={icon}
iconSize={30}
className={classnames('btn--icon', {
'btn--play': doesPlayback,
'btn--view': !doesPlayback,
})}
onClick={play}
/>
);
}
}

97
src/renderer/component/header/view.jsx
View file

@ -2,6 +2,7 @@
import * as ICONS from 'constants/icons';
import * as React from 'react';
import Button from 'component/button';
import LbcSymbol from 'component/common/lbc-symbol';
import WunderBar from 'component/wunderbar';
type Props = {
@ -38,68 +39,78 @@ const Header = (props: Props) => {
<header className="header">
<div className="header__navigation">
<Button
noPadding
button="alt"
icon={ICONS.HOME}
className="btn--home-nav"
description={__('Home')}
onClick={() => navigate('/discover')}
/>
<div className="header__history">
<Button
className="btn--arrow"
icon={ICONS.ARROW_LEFT}
description={__('Navigate back')}
onClick={back}
disabled={isBackDisabled}
/>
<Button
className="btn--arrow"
icon={ICONS.ARROW_RIGHT}
description={__('Navigate forward')}
onClick={forward}
disabled={isForwardDisabled}
/>
</div>
</div>
<WunderBar />
<div className="header__actions-right">
<Button
button="inverse"
className="btn--header-balance"
onClick={() => navigate('/wallet')}
className="header__navigation-item header__navigation-item--wallet"
description={__('Your wallet')}
iconRight="LBC"
label={
isUpgradeAvailable ? (
`${balance}`
) : (
<React.Fragment>
<span className="btn__label--balance" title={`${balance} LBC`}>
You have
</span>{' '}
<span title={`${balance} LBC`}>{roundedBalance} LBC</span>
<span title={`${balance} LBC`}>{roundedBalance}</span>
<LbcSymbol />
</React.Fragment>
)
}
iconRight="LBC"
description={__('Your wallet')}
onClick={() => navigate('/wallet')}
/>
<Button
uppercase
button="primary"
className="btn--header-publish"
onClick={() => navigate('/publish')}
icon={ICONS.UPLOAD}
label={isUpgradeAvailable ? '' : __('Publish')}
className="header__navigation-item header__navigation-item--back"
description={__('Navigate back')}
disabled={isBackDisabled}
icon={ICONS.ARROW_LEFT}
iconSize={15}
onClick={back}
/>
<Button
className="header__navigation-item header__navigation-item--forward"
description={__('Navigate forward')}
disabled={isForwardDisabled}
icon={ICONS.ARROW_RIGHT}
iconSize={15}
onClick={forward}
/>
<Button
className="header__navigation-item header__navigation-item--home"
description={__('Home')}
icon={ICONS.HOME}
iconSize={15}
onClick={() => navigate('/discover')}
/>
</div>
<WunderBar />
{
// TODO: Make `Menu` add `.active` class to `.navigation` when clicked
}
<div className="header__navigation">
<Button
className="header__navigation-item header__navigation-item--menu"
description={__('Menu')}
icon={ICONS.MENU}
iconSize={15}
/>
<Button
className="header__navigation-item header__navigation-item--publish"
description={__('Publish content')}
icon={ICONS.UPLOAD}
iconSize={20}
label={isUpgradeAvailable ? '' : __('Publish')}
onClick={() => navigate('/publish')}
/>
{showUpgradeButton && (
<Button
button="primary"
onClick={downloadUpgradeRequested}
icon={ICONS.DOWNLOAD}
label={__('Upgrade App')}
onClick={downloadUpgradeRequested}
/>
)}
</div>

8
src/renderer/component/inviteList/view.jsx
View file

@ -24,9 +24,10 @@ class InviteList extends React.PureComponent<Props> {
return (
<section className="card card--section">
<div className="card__title">
<h3>{__('Invite History')}</h3>
</div>
<header className="card__header">
<h2 className="card__title">{__('Invite History')}</h2>
</header>
<div className="card__content">
{invitees.length === 0 && (
<span className="empty">{__("You haven't invited anyone.")} </span>
@ -66,6 +67,7 @@ class InviteList extends React.PureComponent<Props> {
</table>
)}
</div>
<div className="card__content">
<div className="help">
{__(

18
src/renderer/component/inviteNew/view.jsx
View file

@ -47,9 +47,12 @@ class FormInviteNew extends React.PureComponent {
}}
/>
</FormRow>
<div className="card__content">
<div className="card__actions">
<Submit label="Invite" disabled={isPending} />
</div>
</div>
</Form>
);
}
@ -68,11 +71,14 @@ class InviteNew extends React.PureComponent {
return (
<section className="card card--section">
<div className="card__title">{__('Invite a Friend')}</div>
<header className="card__header">
<h2 className="card__title">{__('Invite a Friend')}</h2>
<div className="card__subtitle">
<p className="card__subtitle">
{__("Or an enemy. Or your cousin Jerry, who you're kind of unsure about.")}
</div>
</p>
</header>
{/*
<div className="card__content">
{invitesRemaining > 0 &&
@ -80,6 +86,7 @@ class InviteNew extends React.PureComponent {
{invitesRemaining <= 0 &&
<p className="empty">{__("You have no invites.")}</p>}
</div> */}
<div className="card__content">
<FormInviteNew
errorMessage={errorMessage}
@ -88,11 +95,14 @@ class InviteNew extends React.PureComponent {
rewardAmount={rewardAmount}
/>
</div>
<p className="help help--padded">
<div className="card__content">
<p className="help">
{__('Read our')}{' '}
<Button button="link" label={__('FAQ')} href="https://lbry.io/faq/referrals" />{' '}
{__('to learn more about referrals')}.
</p>
</div>
</section>
);
}

86
src/renderer/component/publishForm/view.jsx
View file

@ -292,9 +292,9 @@ class PublishForm extends React.PureComponent<Props> {
{uploadThumbnailStatus === THUMBNAIL_STATUSES.IN_PROGRESS && (
<div>{__('Please wait for thumbnail to finish uploading')}</div>
)}
{!!editingURI &&
!isStillEditing &&
!filePath && <div>{__('You need to reselect a file after changing the LBRY URL')}</div>}
{!!editingURI && !isStillEditing && !filePath && (
<div>{__('You need to reselect a file after changing the LBRY URL')}</div>
)}
</div>
)
);
@ -348,10 +348,18 @@ class PublishForm extends React.PureComponent<Props> {
return (
<Form onSubmit={this.handlePublish}>
<section className={classnames('card card--section', { 'card--disabled': publishing })}>
<div className="card__title card--space-between">
{__('Content')}
<header className="card__header">
<h2 className="card__title">{__('Content')}</h2>
<p className="card__subtitle">
{isStillEditing ? __('Editing a claim') : __('What are you publishing?')}{' '}
{__('Read our')}{' '}
<Button button="link" label={__('FAQ')} href="https://lbry.io/faq/how-to-publish" />{' '}
{__('to learn more.')}
</p>
</header>
{(filePath || !!editingURI) && (
<div className="card__actions-top-corner">
<div className="card__internal-links">
<Button
button="inverse"
icon={ICONS.CLOSE}
@ -360,18 +368,10 @@ class PublishForm extends React.PureComponent<Props> {
/>
</div>
)}
</div>
<div className="card__subtitle">
{isStillEditing ? __('Editing a claim') : __('What are you publishing?')}{' '}
{__('Read our')}{' '}
<Button button="link" label={__('FAQ')} href="https://lbry.io/faq/how-to-publish" />{' '}
{__('to learn more.')}
</div>
<div className="card__content">
<FileSelector currentPath={filePath} onFileChosen={this.handleFileChange} />
{!!isStillEditing &&
name && (
<p className="card__content card__subtitle">
{!!isStillEditing && name && (
<p className="help">
{__("If you don't choose a file, the file from your existing claim")}
{` "${name}" `}
{__('will be used.')}
@ -408,8 +408,9 @@ class PublishForm extends React.PureComponent<Props> {
</section>
<section className="card card--section">
<div className="card__title">{__('Thumbnail')}</div>
<div className="card__subtitle">
<header className="card__header">
<h2 className="card__title">{__('Thumbnail')}</h2>
<p className="card__subtitle">
{uploadThumbnailStatus === THUMBNAIL_STATUSES.API_DOWN ? (
__('Enter a URL for your thumbnail.')
) : (
@ -419,7 +420,9 @@ class PublishForm extends React.PureComponent<Props> {
{__('Recommended size: 800x450 (16:9)')}
</React.Fragment>
)}
</div>
</p>
</header>
<SelectThumbnail
thumbnailPath={thumbnailPath}
thumbnail={thumbnail}
@ -431,8 +434,11 @@ class PublishForm extends React.PureComponent<Props> {
</section>
<section className="card card--section">
<div className="card__title">{__('Price')}</div>
<div className="card__subtitle">{__('How much will this content cost?')}</div>
<header className="card__header">
<h2 className="card__title">{__('Price')}</h2>
<p className="card__subtitle">{__('How much will this content cost?')}</p>
</header>
<div className="card__content">
<FormField
type="radio"
@ -469,22 +475,30 @@ class PublishForm extends React.PureComponent<Props> {
</section>
<section className="card card--section">
<div className="card__title">{__('Anonymous or under a channel?')}</div>
<header className="card__header">
<h2 className="card__title">{__('Anonymous or under a channel?')}</h2>
<p className="card__subtitle">
{__('This is a username or handle that your content can be found under.')}{' '}
{__('Ex. @Marvel, @TheBeatles, @BooksByJoe')}
</p>
</header>
<div className="card__content">
<ChannelSection channel={channel} onChannelChange={this.handleChannelChange} />
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('Where can people find this content?')}</div>
<header className="card__header">
<h2 className="card__title">{__('Where can people find this content?')}</h2>
<p className="card__subtitle">
{__(
'The LBRY URL is the exact address where people find your content (ex. lbry://myvideo).'
)}{' '}
<Button button="link" label={__('Learn more')} href="https://lbry.io/faq/naming" />
</p>
</header>
<div className="card__content">
<FormRow>
<FormField
@ -512,6 +526,7 @@ class PublishForm extends React.PureComponent<Props> {
/>
</FormRow>
</div>
<div className={classnames('card__content', { 'card--disabled': !name })}>
<FormField
className="input--price-amount"
@ -538,6 +553,7 @@ class PublishForm extends React.PureComponent<Props> {
</section>
<section className="card card--section">
<div className="card__content">
<FormRow>
<FormField
type="checkbox"
@ -585,8 +601,23 @@ class PublishForm extends React.PureComponent<Props> {
updatePublishForm({ licenseUrl: event.target.value })
}
/>
</div>
</section>
<section className="card card--section">
<div className="card__content">
{__('By continuing, you accept the')}{' '}
<Button
button="link"
href="https://www.lbry.io/termsofservice"
label={__('LBRY Terms of Service')}
/>
.
</div>
</section>
<section className="card card--section">
<div className="card__content">
<div className="card__actions">
<Submit
label={submitLabel}
@ -598,14 +629,9 @@ class PublishForm extends React.PureComponent<Props> {
/>
<Button button="alt" onClick={this.handleCancelPublish} label={__('Cancel')} />
</div>
<div className="card__subtitle">
{__('By continuing, you accept the')}{' '}
<Button
button="link"
href="https://www.lbry.io/termsofservice"
label={__('LBRY terms of service')}
/>.
</div>
</section>
{!formDisabled && !formValid && this.renderFormErrors()}
</div>
</Form>

8
src/renderer/component/recommendedContent/view.jsx
View file

@ -50,7 +50,7 @@ export default class RecommendedContent extends React.PureComponent<Props> {
const { recommendedContent, isSearching } = this.props;
return (
<section className="card__list--recommended">
<section className="media-group--list-recommended">
<span>Related</span>
{recommendedContent &&
recommendedContent.map(recommendedUri => (
@ -62,9 +62,9 @@ export default class RecommendedContent extends React.PureComponent<Props> {
uri={recommendedUri}
/>
))}
{recommendedContent &&
!recommendedContent.length &&
!isSearching && <div className="card__subtitle">No related content found</div>}
{recommendedContent && !recommendedContent.length && !isSearching && (
<div className="media__subtitle">No related content found</div>
)}
</section>
);
}

4
src/renderer/component/rewardListClaimed/view.jsx
View file

@ -24,7 +24,9 @@ const RewardListClaimed = (props: Props) => {
return (
<section className="card card--section">
<div className="card__title">Claimed Rewards</div>
<header className="card__header">
<h2 className="card__title">Claimed Rewards</h2>
</header>
<table className="card__content table table--stretch">
<thead>

13
src/renderer/component/rewardSummary/view.jsx
View file

@ -23,10 +23,12 @@ class RewardSummary extends React.Component<Props> {
return (
<section className="card card--section">
<div className="card__title">
<header className="card__header">
<h2 className="card__title">
{__('Rewards')}
{fetching && <BusyIndicator />}
</div>
</h2>
<p className="card__subtitle">
{!fetching &&
(hasRewards ? (
@ -43,6 +45,9 @@ class RewardSummary extends React.Component<Props> {
</React.Fragment>
))}
</p>
</header>
<div className="card__content">
<div className="card__actions">
<Button
button="primary"
@ -50,11 +55,13 @@ class RewardSummary extends React.Component<Props> {
label={hasRewards ? __('Claim Rewards') : __('View Rewards')}
/>
</div>
<p className="help help--padded">
<p className="help">
{__('Read our')}{' '}
<Button button="link" label={__('FAQ')} href="https://lbry.io/faq/rewards" />{' '}
{__('to learn more about LBRY Rewards')}.
</p>
</div>
</section>
);
}

9
src/renderer/component/rewardTile/view.jsx
View file

@ -25,8 +25,12 @@ const RewardTile = (props: Props) => {
return (
<section className="card card--section">
<div className="card__title">{reward.reward_title}</div>
<div className="card__subtitle">{reward.reward_description}</div>
<header className="card__header">
<h2 className="card__title">{reward.reward_title}</h2>
<p className="card__subtitle">{reward.reward_description}</p>
</header>
<div className="card__content">
<div className="card__actions">
{reward.reward_type === rewards.TYPE_GENERATED_CODE && (
<Button button="primary" onClick={openRewardCodeModal} label={__('Enter Code')} />
@ -43,6 +47,7 @@ const RewardTile = (props: Props) => {
<RewardLink button reward_type={reward.reward_type} />
))}
</div>
</div>
</section>
);
};

7
src/renderer/component/shapeShift/internal/active-shift.jsx
View file

@ -80,9 +80,9 @@ class ActiveShapeShift extends React.PureComponent<Props> {
<div>
<p>
Send up to{' '}
<span className="credit-amount--bold">
<strong>
{originCoinDepositMax} {shiftCoinType}
</span>{' '}
</strong>{' '}
to the address below.
</p>
<ShiftMarketInfo
@ -134,8 +134,7 @@ class ActiveShapeShift extends React.PureComponent<Props> {
/>
)}
</div>
{shiftState === statuses.NO_DEPOSITS &&
shiftReturnAddress && (
{shiftState === statuses.NO_DEPOSITS && shiftReturnAddress && (
<div className="help">
{__("If the transaction doesn't go through, ShapeShift will return your")}{' '}
{shiftCoinType} {__('back to')} {shiftReturnAddress}

5
src/renderer/component/shapeShift/internal/form.jsx
View file

@ -83,13 +83,14 @@ export default (props: Props) => {
value={values.returnAddress}
/>
</FormRow>
<span className="help">
<span>
({__('optional but recommended')})<br />
{__('We will return your')} {originCoin}{' '}
{__("to this address if the transaction doesn't go through.")}
</span>
</span>
<br />
<div className="card__actions">
<Submit
button="primary"

10
src/renderer/component/shapeShift/view.jsx
View file

@ -73,13 +73,17 @@ class ShapeShift extends React.PureComponent<Props> {
return (
<section className="card card--section">
<div className="card__title">{__('Convert Crypto to LBC')}</div>
<header className="card__header">
<h2 className="card__title">{__('Convert Crypto to LBC')}</h2>
<p className="card__subtitle">
{__('Powered by ShapeShift. Read our FAQ')}{' '}
<Button button="link" label={__('here')} href="https://lbry.io/faq/shapeshift" />.
{hasActiveShift &&
shiftState !== 'complete' && <span>{__('This will update automatically.')}</span>}
{hasActiveShift && shiftState !== 'complete' && (
<span>{__('This will update automatically.')}</span>
)}
</p>
</header>
<div className="card__content">
{error && <div className="form-field__error">{error}</div>}

51
src/renderer/component/sideBar/view.jsx
View file

@ -23,38 +23,34 @@ const SideBar = (props: Props) => {
const { navLinks, unreadSubscriptionTotal } = props;
return (
<nav className="nav">
<div className="nav__links">
<ul className="nav__primary">
{navLinks.primary.map(({ label, path, active, icon }) => (
<li
key={path}
className={classnames('nav__link', {
'nav__link--active': active,
})}
>
<nav className="navigation">
<div className="navigation__links">
{navLinks.primary.map(({ label, path, active }) => (
<Button
navigate={path}
className={classnames('navigation__link', {
'navigation__link--active': active,
})}
key={path}
label={
path === '/subscriptions' && unreadSubscriptionTotal
? `${label} (${unreadSubscriptionTotal})`
: label
}
icon={icon}
navigate={path}
/>
</li>
))}
</ul>
<hr />
<ul>
{navLinks.secondary.map(({ label, path, active, icon, subLinks = [] }) => (
<li className="navigation__link navigation__link--title">Account</li>
{navLinks.secondary.map(({ label, path, active, subLinks = [] }) => (
<li
key={label}
className={classnames('nav__link', {
'nav__link--active': active,
className={classnames('navigation__link', {
'navigation__link--active': active,
})}
neb-b commented 2018-12-12 20:28:25 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this stay as a ul?

Shouldn't this stay as a `ul`?
NetOpWibby commented 2018-12-13 19:44:18 +01:00 (Migrated from github.com)
Review
Copy link

No, there's already a ul surrounding the account links. I don't think Explore and Subscriptions need to be lis.

No, there's already a `ul` surrounding the account links. I don't think Explore and Subscriptions need to be `li`s.
neb-b commented 2018-12-13 21:10:05 +01:00 (Migrated from github.com)
Review
Copy link

It is a list of items though, even if it's only two. I don't think we lose anything from adding it, but we gain accessibility improvements, which we will need to focus on more for web/tv uis to better handle keyboard/remote navigation.

It is a list of items though, even if it's only two. I don't think we lose anything from adding it, but we gain accessibility improvements, which we will need to focus on more for web/tv uis to better handle keyboard/remote navigation.
key={label}
>
<Button navigate={path} label={label} icon={icon} />
<Button label={label} navigate={path} />
{
// The sublinks should be animated on open close
@ -62,18 +58,17 @@ const SideBar = (props: Props) => {
// was really slow and looked pretty bad. Possible fix is upgrading to v2
// Not sure if that has better performance
}
{!!subLinks.length &&
active && (
<ul key="0" className="nav__sub-links">
{subLinks.map(({ label: subLabel, path: subPath, active: subLinkActive }) => (
{!!subLinks.length && active && (
<ul key="0" className="navigation__link-items">
{subLinks.map(({ active: subLinkActive, label: subLabel, path: subPath }) => (
<li
key={subPath}
className={classnames('nav__link nav__link--sub', {
'nav__link--active': subLinkActive,
className={classnames('navigation__link-item', {
'navigation__link-item--active': subLinkActive,
})}
key={subPath}
>
{subPath ? (
<Button navigate={subPath} label={subLabel} />
<Button label={subLabel} navigate={subPath} />
) : (
<span>{subLabel}</span>
)}

11
src/renderer/component/snackBar/view.jsx
View file

@ -38,15 +38,16 @@ class SnackBar extends React.PureComponent<Props> {
}
return (
<div className={classnames("snack-bar", {
"snack-bar--error": isError
})}>
<div
className={classnames('snack-bar', {
'snack-bar--error': isError,
})}
>
<div className="snack-bar__message">
<div>&#9432;</div>
<div>{message}</div>
</div>
{linkText &&
linkTarget && (
{linkText && linkTarget && (
<Button navigate={linkTarget} className="snack-bar__action" label={linkText} />
)}
</div>

14
src/renderer/component/splash/internal/load-screen.jsx
View file

@ -22,9 +22,12 @@ class LoadScreen extends React.PureComponent<Props> {
return (
<div className="load-screen">
<div>
<div className="load-screen__header">
<h1 className="load-screen__title">{__('LBRY')}</h1>
<sup className="load-screen__beta">beta</sup>
<h1 className="load-screen__title">
{__('LBRY')}
<sup>beta</sup>
</h1>
</div>
{error ? (
<Fragment>
@ -32,7 +35,7 @@ class LoadScreen extends React.PureComponent<Props> {
<div className="card__actions">
<Button label="Refresh" button="alt" onClick={() => window.location.reload()} />
</div>
<div className="load-screen--help">
<div className="load-screen__help">
<p>
{__(
'If you still have issues, your anti-virus software or firewall may be preventing startup.'
@ -44,7 +47,8 @@ class LoadScreen extends React.PureComponent<Props> {
className="btn--load-screen"
href="https://lbry.io/faq/startup-troubleshooting"
label="this link"
/>.
/>
.
</p>
</div>
</Fragment>
@ -58,11 +62,13 @@ class LoadScreen extends React.PureComponent<Props> {
) : (
<div className="load-screen__message">{message}</div>
)}
{details && <div className="load-screen__details">{details}</div>}
<Spinner type="splash" />
</Fragment>
)}
</div>
</div>
);
}
}

4
src/renderer/component/subscribeButton/view.jsx
View file

@ -20,6 +20,7 @@ type Props = {
firstRunCompleted: boolean,
showSnackBarOnSubscribe: boolean,
doToast: ({ message: string }) => void,
buttonStyle: string,
};
export default (props: Props) => {
@ -33,6 +34,7 @@ export default (props: Props) => {
firstRunCompleted,
showSnackBarOnSubscribe,
doToast,
buttonStyle,
} = props;
const subscriptionHandler = isSubscribed ? doChannelUnsubscribe : doChannelSubscribe;
@ -44,7 +46,7 @@ export default (props: Props) => {
<Button
iconColor="red"
icon={isSubscribed ? undefined : ICONS.HEART}
button="alt"
button={buttonStyle ? buttonStyle : 'alt'}
label={subscriptionLabel}
onClick={e => {
e.stopPropagation();

2
src/renderer/component/subscribeSuggested/view.jsx
View file

@ -23,7 +23,7 @@ class SuggestedSubscriptions extends PureComponent<Props> {
return suggested ? (
<div className="card__content subscriptions__suggested">
{suggested.map(({ uri, label }) => (
<CategoryList isSubComponent key={uri} category={label} categoryLink={uri} />
<CategoryList key={uri} category={label} categoryLink={uri} />
))}
</div>
) : null;

5
src/renderer/component/transactionList/internal/transaction-list-item.jsx
View file

@ -67,10 +67,9 @@ class TransactionListItem extends React.PureComponent<Props> {
</td>
<td className="table__item--actionable">
{reward && <span>{reward.reward_title}</span>}
{name &&
claimId && (
{name && claimId && (
<Button
tourniquet
constrict
button="link"
navigate="/show"
navigateParams={{ uri: buildURI({ claimName: name, claimId }) }}

19
src/renderer/component/transactionList/view.jsx
View file

@ -1,5 +1,5 @@
// @flow
import * as ICONS from 'constants/icons';
import * as icons from 'constants/icons';
import * as MODALS from 'constants/modal_types';
import * as React from 'react';
import { FormField } from 'component/common/form';
@ -78,12 +78,12 @@ class TransactionList extends React.PureComponent<Props> {
return (
<React.Fragment>
<header className="card__header">
{!transactionList.length && (
<p className="card__content">{emptyMessage || __('No transactions to list.')}</p>
)}
{!slim &&
!!transactions.length && (
<div className="card__actions card__actions--between">
{!slim && !!transactionList.length && (
<div className="card__actions card__actions--between card__actions--top-space">
<FileExporter
data={transactionList}
label={__('Export')}
@ -91,7 +91,7 @@ class TransactionList extends React.PureComponent<Props> {
filters={['nout']}
defaultPath={__('lbry-transactions-history')}
/>
{!slim && (
<FormField
type="select"
value={filterSetting || TRANSACTIONS.ALL}
@ -101,7 +101,7 @@ class TransactionList extends React.PureComponent<Props> {
postfix={
<Button
button="link"
icon={ICONS.HELP}
icon={icons.HELP}
href="https://lbry.io/faq/transaction-types"
title={__('Help')}
/>
@ -113,11 +113,13 @@ class TransactionList extends React.PureComponent<Props> {
</option>
))}
</FormField>
)}
</div>
)}
</header>
{!!transactionList.length && (
<table className="card__content table table--transactions table--stretch">
<div className="card__content">
<table className="table table--transactions table--stretch">
<thead>
<tr>
<th>{__('Amount')}</th>
@ -139,6 +141,7 @@ class TransactionList extends React.PureComponent<Props> {
))}
</tbody>
</table>
</div>
)}
</React.Fragment>
);

22
src/renderer/component/transactionListRecent/view.jsx
View file

@ -1,6 +1,6 @@
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
// @flow
import type { Transaction } from 'component/transactionList/view';
import * as ICONS from 'constants/icons';
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
import * as icons from 'constants/icons';
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
import React, { Fragment } from 'react';
import BusyIndicator from 'component/common/busy-indicator';
import Button from 'component/button';
@ -27,22 +27,27 @@ class TransactionListRecent extends React.PureComponent<Props> {
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
const { fetchingTransactions, hasTransactions, transactions } = this.props;
return (
<section className="card card--section">
<div className="card__title card--space-between">
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
<header className="card__header card__header--flat">
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
<h2 className="card__title">
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
{__('Recent Transactions')}
<RefreshTransactionButton />
</div>
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
<div className="card__subtitle">
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
</h2>
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
<p className="card__subtitle">
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
{__('To view all of your transactions, navigate to the')}{' '}
<Button button="link" navigate="/history" label={__('transactions page')} />.
</div>
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
{fetchingTransactions &&
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
!hasTransactions && (
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
</p>
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
</header>
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
{fetchingTransactions && !hasTransactions && (
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
<div className="card__content">
<BusyIndicator message={__('Loading transactions')} />
</div>
)}
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
{hasTransactions && (
<Fragment>
<div className="card__content">
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
<TransactionList
slim
transactions={transactions}
@ -53,9 +58,10 @@ class TransactionListRecent extends React.PureComponent<Props> {
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
button="primary"
navigate="/history"
label={__('Full History')}
icon={ICONS.CLOCK}
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
icon={icons.CLOCK}
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
/>
</div>
</div>
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
</Fragment>
)}
</section>

neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though
neb-b commented 2018-12-12 20:32:43 +01:00 (Migrated from github.com)
Review
Copy link

Form imports I've been trying to follow the pattern of:

types
constants
node_modules
components/other
Form imports I've been trying to follow the pattern of: ``` types constants node_modules components/other ```
neb-b commented 2018-12-12 20:32:59 +01:00 (Migrated from github.com)
Review
Copy link

Not a big deal though

Not a big deal though

19
src/renderer/component/userEmailNew/view.jsx
View file

@ -41,11 +41,17 @@ class UserEmailNew extends React.PureComponent<Props, State> {
const { cancelButton, errorMessage, isPending } = this.props;
return (
<div>
<span>
<p>
{__("We'll let you know about LBRY updates, security issues, and great new content.")}
</p>
<p>{__("We'll never sell your email, and you can unsubscribe at any time.")}</p>
<p>
{__(
'In addition, your email address will never be sold and you can unsubscribe at any time.'
)}
</p>
<Form onSubmit={this.handleSubmit}>
<FormRow padded>
<FormField
@ -59,15 +65,18 @@ class UserEmailNew extends React.PureComponent<Props, State> {
onChange={this.handleEmailChanged}
/>
</FormRow>
<div className="card__actions">
<Submit label="Submit" disabled={isPending} />
{cancelButton}
<br /><br />
</div>
<div className="card__content help">
<p className="card__content help">
{`${__('Your email may be used to sync usage data across devices.')} `}
</div>
</p>
</Form>
</div>
</span>
);
}
}

19
src/renderer/component/userEmailVerify/view.jsx
View file

@ -54,8 +54,10 @@ class UserEmailVerify extends React.PureComponent<Props, State> {
const { cancelButton, errorMessage, email, isPending, onModal } = this.props;
return (
<Form onSubmit={this.handleSubmit}>
<span>
<p>Please enter the verification code emailed to {email}.</p>
<Form onSubmit={this.handleSubmit}>
<FormRow padded>
<FormField
stretch
@ -68,13 +70,7 @@ class UserEmailVerify extends React.PureComponent<Props, State> {
onChange={event => this.handleCodeChanged(event)}
/>
</FormRow>
<div className="help">
<p>
{__('Email')} <Button button="link" href="mailto:help@lbry.io" label="help@lbry.io" />{' '}
or join our <Button button="link" href="https://chat.lbry.io" label="chat" />{' '}
{__('if you encounter any trouble with your code.')}
</p>
</div>
<div className="card__actions">
<Submit label={__('Verify')} disabled={isPending} />
{cancelButton}
@ -86,6 +82,12 @@ class UserEmailVerify extends React.PureComponent<Props, State> {
/>
)}
</div>
<p className="help">
{__('Email')} <Button button="link" href="mailto:help@lbry.io" label="help@lbry.io" />{' '}
or join our <Button button="link" href="https://chat.lbry.io" label="chat" />{' '}
{__('if you encounter any trouble with your code.')}
</p>
{onModal && (
<div className="card__actions help">
<Button
@ -96,6 +98,7 @@ class UserEmailVerify extends React.PureComponent<Props, State> {
</div>
)}
</Form>
</span>
);
}
}

15
src/renderer/component/userHistory/view.jsx
View file

@ -161,13 +161,22 @@ class UserHistoryPage extends React.PureComponent<Props, State> {
</React.Fragment>
) : (
<div className="page__empty">
<h3 className="card__title">
{__("You don't have anything saved in history yet, go check out some content on LBRY!")}
</h3>
<section className="card card--section">
<header className="card__header">
<h2 className="card__title">
{__(
"You don't have anything saved in history yet, go check out some content on LBRY!"
)}
</h2>
</header>
<div className="card__content">
<div className="card__actions card__actions--center">
<Button button="primary" navigate="/discover" label={__('Explore new content')} />
</div>
</div>
</section>
</div>
);
}
}

2
src/renderer/component/userHistoryItem/view.jsx
View file

@ -47,7 +47,7 @@ class UserHistoryItem extends React.PureComponent<Props> {
<span className="time time--ago">{moment(lastViewed).from(moment())}</span>
<span className="item-list__item--cutoff">{title}</span>
<Button
tourniquet
constrict
button="link"
label={name ? `lbry://${name}` : `lbry://...`}
navigate="/show"

13
src/renderer/component/userPhoneVerify/view.jsx
View file

@ -50,17 +50,16 @@ class UserPhoneVerify extends React.PureComponent {
error={phoneErrorMessage}
/>
{/* render help separately so it always shows */}
<div className="meta">
<p>
{__('Email')} <Button button="link" href="mailto:help@lbry.io" label="help@lbry.io" />{' '}
or join our <Button button="link" href="https://chat.lbry.io" label="chat" />{' '}
{__('if you encounter any trouble with your code.')}
</p>
</div>
<div className="card__actions card__actions--center">
<Submit label={__('Verify')} />
{cancelButton}
</div>
<p className="help">
{__('Email')} <Button button="link" href="mailto:help@lbry.io" label="help@lbry.io" />{' '}
or join our <Button button="link" href="https://chat.lbry.io" label="chat" />{' '}
{__('if you encounter any trouble with your code.')}
</p>
</Form>
);
}

57
src/renderer/component/userVerify/view.jsx
View file

@ -1,5 +1,5 @@
// @flow
import * as ICONS from 'constants/icons';
import * as icons from 'constants/icons';
import * as React from 'react';
import Button from 'component/button';
import CardVerify from 'component/cardVerify';
@ -29,24 +29,31 @@ class UserVerify extends React.PureComponent<Props> {
return (
<React.Fragment>
<section className="card card--section">
<div className="card__title">
<h1>{__('Final Human Proof')}</h1>
</div>
<header className="card__header">
<h1 className="card__title">{__('Final Human Proof')}</h1>
</header>
<div className="card__content">
<p>
Finally, please complete <strong>one and only one</strong> of the options below.
</p>
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('1) Proof via Credit')}</div>
<p className="card__content">
<header className="card__header">
<h2 className="card__title">{__('1) Proof via Credit')}</h2>
</header>
<div className="card__content">
<p>
{`${__(
'If you have a valid credit or debit card, you can use it to instantly prove your humanity.'
)} ${__(
'LBRY does not store your credit card information. There is no charge at all for this, now or in the future.'
)} `}
</p>
<div className="card__actions">
{errorMessage && <p className="form-field__error">{errorMessage}</p>}
<CardVerify
@ -56,6 +63,8 @@ class UserVerify extends React.PureComponent<Props> {
stripeKey={Lbryio.getStripeToken()}
/>
</div>
</div>
<div className="card__content">
<div className="meta">
{__('A $1 authorization may temporarily appear with your provider.')}{' '}
@ -67,23 +76,31 @@ class UserVerify extends React.PureComponent<Props> {
</div>
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('2) Proof via Phone')}</div>
<p className="card__content">
<header className="card__header">
<h2 className="card__title">{__('2) Proof via Phone')}</h2>
</header>
<div className="card__content">
<p>
{`${__(
'You will receive an SMS text message confirming that your phone number is correct.'
)}`}
</p>
<div className="card__actions">
<Button
onClick={() => {
verifyPhone();
}}
button="primary"
icon={ICONS.PHONE}
icon={icons.PHONE}
label={__('Submit Phone Number')}
/>
</div>
</div>
<div className="card__content">
<div className="meta">
{__('Standard messaging rates apply. Having trouble?')}{' '}
@ -91,32 +108,43 @@ class UserVerify extends React.PureComponent<Props> {
</div>
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('3) Proof via Chat')}</div>
<header className="card__header">
<h2 className="card__title">{__('3) Proof via Chat')}</h2>
</header>
<div className="card__content">
<p>
{__(
'A moderator capable of approving you is typically available in the #verification channel of our chat room.'
)}
</p>
<p>
{__(
'This process will likely involve providing proof of a stable and established online or real-life identity.'
)}
</p>
</div>
<div className="card__actions">
<Button
href="https://chat.lbry.io"
button="primary"
icon={ICONS.MESSAGE}
icon={icons.MESSAGE}
label={__('Join LBRY Chat')}
/>
</div>
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('Or, Skip It Entirely')}</div>
<p className="card__content">
<header className="card__header">
<h2 className="card__title">{__('Or, Skip It Entirely')}</h2>
</header>
<div className="card__content">
<p>
{__(
'You can continue without this step, but you will not be eligible to earn rewards.'
)}
@ -128,6 +156,7 @@ class UserVerify extends React.PureComponent<Props> {
label={__('Skip Rewards')}
/>
</div>
</div>
</section>
</React.Fragment>
);

25
src/renderer/component/walletAddress/view.jsx
View file

@ -1,5 +1,5 @@
// @flow
import * as ICONS from 'constants/icons';
import * as icons from 'constants/icons';
import React from 'react';
import Button from 'component/button';
import Address from 'component/address';
@ -50,23 +50,27 @@ class WalletAddress extends React.PureComponent<Props, State> {
return (
<section className="card card--section">
<div className="card__title">{__('Receive Credits')}</div>
<header className="card__header">
<h2 className="card__title">{__('Receive Credits')}</h2>
<p className="card__subtitle">
{__('Use this wallet address to receive credits sent by another user (or yourself).')}
</p>
</header>
<div className="card__content">
<Address address={receiveAddress} showCopyButton />
</div>
<div className="card__content">
<div className="card__actions">
<Button
button="primary"
label={__('Get New Address')}
icon={ICONS.REFRESH}
icon={icons.REFRESH}
onClick={getNewAddress}
disabled={gettingNewAddress}
/>
<Button
button="link"
label={showQR ? __('Hide QR code') : __('Show QR code')}
@ -74,21 +78,18 @@ class WalletAddress extends React.PureComponent<Props, State> {
/>
</div>
{showQR && (
<div className="card__content">
<QRCode value={receiveAddress} paddingTop />
</div>
)}
<div className="card__content">
<div className="help">
<p>
<p className="help">
{__(
'You can generate a new address at any time, and any previous addresses will continue to work. Using multiple addresses can be helpful for keeping track of incoming payments from multiple sources.'
)}
</p>
</div>
{showQR && (
<div className="card__content">
<QRCode value={receiveAddress} paddingTop />
</div>
)}
</section>
);
}

9
src/renderer/component/walletBalance/view.jsx
View file

@ -10,10 +10,11 @@ const WalletBalance = (props: Props) => {
const { balance } = props;
return (
<section className="card card--section card--wallet-balance">
<div>
<div className="card__title">{__('Balance')}</div>
<span className="card__subtitle">{__('You currently have')}</span>
</div>
<header className="card__header">
<h2 className="card__title">{__('Balance')}</h2>
<p className="card__subtitle">{__('You currently have')}</p>
</header>
neb-b commented 2018-12-12 20:38:24 +01:00 (Migrated from github.com)
Review
Copy link

I think we might need to make some changes here. Since the balance is much larger, it takes up way more horizontal space if your balance has a lot of decimals.
screen shot 2018-12-12 at 2 36 23 pm
screen shot 2018-12-12 at 2 37 41 pm

Both of these are on the smallest possible screen width

I think we might need to make some changes here. Since the balance is much larger, it takes up way more horizontal space if your balance has a lot of decimals. <img width="400" alt="screen shot 2018-12-12 at 2 36 23 pm" src="https://user-images.githubusercontent.com/16882830/49894243-7973bb80-fe1b-11e8-874a-73ba05b50868.png"> <img width="400" alt="screen shot 2018-12-12 at 2 37 41 pm" src="https://user-images.githubusercontent.com/16882830/49894264-87294100-fe1b-11e8-9230-0f276701c8f6.png"> Both of these are on the smallest possible screen width
NetOpWibby commented 2018-12-14 22:11:32 +01:00 (Migrated from github.com)
Review
Copy link

I thought we weren't worrying about making things responsive.

I thought we weren't worrying about making things responsive.
NetOpWibby commented 2018-12-14 22:19:19 +01:00 (Migrated from github.com)
Review
Copy link

Why are we showing all these decimal points? We don't in the header bar. We don't in the hover text either.

display: block;
max-width: 400px;
overflow: hidden;
padding-right: 7rem;
text-overflow: ellipsis;
white-space: nowrap;

This does not look good on the <span/> surrounding the amount. You have ellipsis and extra space to add "LBC" in an ::after pseudo-element.

Another option is to have the numbers fade (to replace the ellipsis).

Let me know which direction you want me to go in.

Why are we showing all these decimal points? We don't in the header bar. We don't in the hover text either. ```sass display: block; max-width: 400px; overflow: hidden; padding-right: 7rem; text-overflow: ellipsis; white-space: nowrap; ``` This does not look good on the `<span/>` surrounding the amount. You have ellipsis and extra space to add "LBC" in an `::after` pseudo-element. Another option is to have the numbers fade (to replace the ellipsis). Let me know which direction you want me to go in.
neb-b commented 2018-12-14 22:44:23 +01:00 (Migrated from github.com)
Review
Copy link

We aren't worrying about mobile design, but the minimum app width still needs to look good.

We should show the full amount here, it's the only place you can see it. I think it's fine to show an estimate in the header because it goes to this page when you click on it, and shows the full amount in the hover text. It's a bug that we show an estimate when hovering over the large balance (I guess we don't even really need that though).

What about just dropping the font-size down to 4rem?

We aren't worrying about mobile design, but the minimum app width still needs to look good. We should show the full amount here, it's the only place you can see it. I think it's fine to show an estimate in the header because it goes to this page when you click on it, and shows the full amount in the hover text. It's a bug that we show an estimate when hovering over the large balance (I guess we don't even really need that though). What about just dropping the `font-size` down to `4rem`?
NetOpWibby commented 2018-12-14 22:48:08 +01:00 (Migrated from github.com)
Review
Copy link

I'll make it 3.5rem so the Rewards box has more breathing room at 950px.

I'll make it `3.5rem` so the Rewards box has more breathing room at `950px`.
<div className="card__content">
{(balance || balance === 0) && <CreditAmount large amount={balance} precision={8} />}
</div>

5
src/renderer/component/walletSend/view.jsx
View file

@ -37,7 +37,10 @@ class WalletSend extends React.PureComponent<Props> {
return (
<section className="card card--section">
<div className="card__title">{__('Send Credits')}</div>
<header className="card__header">
<h2 className="card__title">{__('Send Credits')}</h2>
</header>
<div className="card__content">
<Formik
initialValues={{

14
src/renderer/component/walletSendTip/view.jsx
View file

@ -92,12 +92,14 @@ class WalletSendTip extends React.PureComponent<Props, State> {
placeholder="1.23"
onChange={event => this.handleSupportPriceChange(event)}
helper={
<span>
<p>
{__(`This will appear as a tip for "${title}".`)}{' '}
<Button label={__('Learn more')} button="link" href="https://lbry.io/faq/tipping" />
</span>
</p>
}
/>
<div className="card__content">
<div className="card__actions">
<Button
button="primary"
@ -105,7 +107,13 @@ class WalletSendTip extends React.PureComponent<Props, State> {
disabled={isPending || tipError}
onClick={this.handleSendButtonClicked}
/>
<Button button="link" label={__('Cancel')} onClick={onCancel} navigateParams={{ uri }} />
<Button
button="link"
label={__('Cancel')}
onClick={onCancel}
navigateParams={{ uri }}
/>
</div>
</div>
</section>
);

2
src/renderer/component/wunderbar/index.js
View file

@ -39,7 +39,7 @@ const perform = dispatch => ({
updateSearchQuery: query => dispatch(doUpdateSearchQuery(query)),
doFocus: () => dispatch(doFocusSearchInput()),
doBlur: () => dispatch(doBlurSearchInput()),
doShowSnackBar: (props) => dispatch(doToast(props)),
doShowSnackBar: props => dispatch(doToast(props)),
});
export default connect(

1
src/renderer/constants/icons.js
View file

@ -1,3 +1,4 @@
// React Feather
export const FEATURED = 'Award';
export const LOCAL = 'Folder';
export const ALERT = 'AlertCircle';

9
src/renderer/modal/modal.jsx
View file

@ -67,10 +67,12 @@ export class Modal extends React.PureComponent<ModalProps> {
![null, undefined, ''].includes(overlayClassName) ? overlayClassName : 'modal-overlay'
}
>
<h1 className="modal__header">{title}</h1>
<div>{children}</div>
<h1 className="card__title">{title}</h1>
<div className="card__content">{children}</div>
<div className="card__content">
{type === 'custom' ? null : ( // custom modals define their own buttons
<div className="card__actions card__actions--center">
<div className="card__actions">
<Button
button="primary"
label={confirmButtonLabel}
@ -87,6 +89,7 @@ export class Modal extends React.PureComponent<ModalProps> {
) : null}
</div>
)}
</div>
</ReactModal>
);
}

4
src/renderer/modal/modalAffirmPurchase/view.jsx
View file

@ -40,13 +40,13 @@ class ModalAffirmPurchase extends React.PureComponent<Props> {
onConfirmed={this.onAffirmPurchase}
onAborted={cancelPurchase}
>
<section className="card__content">
<p>
{__('This will purchase')} <strong>{`"${title}"`}</strong> {__('for')}{' '}
<strong>
<FilePrice uri={uri} showFullPrice inheritStyle showLBC={false} />
</strong>{' '}
{__('credits')}.
</section>
</p>
</Modal>
);
}

9
src/renderer/modal/modalCreditIntro/view.jsx
View file

@ -20,9 +20,11 @@ const ModalCreditIntro = (props: Props) => {
<Modal type="custom" isOpen contentLabel="Welcome to LBRY" title={__('LBRY Credits Needed')}>
<section className="card__content">
<p>
Some actions require LBRY credits (<em>
Some actions require LBRY credits (
<em>
<CurrencySymbol />
</em>), the blockchain token that powers the LBRY network.
</em>
), the blockchain token that powers the LBRY network.
</p>
{currentBalance <= 0 && (
<p>
@ -37,6 +39,9 @@ const ModalCreditIntro = (props: Props) => {
{__('in free rewards for participating in the LBRY beta.')}
</p>
)}
</section>
<section className="card__content">
<div className="card__actions card__actions--center">
<Button button="primary" onClick={addBalance} label={__('Get Credits')} />
<Button

5
src/renderer/modal/modalPublish/index.js
View file

@ -10,4 +10,7 @@ const perform = dispatch => ({
navigate: (path, params) => dispatch(doNavigate(path, params)),
});
export default connect(null, perform)(ModalSendTip);
export default connect(
null,
perform
)(ModalSendTip);

6
src/renderer/modal/modalRemoveFile/index.js
View file

@ -1,10 +1,6 @@
import { connect } from 'react-redux';
import { doDeleteFileAndGoBack } from 'redux/actions/file';
import {
makeSelectTitleForUri,
makeSelectClaimIsMine,
makeSelectFileInfoForUri,
} from 'lbry-redux';
import { makeSelectTitleForUri, makeSelectClaimIsMine, makeSelectFileInfoForUri } from 'lbry-redux';
import { doHideModal } from 'redux/actions/app';
import ModalRemoveFile from './view';

6
src/renderer/modal/modalWalletDecrypt/index.js
View file

@ -1,9 +1,5 @@
import { connect } from 'react-redux';
import {
doWalletStatus,
doWalletDecrypt,
selectWalletDecryptSucceeded,
} from 'lbry-redux';
import { doWalletStatus, doWalletDecrypt, selectWalletDecryptSucceeded } from 'lbry-redux';
import { doHideModal } from 'redux/actions/app';
import ModalWalletDecrypt from './view';

6
src/renderer/modal/modalWalletUnlock/index.js
View file

@ -1,9 +1,5 @@
import { connect } from 'react-redux';
import {
doWalletUnlock,
selectWalletUnlockPending,
selectWalletUnlockSucceeded,
} from 'lbry-redux';
import { doWalletUnlock, selectWalletUnlockPending, selectWalletUnlockSucceeded } from 'lbry-redux';
import { doQuit, doHideModal } from 'redux/actions/app';
import ModalWalletUnlock from './view';

14
src/renderer/page/auth/view.jsx
View file

@ -78,12 +78,14 @@ class AuthPage extends React.PureComponent<Props> {
<Page>
{useTemplate ? (
<section className="card card--section">
<div className="card__title">
<h1>{this.getTitle()}</h1>
</div>
<div className="card__content">{innerContent}</div>
<header className="card__header card__header--flat">
<h2 className="card__title">{this.getTitle()}</h2>
</header>
<div className="card__content">
<div className="help">
{innerContent}
<p className="help">
{`${__(
'This information is disclosed only to LBRY, Inc. and not to the LBRY network. It is only required to earn LBRY rewards and may be used to sync usage data across devices.'
)} `}
@ -92,7 +94,7 @@ class AuthPage extends React.PureComponent<Props> {
onClick={() => navigate('/discover')}
label={__('Return home.')}
/>
</div>
</p>
</div>
</section>
) : (

15
src/renderer/page/backup/view.jsx
View file

@ -20,15 +20,21 @@ class BackupPage extends React.PureComponent<Props> {
<Page>
<section className="card card--section">
{noDaemonSettings ? (
<div className="card__title">{__('Failed to load settings.')}</div>
<header className="card__header">
<h2 className="card__title">{__('Failed to load settings.')}</h2>
</header>
) : (
<React.Fragment>
<div className="card__title">{__('Backup Your LBRY Credits')}</div>
<header className="card__header">
<h2 className="card__title">{__('Backup Your LBRY Credits')}</h2>
<p className="card__subtitle">
{__(
'Your LBRY credits are controllable by you and only you, via wallet file(s) stored locally on your computer.'
)}
</p>
</header>
<div className="card__content">
<p>
{__(
@ -40,7 +46,7 @@ class BackupPage extends React.PureComponent<Props> {
'However, it is fairly easy to back up manually. To backup your wallet, make a copy of the folder listed below:'
)}
</p>
<p className="card__success-msg">{lbryumWalletDir}</p>
<p className="card__message">{lbryumWalletDir}</p>
<p>
{__(
'Access to these files are equivalent to having access to your credits. Keep any copies you make of your wallet in a secure place.'
@ -52,7 +58,8 @@ class BackupPage extends React.PureComponent<Props> {
button="link"
href="https://lbry.io/faq/how-to-backup-wallet"
label={__('see this article')}
/>.
/>
.
</p>
</div>
</React.Fragment>

28
src/renderer/page/channel/view.jsx
View file

@ -1,6 +1,6 @@
// @flow
import type { Claim } from 'types/claim';
import * as ICONS from 'constants/icons';
import * as icons from 'constants/icons';
import * as MODALS from 'constants/modal_types';
import React from 'react';
import BusyIndicator from 'component/common/busy-indicator';
@ -85,26 +85,33 @@ class ChannelPage extends React.PureComponent<Props> {
return (
<Page notContained>
<section>
<header className="channel-info">
<h1>
{name}
{fetching && <BusyIndicator />}
</h1>
</section>
<div className="card__actions">
<SubscribeButton uri={`lbry://${permanentUrl}`} />
<div className="channel-info__actions">
<div className="channel-info__actions__group">
<SubscribeButton uri={`lbry://${permanentUrl}`} channelName={name} />
<Button
button="alt"
icon={ICONS.GLOBE}
icon={icons.GLOBE}
label={__('Share Channel')}
onClick={() =>
openModal(MODALS.SOCIAL_SHARE, { uri, speechShareable: true, isChannel: true })
openModal(
{ id: MODALS.SOCIAL_SHARE },
{ uri, speechShareable: true, isChannel: true }
)
}
/>
</div>
<section className="card__content">{contentList}</section>
{(!fetching || (claimsInChannel && claimsInChannel.length)) &&
totalPages > 1 && (
</div>
</header>
<section className="media-group--list">{contentList}</section>
{(!fetching || (claimsInChannel && claimsInChannel.length)) && totalPages > 1 && (
<FormRow verticallyCentered centered>
<ReactPaginate
pageCount={totalPages}
@ -131,6 +138,7 @@ class ChannelPage extends React.PureComponent<Props> {
/>
</FormRow>
)}
neb-b commented 2018-12-12 20:51:55 +01:00 (Migrated from github.com)
Review
Copy link

When navigating to a channel page, there can be some content jank if it loads quickly. It's happening because of the style changes in page/show/view.jsx. I don't think we need those. Before it was really nice how the channel stayed in the same place when everything loaded. That call usually pretty quick so I think we should keep it.
https://giphy.com/gifs/Zw7a22HKncKIaolawh

When navigating to a channel page, there can be some content jank if it loads quickly. It's happening because of the style changes in `page/show/view.jsx`. I don't think we need those. Before it was really nice how the channel stayed in the same place when everything loaded. That call usually pretty quick so I think we should keep it. https://giphy.com/gifs/Zw7a22HKncKIaolawh
{!channelIsMine && <HiddenNsfwClaims className="card__content help" uri={uri} />}
</Page>
);

67
src/renderer/page/file/view.jsx
View file

@ -2,7 +2,7 @@
import type { Claim, Metadata } from 'types/claim';
import type { FileInfo } from 'types/file_info';
import * as MODALS from 'constants/modal_types';
import * as ICONS from 'constants/icons';
import * as icons from 'constants/icons';
import * as React from 'react';
import * as settings from 'constants/settings';
import { buildURI, normalizeURI } from 'lbry-redux';
@ -21,8 +21,6 @@ import FileDownloadLink from 'component/fileDownloadLink';
import classnames from 'classnames';
import getMediaType from 'util/get-media-type';
import RecommendedContent from 'component/recommendedContent';
import { FormField, FormRow } from 'component/common/form';
import ToolTip from 'component/common/tooltip';
type Props = {
claim: Claim,
@ -37,7 +35,6 @@ type Props = {
fetchFileInfo: string => void,
fetchCostInfo: string => void,
setViewed: string => void,
autoplay: boolean,
isSubscribed: ?string,
isSubscribed: boolean,
channelUri: string,
@ -126,7 +123,6 @@ class FilePage extends React.Component<Props> {
navigate,
costInfo,
fileInfo,
autoplay,
channelUri,
} = this.props;
@ -163,7 +159,6 @@ class FilePage extends React.Component<Props> {
return (
<Page forContent>
<section className="content__wrapper">
{showFile && <FileViewer className="content__embedded" uri={uri} mediaType={mediaType} />}
{!showFile &&
(thumbnail ? (
@ -180,27 +175,33 @@ class FilePage extends React.Component<Props> {
</div>
))}
<div className="card__content">
<div className="card--space-between">
<h1>{title}</h1>
<div className="card__title-identity-ICONS">
<div className="media__content media__content--large">
<h1 className="media__title media__title--large">{title}</h1>
<div className="media__properties media__properties--large">
{isRewardContent && (
<Icon size={20} iconColor="red" tooltip="bottom" icon={ICONS.FEATURED} />
<Icon size={20} iconColor="red" tooltip="bottom" icon={icons.FEATURED} />
)}
{metadata.nsfw && <div className="badge badge--nsfw">NSFW</div>}
<FilePrice badge uri={normalizeURI(uri)} />
</div>
<div className="media__subtitle media__subtitle--large">
<div className="media__subtitle__channel">
<UriIndicator uri={uri} link />
</div>
<span className="card__subtitle">
<UriIndicator uri={uri} link /> {__('published on')}{' '}
<DateTime block={height} show={DateTime.SHOW_DATE} />
</span>
{metadata.nsfw && <div>NSFW</div>}
<div className="card__actions card__actions--no-margin card__actions--between">
<div className="card__actions">
<div className="media__subtitle__date">
{__('Published on')} <DateTime block={height} show={DateTime.SHOW_DATE} />
</div>
</div>
<div className="media__actions media__actions--between">
<div className="media__action-group--large">
{claimIsMine ? (
<Button
button="primary"
icon={ICONS.EDIT}
icon={icons.EDIT}
label={__('Edit')}
onClick={() => {
prepareEdit(claim, editUri);
@ -208,45 +209,35 @@ class FilePage extends React.Component<Props> {
}}
/>
neb-b commented 2018-12-12 21:31:06 +01:00 (Migrated from github.com)
Review
Copy link

If we are removing the wrapper on this, we should probably add some sort of max-height, then add a background so the thumbnail, content doesn't get huge. Most thumbails aren't great on large screens, and this will only be exacerbated on larger screens.

screen shot 2018-12-12 at 3 28 55 pm screen shot 2018-12-12 at 3 30 24 pm
If we are removing the wrapper on this, we should probably add some sort of max-height, then add a background so the thumbnail, content doesn't get huge. Most thumbails aren't great on large screens, and this will only be exacerbated on larger screens. <img width="400" alt="screen shot 2018-12-12 at 3 28 55 pm" src="https://user-images.githubusercontent.com/16882830/49896899-a9728d00-fe22-11e8-88f0-ee6404a1040f.png"> <img width="400" alt="screen shot 2018-12-12 at 3 30 24 pm" src="https://user-images.githubusercontent.com/16882830/49897005-e8a0de00-fe22-11e8-85d1-3ff556a355b9.png">
) : (
<SubscribeButton uri={channelUri} />
<SubscribeButton uri={channelUri} channelName={channelName} />
)}
{!claimIsMine && (
<Button
button="alt"
icon={ICONS.GIFT}
icon={icons.GIFT}
label={__('Send a tip')}
onClick={() => openModal(MODALS.SEND_TIP, { uri })}
onClick={() => openModal({ id: MODALS.SEND_TIP }, { uri })}
/>
)}
<Button
button="alt"
icon={ICONS.GLOBE}
icon={icons.GLOBE}
label={__('Share')}
onClick={() => openModal(MODALS.SOCIAL_SHARE, { uri, speechShareable })}
onClick={() => openModal({ id: MODALS.SOCIAL_SHARE }, { uri, speechShareable })}
/>
</div>
<div className="card__actions">
<div className="media__action-group--large">
<FileDownloadLink uri={uri} />
<FileActions uri={uri} claimId={claim.claim_id} />
</div>
</div>
<FormRow>
<ToolTip direction="right" body={__('Automatically download and play free content.')}>
<FormField
name="autoplay"
type="checkbox"
postfix={__('Autoplay')}
checked={autoplay}
onChange={this.onAutoplayChange}
/>
</ToolTip>
</FormRow>
<div className="card__content">
<div className="media__info--large">
<FileDetails uri={uri} />
</div>
</div>
</section>
<RecommendedContent uri={uri} />
</Page>
);

11
src/renderer/page/fileListDownloaded/view.jsx
View file

@ -23,7 +23,14 @@ class FileListDownloaded extends React.PureComponent<Props> {
<FileList fileInfos={fileInfos} sortBy={sortBy} page={PAGES.DOWNLOADED} />
) : (
<div className="page__empty">
<h3 className="card__title">{__("You haven't downloaded anything from LBRY yet.")}</h3>
<section className="card card--section">
<header className="card__header">
<h2 className="card__title">
{__("You haven't downloaded anything from LBRY yet.")}
</h2>
</header>
<div className="card__content">
<div className="card__actions card__actions--center">
<Button
button="primary"
@ -32,6 +39,8 @@ class FileListDownloaded extends React.PureComponent<Props> {
/>
</div>
</div>
</section>
</div>
)}
</Page>
);

11
src/renderer/page/fileListPublished/view.jsx
View file

@ -34,9 +34,14 @@ class FileListPublished extends React.PureComponent<Props> {
/>
) : (
<div className="page__empty">
<h3 className="card__title">
<section className="card card--section">
<header className="card__header">
<h2 className="card__title">
{__("It looks like you haven't published anything to LBRY yet.")}
</h3>
</h2>
</header>
<div className="card__content">
<div className="card__actions card__actions--center">
<Button
button="primary"
@ -45,6 +50,8 @@ class FileListPublished extends React.PureComponent<Props> {
/>
</div>
</div>
</section>
</div>
)}
</Page>
);

14
src/renderer/page/getCredits/view.jsx
View file

@ -14,7 +14,10 @@ const GetCreditsPage = () => (
<ShapeShift />
*/}
<section className="card card--section">
<div className="card__title">{__('More ways to get LBRY Credits')}</div>
<header className="card__header">
<h2 className="card__title">{__('More ways to get LBRY Credits')}</h2>
</header>
<div className="card__content">
<p>
{
@ -22,8 +25,15 @@ const GetCreditsPage = () => (
}
</p>
</div>
<div className="card__content">
<div className="card__actions">
<Button button="primary" href="https://lbry.io/faq/earn-credits" label={__('Read More')} />
<Button
button="primary"
href="https://lbry.io/faq/earn-credits"
label={__('Read More')}
/>
</div>
</div>
</section>
</Page>

65
src/renderer/page/help/view.jsx
View file

@ -1,6 +1,6 @@
// @TODO: Customize advice based on OS
// @flow
import * as ICONS from 'constants/icons';
import * as icons from 'constants/icons';
import * as React from 'react';
import { shell } from 'electron';
import { Lbry } from 'lbry-redux';
@ -119,87 +119,114 @@ class HelpPage extends React.PureComponent<Props, State> {
return (
<Page>
<section className="card card--section">
<div className="card__title">{__('Read the FAQ')}</div>
<header className="card__header">
<h2 className="card__title">{__('Read the FAQ')}</h2>
<p className="card__subtitle">{__('Our FAQ answers many common questions.')}</p>
</header>
<div className="card__content">
<div className="card__actions">
<Button
href="https://lbry.io/faq"
label={__('Read the FAQ')}
icon={ICONS.HELP}
icon={icons.HELP}
button="primary"
/>
</div>
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('Get Live Help')}</div>
<header className="card__header">
<h2 className="card__title">{__('Get Live Help')}</h2>
<p className="card__subtitle">
{__('Live help is available most hours in the')} <strong>#help</strong>{' '}
{__('channel of our Discord chat room.')}
</p>
</header>
<div className="card__content">
<div className="card__actions">
<Button
button="primary"
label={__('Join Our Chat')}
icon={ICONS.MESSAGE}
icon={icons.MESSAGE}
href="https://chat.lbry.io"
/>
</div>
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('View your Log')}</div>
<header className="card__header">
<h2 className="card__title">{__('View your Log')}</h2>
<p className="card__subtitle">
{__('Did something go wrong? Have a look in your log file, or send it to')}{' '}
<Button button="link" label={__('support')} href="https://lbry.io/faq/support" />.
</p>
</header>
<div className="card__content">
<div className="card__actions">
<Button
button="primary"
label={__('Open Log')}
icon={ICONS.REPORT}
icon={icons.REPORT}
onClick={() => this.openLogFile(dataDirectory)}
/>
<Button
button="primary"
label={__('Open Log Folder')}
icon={ICONS.REPORT}
icon={icons.REPORT}
onClick={() => shell.openItem(dataDirectory)}
/>
</div>
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('Report a Bug or Suggest a New Feature')}</div>
<header className="card__header">
<h2 className="card__title">{__('Report a Bug or Suggest a New Feature')}</h2>
<p className="card__subtitle">
{__('Did you find something wrong? Think LBRY could add something useful and cool?')}{' '}
{__('Did you find something wrong? Think LBRY could add something useful and cool?')}
<Button button="link" label={__('Learn more')} href="https://lbry.io/faq/support" />
</p>
</header>
<div className="card__content">
<div className="card__actions">
<Button
navigate="/report"
label={__('Submit a Bug Report/Feature Request')}
icon={ICONS.REPORT}
icon={icons.REPORT}
button="primary"
/>
</div>
<div className="card__meta">{__('Thanks! LBRY is made by its users.')}</div>
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('About')}</div>
<header className="card__header">
<h2 className="card__title">{__('About')}</h2>
{this.state.upgradeAvailable !== null && this.state.upgradeAvailable ? (
<div className="card__subtitle">
<p className="card__subtitle">
{__('A newer version of LBRY is available.')}{' '}
<Button button="link" href={newVerLink} label={__('Download now!')} />
</div>
</p>
) : (
<div className="card__subtitle">{__('Your LBRY app is up to date.')}</div>
<p className="card__subtitle">{__('Your LBRY app is up to date.')}</p>
)}
</header>
<div className="card__content">
{this.state.uiVersion && ver ? (
<table className="card__content table table--stretch table--help">
<table className="table table--stretch table--help">
<tbody>
<tr>
<td>{__('App')}</td>
@ -247,11 +274,10 @@ class HelpPage extends React.PureComponent<Props, State> {
{this.state.accessTokenHidden && (
<Button button="link" label={__('View')} onClick={this.showAccessToken} />
)}
{!this.state.accessTokenHidden &&
accessToken && (
{!this.state.accessTokenHidden && accessToken && (
<div>
<p>{accessToken}</p>
<div className="help">
<div className="alert-text">
{__('This is equivalent to a password. Do not post or share this.')}
</div>
</div>
@ -263,6 +289,7 @@ class HelpPage extends React.PureComponent<Props, State> {
) : (
<BusyIndicator message={__('Looking up version info')} />
)}
</div>
</section>
</Page>
);

11
src/renderer/page/report/view.jsx
View file

@ -46,12 +46,15 @@ class ReportPage extends React.Component {
return (
<Page>
<section className="card card--section">
<div className="card__title">{__('Report an Issue/Request a Feature')}</div>
<header className="card__header">
<h2 className="card__title">{__('Report an Issue/Request a Feature')}</h2>
<p className="card__subtitle">
{__(
'Please describe the problem you experienced or the feature you want to see and any information you think might be useful to us. Links to screenshots are great!'
)}
</p>
</header>
<div className="card__content">
<FormRow>
<FormField
@ -79,8 +82,12 @@ class ReportPage extends React.Component {
</div>
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('Developer?')}</div>
<header className="card__header">
<h2 className="card__title">{__('Developer?')}</h2>
</header>
<div className="card__content">
<p>
{__('You can also')}{' '}

19
src/renderer/page/rewards/view.jsx
View file

@ -34,13 +34,14 @@ class RewardsPage extends PureComponent<Props> {
if (!user.primary_email || !user.has_verified_email || !user.is_identity_verified) {
return (
<section className="card card--section">
<div className="card__title">{__('Humans Only')}</div>
<div className="card__subtitle">
<p>
<header className="card__header">
<h2 className="card__title">{__('Humans Only')}</h2>
<p className="card__subtitle">
{__('Rewards are for human beings only.')}{' '}
{__("You'll have to prove you're one of us before you can claim any rewards.")}
</p>
</div>
</header>
<div className="card__content">
<Button onClick={doAuth} button="primary" label="Prove Humanity" />
</div>
@ -96,8 +97,12 @@ class RewardsPage extends PureComponent<Props> {
if (daemonSettings && !daemonSettings.share_usage_data) {
return (
<div className="card card--section">
<div className="card__title">{__('Disabled')}</div>
<section className="card card--section">
<header className="card__header">
<h2 className="card__title">{__('Disabled')}</h2>
</header>
<div className="card__content">
<p>
{__(
'Rewards are currently disabled for your account. Turn on diagnostic data sharing, in'
@ -106,6 +111,7 @@ class RewardsPage extends PureComponent<Props> {
{__(', in order to re-enable them.')}
</p>
</div>
</section>
);
} else if (fetching) {
return (
@ -142,6 +148,7 @@ class RewardsPage extends PureComponent<Props> {
const isNotEligible =
!user || !user.primary_email || !user.has_verified_email || !user.is_reward_approved;
return (
<div
className={classnames('card__list--rewards', {

18
src/renderer/page/search/view.jsx
View file

@ -1,6 +1,6 @@
// @flow
import * as ICONS from 'constants/icons';
import * as SETTINGS from 'constants/settings';
import * as ICONS from 'constants/icons';
import * as React from 'react';
import { isURIValid, normalizeURI, parseURI } from 'lbry-redux';
import { FormField, FormRow } from 'component/common/form';
@ -48,10 +48,10 @@ class SearchPage extends React.PureComponent<Props> {
return (
<Page noPadding>
{query &&
isValid && (
<div className="search__top">
<div className="file-list__header">
<section className="search">
{query && isValid && (
<header className="search__header">
<h1 className="search__title">
{`lbry://${query}`}
<ToolTip
icon
@ -59,15 +59,16 @@ class SearchPage extends React.PureComponent<Props> {
>
<Icon icon={ICONS.HELP} />
</ToolTip>
</div>
</h1>
{isChannel ? (
<ChannelTile size="large" uri={uri} />
) : (
<FileTile size="large" displayHiddenMessage uri={uri} />
)}
</div>
</header>
)}
<div className="search__content">
<div className="search__results-wrapper">
<FormRow alignRight>
<FormField
type="number"
@ -94,6 +95,7 @@ class SearchPage extends React.PureComponent<Props> {
<FileListSearch query={query} />
<div className="help">{__('These search results are provided by LBRY, Inc.')}</div>
</div>
</section>
</Page>
);
}

86
src/renderer/page/settings/view.jsx
View file

@ -182,8 +182,11 @@ class SettingsPage extends React.PureComponent<Props, State> {
) : (
<React.Fragment>
<section className="card card--section">
<div className="card__title">{__('Download Directory')}</div>
<span className="card__subtitle">{__('LBRY downloads will be saved here.')}</span>
<header className="card__header">
<h2 className="card__title">{__('Download Directory')}</h2>
<p className="card__subtitle">{__('LBRY downloads will be saved here.')}</p>
</header>
<div className="card__content">
<FileSelector
type="openDirectory"
@ -192,13 +195,17 @@ class SettingsPage extends React.PureComponent<Props, State> {
/>
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('Max Purchase Price')}</div>
<span className="card__subtitle">
<header className="card__header">
<h2 className="card__title">{__('Max Purchase Price')}</h2>
<p className="card__subtitle">
{__(
'This will prevent you from purchasing any content over a certain cost, as a safety measure.'
)}
</span>
</p>
</header>
<div className="card__content">
<FormField
type="radio"
@ -233,13 +240,17 @@ class SettingsPage extends React.PureComponent<Props, State> {
)}
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('Purchase Confirmations')}</div>
<div className="card__subtitle">
<header className="card__header">
<h2 className="card__title">{__('Purchase Confirmations')}</h2>
<p className="card__subtitle">
{__(
"When this option is chosen, LBRY won't ask you to confirm downloads below your chosen price."
)}
</div>
</p>
</header>
<div className="card__content">
<FormField
type="radio"
@ -269,8 +280,13 @@ class SettingsPage extends React.PureComponent<Props, State> {
)}
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('Content Settings')}</div>
<header className="card__header">
<h2 className="card__title">{__('Content Settings')}</h2>
</header>
<div className="card__content">
<FormField
type="checkbox"
name="autoplay"
@ -278,6 +294,7 @@ class SettingsPage extends React.PureComponent<Props, State> {
checked={autoplay}
postfix={__('Autoplay media files')}
/>
<FormField
type="checkbox"
name="auto_download"
@ -285,6 +302,7 @@ class SettingsPage extends React.PureComponent<Props, State> {
checked={autoDownload}
postfix={__('Automatically download new content from your subscriptions')}
/>
<FormField
type="checkbox"
name="show_nsfw"
@ -295,10 +313,15 @@ class SettingsPage extends React.PureComponent<Props, State> {
'NSFW content may include nudity, intense sexuality, profanity, or other adult content. By displaying NSFW content, you are affirming you are of legal age to view mature content in your country or jurisdiction. '
)}
/>
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('Notifications')}</div>
<header className="card__header">
<h2 className="card__title">{__('Notifications')}</h2>
</header>
<div className="card__content">
<FormField
type="checkbox"
name="desktopNotification"
@ -306,10 +329,15 @@ class SettingsPage extends React.PureComponent<Props, State> {
checked={osNotificationsEnabled}
postfix={__('Show Desktop Notifications')}
/>
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('Share Diagnostic Data')}</div>
<header className="card__header">
<h2 className="card__title">{__('Share Diagnostic Data')}</h2>
</header>
<div className="card__content">
<FormField
type="checkbox"
name="share_usage_data"
@ -322,9 +350,15 @@ class SettingsPage extends React.PureComponent<Props, State> {
'You will be ineligible to earn rewards while diagnostics are not being shared.'
)}
/>
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('Theme')}</div>
<header className="card__header">
<h2 className="card__title">{__('Theme')}</h2>
</header>
<div className="card__content">
<FormField
name="theme_select"
type="select"
@ -338,6 +372,7 @@ class SettingsPage extends React.PureComponent<Props, State> {
</option>
))}
</FormField>
<FormField
type="checkbox"
name="automatic_dark_mode"
@ -346,9 +381,15 @@ class SettingsPage extends React.PureComponent<Props, State> {
disabled={isDarkModeEnabled}
postfix={__('Automatic dark mode (9pm to 8am)')}
/>
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('Wallet Security')}</div>
<header className="card__header">
<h2 className="card__title">{__('Wallet Security')}</h2>
</header>
<div className="card__content">
<FormField
type="checkbox"
name="encrypt_wallet"
@ -357,23 +398,28 @@ class SettingsPage extends React.PureComponent<Props, State> {
postfix={__('Encrypt my wallet with a custom password.')}
helper={
<React.Fragment>
{__(
'Secure your local wallet data with a custom password. Lost passwords cannot be recovered.'
)}{' '}
{__('Secure your local wallet data with a custom password.')}{' '}
<strong>{__('Lost passwords cannot be recovered.')} </strong>
<Button
button="link"
label={__('Learn more')}
href="https://lbry.io/faq/wallet-encryption"
/>.
/>
.
</React.Fragment>
}
/>
</div>
</section>
<section className="card card--section">
<div className="card__title">{__('Application Cache')}</div>
<span className="card__subtitle">
<header className="card__header">
<h2 className="card__title">{__('Application Cache')}</h2>
<p className="card__subtitle">
{__('This will clear the application cache. Your wallet will not be affected.')}
</span>
</p>
</header>
<div className="card__content">
<Button
button="primary"

9
src/renderer/page/show/view.jsx
View file

@ -40,19 +40,12 @@ class ShowPage extends React.PureComponent<Props> {
let innerContent = '';
if ((isResolvingUri && !claim) || !claim) {
const { claimName } = parseURI(uri);
innerContent = (
<Page notContained>
<section>
<h1>{claimName}</h1>
<div className="card__content">
{isResolvingUri && <BusyIndicator message={__('Loading decentralized data...')} />}
{claim === null &&
!isResolvingUri && (
{claim === null && !isResolvingUri && (
<span className="empty">{__("There's nothing at this location.")}</span>
)}
</div>
</section>
</Page>
);
} else if (claim && claim.name.length && claim.name[0] === '@') {

2
src/renderer/page/subscriptions/internal/first-run.jsx
View file

@ -23,7 +23,7 @@ export default (props: Props) => {
return (
<Fragment>
<div className="page__empty--horizontal">
<div className="yrbl-wrap">
<img
alt="Friendly gerbil"
className="subscriptions__gerbil"

21
src/renderer/page/subscriptions/internal/user-subscriptions.jsx
View file

@ -72,7 +72,7 @@ export default (props: Props) => {
{!hasSubscriptions && (
<Fragment>
<div className="page__empty--horizontal">
<div className="yrbl-wrap">
<img
alt="Sad gerbil"
className="subscriptions__gerbil"
@ -105,8 +105,8 @@ export default (props: Props) => {
unreadSubscriptions.map(({ channel, uris }) => {
const { claimName } = parseURI(channel);
return (
<section key={channel}>
<div className="card__title card__actions card__actions--no-margin">
<span>
<h2 className="card__title card__title--flex">
<Button
button="link"
navigate="/show"
@ -114,18 +114,23 @@ export default (props: Props) => {
label={claimName}
/>
<MarkAsRead channel={channel} />
</div>
<div className="card__list card__content">
{uris.map(uri => <FileCard key={uri} uri={uri} />)}
</div>
</h2>
<section className="media-group--list" key={channel}>
<ul className="card__list">
{uris.map(uri => (
<FileCard key={uri} uri={uri} />
))}
</ul>
</section>
</span>
);
})
) : (
<Fragment>
<div className="page__empty">
<h3 className="card__title">{__('All caught up!')}</h3>
<p className="card__subtitle">{__('You might like these channels below.')}</p>
<p className="card__subtitle">{__('You might like the channels below.')}</p>
</div>
<SuggestedSubscriptions />
</Fragment>

6
src/renderer/page/transactionHistory/view.jsx
View file

@ -26,10 +26,12 @@ class TransactionHistoryPage extends React.PureComponent<Props> {
return (
<Page>
<section className="card card--section">
<div className="card__title card--space-between">
<header className="card__header card__header--flat">
<h2 className="card__title">
{__('Transaction History')}
<RefreshTransactionButton />
</div>
</h2>
</header>
{fetchingTransactions && !transactions.length ? (
<div className="card__content">
<BusyIndicator message={__('Loading transactions')} />

3
src/renderer/redux/actions/publish.js
View file

@ -119,8 +119,7 @@ export const doUploadThumbnail = (filePath: string, nsfw: boolean) => (
body: data,
})
.then(response => response.json())
.then(
json =>
.then(json =>
json.success
? dispatch({
type: ACTIONS.UPDATE_PUBLISH_FORM,

3
src/renderer/redux/reducers/subscriptions.js
View file

@ -66,8 +66,7 @@ export default handleActions(
action: SetSubscriptionLatest
): SubscriptionState => ({
...state,
subscriptions: state.subscriptions.map(
subscription =>
subscriptions: state.subscriptions.map(subscription =>
subscription.channelName === action.data.subscription.channelName
? { ...subscription, latest: action.data.uri }
: subscription

56
src/renderer/redux/selectors/app.js
View file

@ -4,9 +4,14 @@ import * as icons from 'constants/icons';
export const selectState = state => state.app || {};
export const selectPlatform = createSelector(selectState, state => state.platform);
export const selectPlatform = createSelector(
selectState,
state => state.platform
);
export const selectUpdateUrl = createSelector(selectPlatform, platform => {
export const selectUpdateUrl = createSelector(
selectPlatform,
platform => {
switch (platform) {
case 'darwin':
return 'https://lbry.io/get/lbry.dmg';
@ -17,7 +22,8 @@ export const selectUpdateUrl = createSelector(selectPlatform, platform => {
default:
throw Error('Unknown platform');
}
});
}
);
export const selectHasClickedComment = createSelector(
selectState,
@ -48,18 +54,30 @@ export const selectUpgradeFilename = createSelector(
}
);
export const selectDownloadProgress = createSelector(selectState, state => state.downloadProgress);
export const selectDownloadProgress = createSelector(
selectState,
state => state.downloadProgress
);
export const selectDownloadComplete = createSelector(
selectState,
state => state.upgradeDownloadCompleted
);
export const selectIsUpgradeSkipped = createSelector(selectState, state => state.isUpgradeSkipped);
export const selectIsUpgradeSkipped = createSelector(
selectState,
state => state.isUpgradeSkipped
);
export const selectUpgradeDownloadPath = createSelector(selectState, state => state.downloadPath);
export const selectUpgradeDownloadPath = createSelector(
selectState,
state => state.downloadPath
);
export const selectUpgradeDownloadItem = createSelector(selectState, state => state.downloadItem);
export const selectUpgradeDownloadItem = createSelector(
selectState,
state => state.downloadItem
);
export const selectAutoUpdateDownloaded = createSelector(
selectState,
@ -76,23 +94,35 @@ export const selectDaemonVersionMatched = createSelector(
state => state.daemonVersionMatched
);
export const selectSnackBar = createSelector(selectState, state => state.snackBar || {});
export const selectSnackBar = createSelector(
selectState,
state => state.snackBar || {}
);
export const selectSnackBarSnacks = createSelector(
selectSnackBar,
snackBar => snackBar.snacks || []
);
export const selectBadgeNumber = createSelector(selectState, state => state.badgeNumber);
export const selectBadgeNumber = createSelector(
selectState,
state => state.badgeNumber
);
export const selectCurrentLanguage = createSelector(
selectState,
() => app.i18n.getLocale() || 'en'
);
export const selectVolume = createSelector(selectState, state => state.volume);
export const selectVolume = createSelector(
selectState,
state => state.volume
);
export const selectUpgradeTimer = createSelector(selectState, state => state.checkUpgradeTimer);
export const selectUpgradeTimer = createSelector(
selectState,
state => state.checkUpgradeTimer
);
export const selectNavLinks = createSelector(
selectCurrentPage,
@ -253,7 +283,9 @@ export const selectNavLinks = createSelector(
}
);
export const selectModal = createSelector(selectState, state => {
export const selectModal = createSelector(
selectState,
state => {
if (!state.modal) {
return null;
}

351
src/renderer/scss/_gui.scss
View file

@ -1,351 +0,0 @@
// Generic html styles used accross the App
// component specific styling should go in the component scss file
html {
background-color: $lbry-teal-5;
font-family: 'Inter UI', sans-serif;
height: 100%;
}
body {
color: $lbry-black;
font-size: 16px;
font-weight: 400;
height: 100%;
line-height: 1.5;
overflow: hidden;
}
code {
background-color: $lbry-gray-1;
font-family: Consolas, 'Lucida Console', 'Source Sans', monospace;
font-size: 1.5em;
}
// Without this buttons do not have the app font
button {
font-family: inherit;
font-weight: inherit;
}
h1 {
// Paul - Remove this in your changes
// This should be added to the media-title (or whatever that is called)
word-break: break-word;
}
ul {
list-style-type: none;
padding: 0;
}
input {
background-color: transparent;
border-bottom: var(--input-border-size) dotted $lbry-gray-5;
color: inherit; // $lbry-black;
cursor: text;
line-height: 1;
&::placeholder {
color: inherit;
opacity: 0.3;
}
&[type='checkbox'],
&[type='file'],
&[type='radio'],
&[type='select'] {
cursor: pointer;
}
&[type='file'] {
border-bottom: none;
}
&.input-copyable {
background-color: rgba($lbry-gray-1, 0.3);
border: 1px dashed $lbry-gray-1;
color: $lbry-gray-5;
flex: 1;
padding: 10px 16px;
text-overflow: ellipsis;
}
&:not(.input-copyable):not(.wunderbar__input):not(:placeholder-shown):not(:disabled) {
&:hover {
border-color: rgba($lbry-black, 0.8);
}
border-bottom: var(--input-border-size) solid $lbry-gray-5;
}
&:disabled {
border-bottom: var(--input-border-size) solid $lbry-gray-3;
color: $lbry-gray-3;
cursor: default;
}
}
textarea {
border: 1px solid $lbry-gray-2;
font-size: 0.8em;
padding: $spacing-vertical * 1/3;
width: 100%;
}
label[for] {
cursor: pointer;
}
button + input {
margin-left: $spacing-vertical * 2/3;
}
dl {
margin: 0;
padding: 0;
overflow-x: scroll;
overflow-y: hidden;
width: 100%;
}
dt {
margin: 0;
padding: 0;
float: left;
width: 20%;
}
dd {
margin: 0;
padding: 0;
float: left;
width: 80%;
}
p:not(:first-of-type) {
margin-top: $spacing-vertical * 1/3;
}
.page {
top: var(--header-height);
left: 0;
bottom: 0;
right: 0;
background-color: mix($lbry-white, $lbry-gray-1, 70%);
display: flex;
position: absolute;
z-index: 0;
@media only screen and (min-width: $medium-breakpoint) {
grid-template-columns: var(--side-nav-width-m) auto;
}
@media only screen and (min-width: $large-breakpoint) {
grid-template-columns: var(--side-nav-width-l) auto;
}
}
// Page content
.content {
flex: 1;
overflow: auto;
}
.main {
margin: auto;
padding: $spacing-width $spacing-width;
overflow: hidden;
}
.main--contained {
margin: auto;
max-width: 1000px;
}
.main--no-padding {
padding-top: 0;
padding-right: 0;
padding-left: 0;
margin: 0;
}
.main--extra-padding {
padding-right: 100px;
padding-left: 100px;
}
.main--for-content {
display: flex;
padding: $spacing-width * 2/3;
justify-content: center;
}
.page__header {
padding: $spacing-vertical * 2/3 $spacing-vertical * 2/3 0 $spacing-vertical * 2/3;
}
.page__title {
// not currently using page titles on any page
}
.page__empty {
align-items: center;
display: flex;
flex-direction: column;
margin-top: 200px;
margin-bottom: 100px;
text-align: center;
}
// Empty pages that display columns of content
.page__empty--horizontal {
max-width: 60vw;
margin: auto;
display: flex;
flex-direction: row;
text-align: left;
justify-content: center;
}
.columns {
display: flex;
justify-content: space-between;
> * {
flex-basis: 0;
flex-grow: 1;
&:not(:first-of-type):not(:last-of-type) {
margin: 0 $spacing-vertical / 3;
}
&:first-of-type {
margin-right: $spacing-vertical / 3;
}
&:last-of-type {
margin-left: $spacing-vertical / 3;
}
}
}
// Custom text selection
*::selection {
background-color: $lbry-teal-3;
color: $lbry-white;
}
.credit-amount {
font-size: 0.9em;
white-space: nowrap;
}
.credit-amount--large {
font-size: 36px;
font-weight: 600;
}
.credit-amount--cost {
color: $lbry-gray-5;
}
.credit-amount--inherit {
background-color: inherit;
color: inherit;
font-size: inherit;
font-weight: inherit;
padding: 0;
}
.hidden {
display: none;
}
.disabled {
opacity: 0.5;
pointer-events: none;
}
.column {
display: flex;
.column__item:not(:first-child) {
padding-left: $spacing-width * 2/3;
}
}
.truncated-text {
display: -webkit-box;
overflow: hidden;
-webkit-box-orient: vertical;
}
.busy-indicator__loader {
min-width: 16px;
min-height: 8px;
margin: -1em 0;
padding: 0 30px;
background: url('../../../static/img/busy.gif') no-repeat center center;
display: inline-block;
vertical-align: middle;
&:first-child {
padding-left: 2px;
}
&:last-child {
padding-right: 2px;
}
}
.help {
color: $lbry-gray-5;
font-size: 12px;
}
.help--padded {
padding-top: $spacing-vertical * 2/3;
}
.meta {
color: $lbry-gray-5;
font-size: 0.8em;
}
.empty {
color: $lbry-gray-5;
font-style: italic;
}
.qr-code {
width: 134px;
height: 134px;
border: 3px solid $lbry-white;
&.qr-code--right-padding {
margin-right: $spacing-vertical * 2/3;
}
&.qr-code--top-padding {
margin-top: $spacing-vertical * 2/3;
}
}
.error-text {
color: $lbry-red-5;
}
.thumbnail-preview {
width: var(--thumbnail-preview-width);
height: var(--thumbnail-preview-height);
background-position: 50% 50%;
background-repeat: no-repeat;
background-size: cover;
}

97
src/renderer/scss/_reset.scss
View file

@ -1,97 +0,0 @@
* {
box-sizing: border-box;
}
body,
div,
dl,
dt,
dd,
ul,
ol,
li,
h1,
h2,
h3,
h4,
h5,
h6,
pre,
code,
form,
fieldset,
legend,
input,
select,
textarea,
p,
blockquote,
th,
td,
iframe {
margin: 0;
padding: 0;
}
:focus {
outline: 0;
}
input::-webkit-search-cancel-button {
-webkit-appearance: none; // Remove default
}
table {
border-collapse: collapse;
border-spacing: 0;
}
fieldset,
iframe,
img {
border: none;
}
h1,
h2,
h3,
h4,
h5,
h6 {
font-weight: normal;
}
ol,
ul {
list-style-position: inside;
> li {
list-style-position: inside;
}
}
input,
select,
textarea {
border: none;
font-family: inherit;
font-size: inherit;
font-weight: inherit;
}
img {
width: auto;
height: auto;
max-width: 100%;
max-height: 100%;
vertical-align: middle;
}
a {
color: inherit;
text-decoration: none;
}
button:disabled {
cursor: default;
}

58
src/renderer/scss/all.scss
View file

@ -1,10 +1,48 @@
@import '~@lbry/color/lbry-color', 'reset', 'type', 'vars', 'gui', 'component/syntax-highlighter',
'component/table', 'component/button', 'component/card', 'component/file-download',
'component/form-field', 'component/header', 'component/menu', 'component/tooltip',
'component/load-screen', 'component/channel-indicator', 'component/notice', 'component/modal',
'component/snack-bar', 'component/content', 'component/pagination', 'component/markdown-preview',
'component/markdown-editor', 'component/scrollbar', 'component/spinner', 'component/nav',
'component/file-list', 'component/file-render', 'component/search', 'component/toggle',
'component/dat-gui', 'component/item-list', 'component/time', 'component/icon',
'component/placeholder', 'component/badge', 'component/expandable', 'component/subscriptions',
'themes/dark';
@charset "utf-8";
@import '~@lbry/color/lbry-color';
// @import "~@lbry/components/sass/index";
@import 'init/vars';
@import 'init/mixins';
@import 'init/reset';
@import 'init/type';
@import 'init/gui';
@import 'component/animation';
@import 'component/badge';
@import 'component/button';
@import 'component/card';
@import 'component/channel';
@import 'component/content';
@import 'component/credit';
@import 'component/dat-gui';
@import 'component/expandable';
@import 'component/file-download';
@import 'component/file-render';
@import 'component/form-field';
@import 'component/form-row';
@import 'component/header';
@import 'component/icon';
@import 'component/item-list';
@import 'component/load-screen';
@import 'component/main';
@import 'component/markdown-editor';
@import 'component/markdown-preview';
@import 'component/media';
@import 'component/menu';
@import 'component/modal';
@import 'component/navigation';
@import 'component/notice';
@import 'component/page';
@import 'component/pagination';
@import 'component/placeholder';
@import 'component/scrollbar';
@import 'component/search';
@import 'component/snack-bar';
@import 'component/spinner';
@import 'component/subscriptions';
@import 'component/syntax-highlighter';
@import 'component/table';
@import 'component/time';
@import 'component/toggle';
@import 'component/tooltip';
@import 'component/wunderbar';

47
src/renderer/scss/component/_animation.scss Normal file
View file

@ -0,0 +1,47 @@
@keyframes expand {
0% {
margin-top: 200px;
opacity: 0;
}
100% {
margin-top: $spacing-vertical;
opacity: 1;
}
}
@keyframes loading-animation {
0% {
background-position: -500px 0;
}
100% {
background-position: 500px 0;
}
}
@keyframes pulse {
0% {
opacity: 1;
}
50% {
opacity: 0.7;
}
100% {
opacity: 1;
}
}
@keyframes sk-stretchdelay {
0%,
40%,
100% {
transform: scaleY(0.4);
}
20% {
transform: scaleY(1);
}
}

49
src/renderer/scss/component/_badge.scss
View file

@ -1,21 +1,52 @@
.badge {
border-radius: 5px;
padding: 5px;
font-weight: 800;
font-size: 0.8em;
font-weight: 600;
vertical-align: top;
white-space: nowrap;
&:not(.badge--large) {
border-radius: 0.2rem;
display: inline-block;
font-size: 0.8rem;
letter-spacing: 0.05rem;
line-height: 2;
padding-right: var(--spacing-vertical-small);
padding-left: var(--spacing-vertical-small);
}
}
.badge--alert {
background-color: $lbry-red-3;
background-color: $lbry-red-2;
color: $lbry-white;
}
.badge--cost:not(.badge--large) {
background-color: $lbry-yellow-2;
html[data-theme='dark'] & {
background-color: $lbry-yellow-3;
color: $lbry-black;
}
}
.badge--free {
background-color: $lbry-blue-2;
color: $lbry-blue-5;
html[data-theme='dark'] & {
background-color: $lbry-blue-3;
color: $lbry-black;
}
}
.badge--cost {
background-color: $lbry-yellow-3;
color: $lbry-black;
.badge--large {
font-size: 3.5rem;
line-height: 1;
}
.badge--nsfw {
background-color: $lbry-grape-2;
html[data-theme='dark'] & {
background-color: $lbry-grape-3;
color: $lbry-black;
}
}

380
src/renderer/scss/component/_button.scss
View file

@ -1,232 +1,180 @@
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn {
min-width: var(--btn-height);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
height: var(--btn-height);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
align-items: center;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: $lbry-teal-5;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
border: none;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
border-radius: var(--btn-radius);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-white;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
cursor: pointer;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
display: flex;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
fill: currentColor; // for proper icon color
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
font-size: 12px;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
justify-content: center;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
padding: 10px;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
fill: currentColor;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
position: relative;
text-decoration: none;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
transition: all var(--animation-duration) var(--animation-style);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:not(:disabled) {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn--alt {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:hover {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
text-decoration: underline;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn--constrict {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
@include constrict;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn--disabled {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
opacity: 0.3;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn--external-link,
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn--link {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
transition: color 0.2s;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:not(.btn--disabled):not(:hover) {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-teal-5;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
html[data-theme='dark'] & {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-teal-3;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:not(.btn--disabled):hover {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-teal-3;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
html[data-theme='dark'] & {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-teal-4;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn--external-link {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
font-weight: 500;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
text-align: left;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn--icon {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
width: 5rem;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
height: 5rem;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-repeat: no-repeat;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-size: 50%;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
border-radius: 50%;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-white;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
transition: background-color 0.2s;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:not(:hover) {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: rgba($lbry-black, 0.7);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
&:hover {
background-color: $lbry-green-3;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--play {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
padding-left: 0.25rem;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--view {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn__label {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
display: none;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn--inverse {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
border: 1px solid $lbry-gray-1;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
border-radius: 1rem;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: inherit;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
font-size: 1rem;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
padding: var(--spacing-vertical-miniscule) var(--spacing-vertical-medium);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
transition: background-color 0.2s;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
html[data-theme='dark'] & {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
border-color: rgba($lbry-white, 0.1);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:not(:hover) {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: transparent;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:hover {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: $lbry-gray-1;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-black;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
html[data-theme='dark'] & {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: rgba($lbry-white, 0.1);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
// TODO: Refactor to remove need for `!important`
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn__label {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
margin: 0 !important;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
svg {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
width: 1rem !important;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
height: 1rem !important;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
margin-right: var(--spacing-vertical-small);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
position: relative;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
top: 0.1rem;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
// .btn__content {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
// display: flex;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
// svg {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
// width: 1rem;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
// height: 1rem;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
// color: $lbry-gray-4;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
// margin-right: var(--spacing-vertical-small);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
// }
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
// .btn__label {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
// line-height: 1rem;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
// }
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
// }
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn--load-screen {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
border-bottom: 1px solid $lbry-white;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
display: inline-block;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:hover {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
border-bottom: 1px solid $lbry-blue-1;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-blue-1;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn--primary {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
align-self: center; // fixes buttons next to tall elements inside one with `display: flex`
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
border-radius: 1rem;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-white;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
padding: var(--spacing-vertical-miniscule) var(--spacing-vertical-medium);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
transition: background-color 0.2s;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:not(:hover) {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: $lbry-teal-5;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:hover {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: $lbry-teal-3;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
html[data-theme='dark'] & {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: $lbry-teal-4;
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:not(.btn--no-padding):not(.btn--link):not(.btn--no-style) {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn__content {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
align-items: center;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
display: flex;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
padding: 0 8px;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
&.btn--no-padding {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn__content {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
padding: 0;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
display: flex;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
align-items: center;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
// TODO: Refactor to remove need for `!important`
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn__label {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
margin: 0 !important;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
&.btn--alt {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:not(:disabled) {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: $lbry-white;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-black;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
svg {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
width: 1rem !important;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
height: 1rem !important;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
margin-right: var(--spacing-vertical-small);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
position: relative;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
top: 0.1rem;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:disabled {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: transparent;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-gray-5;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--arrow {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-black;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
width: var(--btn-arrow-width);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:disabled {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
opacity: 0.3;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--danger {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: $lbry-red-3;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--link {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
padding: 0;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
margin: 0;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: inherit;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-teal-4;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
font-size: 1em;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
border-radius: 0;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
display: inline;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
min-width: 0;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
box-shadow: none;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
text-align: left;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:disabled {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-gray-5;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:disabled {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
cursor: default;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--primary {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: rgba($lbry-black, 0.5);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:hover {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
box-shadow: none;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--external-link {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-blue-1;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--file-actions {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
width: var(--btn-height);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
height: var(--btn-height);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: $lbry-black;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
border-radius: var(--btn-radius);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-white;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
opacity: 0.8;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
padding: 10px;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--header-balance {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-teal-5;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
font-size: 14px;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
@media only screen and (min-width: $large-breakpoint) {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
font-size: 18px;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn__label--balance {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-gray-5;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:hover {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: transparent;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn__label--balance {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-teal-5;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--header-publish {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: $lbry-teal-5;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--home-nav {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: $lbry-white;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
box-shadow: none;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn__content {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
padding: 0;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--inverse {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: transparent;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
box-shadow: none;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-teal-5;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--link {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
margin: 0;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
padding: 0;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: inherit;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
border-radius: 0;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
box-shadow: none;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-teal-5;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
display: inline;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
font-size: 1em;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
min-width: 0;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
text-align: left;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
transition: none;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--no-style {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
margin: 0;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
padding: 0;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: inherit;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
border-radius: 0;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
box-shadow: none;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: inherit;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
font-size: inherit;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
font-weight: inherit;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
min-width: 0;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--secondary {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
background-color: $lbry-teal-5;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--tourniquet {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
max-width: 20vw;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
overflow: hidden;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
text-overflow: ellipsis;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
white-space: nowrap;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--uppercase {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn--uppercase {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
text-transform: uppercase;
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&.btn--load-screen {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
display: inline-block;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
border-bottom: 1px solid $lbry-white;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:hover {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-blue-1;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
border-bottom: 1px solid $lbry-blue-1;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.icon + .btn__label {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
padding-left: 5px;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn--link,
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn--no-style {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
height: auto;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn__label,
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn__content {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
padding: 0;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.icon + .btn__label,
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn__label + .icon {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
margin-left: 5px;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
.btn--uri-indicator {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
display: inline-block;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
transition: color var(--animation-duration) var(--animation-style);
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
&:hover {
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
color: $lbry-teal-4;
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
}

neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.
neb-b commented 2018-12-12 21:03:19 +01:00 (Migrated from github.com)
Review
Copy link

These should stil use the Icon component

These should stil use the `Icon` component
NetOpWibby commented 2018-12-13 23:59:42 +01:00 (Migrated from github.com)
Review
Copy link

I thought this was going to be resolved after this PR was merged?

I thought this was going to be resolved after this PR was merged?
neb-b commented 2018-12-14 00:04:53 +01:00 (Migrated from github.com)
Review
Copy link

If we are adding new icons I would prefer they are implemented using the Icon component, just so it doesn't slip through the cracks.

If we are adding new icons I would prefer they are implemented using the `Icon` component, just so it doesn't slip through the cracks.
NetOpWibby commented 2018-12-14 00:06:04 +01:00 (Migrated from github.com)
Review
Copy link

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?

We had a whole conversation about this. It'd require creating a new repo to replicate the react-feathers module. Should this be done now, or later?
neb-b commented 2018-12-14 00:10:18 +01:00 (Migrated from github.com)
Review
Copy link

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this:

// in component/common/icon

const customIcons = {
      icons.PLAY: <svg>...</svg>,
      icons.EYE: <svg>...</svg>,
      ...
    }

const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon];

Then we have all of these new custom icons in one place.

It wouldn't require a new repo, that might be a better long-term solution. This could be implemented by something like this: ``` // in component/common/icon const customIcons = { icons.PLAY: <svg>...</svg>, icons.EYE: <svg>...</svg>, ... } const Icon = customIcons[this.props.icon] || FeatherIcons[this.props.icon]; ``` Then we have all of these new custom icons in one place.
NetOpWibby commented 2018-12-14 00:11:17 +01:00 (Migrated from github.com)
Review
Copy link

I wish this was brought up when we had that conversation.

I wish this was brought up when we had that conversation.
neb-b commented 2018-12-14 00:12:23 +01:00 (Migrated from github.com)
Review
Copy link

My fault. Sorry about that, I thought we were on the same page.

My fault. Sorry about that, I thought we were on the same page.

438
src/renderer/scss/component/_card.scss
View file

@ -1,29 +1,13 @@
.card {
border-radius: var(--card-radius);
display: flex;
flex-direction: column;
margin-right: auto;
margin-left: auto;
max-width: var(--card-max-width);
user-select: text;
white-space: normal;
background-color: $lbry-white;
border: 1px solid $lbry-gray-1;
border-radius: 0.5rem;
margin-bottom: var(--spacing-vertical-large);
position: relative;
// .card-media__internal__links should always be inside a card
.card-media__internal-links {
top: $spacing-vertical * 2/3;
right: $spacing-vertical * 2/3;
position: absolute;
}
.card__media {
padding-top: var(--video-aspect-ratio);
}
// Text that is shown if a piece of content has no thumbnail
// We need to do this because the thumbnail uses padding-top: var(--video-aspect-ratio); for dynamic height
// this lets the text sit in the middle instead of the bottom
.card__media-text {
margin-top: calc(var(--video-aspect-ratio) * -1);
html[data-theme='dark'] & {
background-color: rgba($lbry-white, 0.1);
border-color: rgba($lbry-white, 0.1);
}
}
@ -36,332 +20,151 @@
cursor: pointer;
}
.card--pending {
opacity: 0.5;
}
.card--section {
margin-top: $spacing-vertical * 2/3;
padding: $spacing-vertical;
background-color: $lbry-white;
}
padding: var(--spacing-vertical-large);
.card--small {
font-size: 13px;
.card__content:not(:last-of-type) {
margin-bottom: var(--spacing-vertical-large);
}
}
.card--space-between {
display: flex;
justify-content: space-between;
@include between;
}
.card--wallet-balance {
background: url('../../../static/img/stripe-background.png') no-repeat;
background-image: url('../../../static/img/stripe-background.png');
background-repeat: no-repeat;
background-size: cover;
color: $lbry-white;
justify-content: space-between;
.card__subtitle,
.card__title {
color: $lbry-white;
}
}
.card__media {
background-color: $lbry-gray-3;
background-position: 50% 50%;
background-repeat: no-repeat;
background-size: cover;
}
.card__media--no-img {
align-items: center;
display: flex;
justify-content: center;
position: relative;
}
.card__media--nsfw {
background-color: $lbry-red-5;
}
// C A R D
// A C T I O N S
.card__actions {
display: flex;
margin-top: $spacing-vertical * 2/3;
&:not(.card__actions--vertical) {
.btn:nth-child(n + 2),
// For buttons wrapped in a tooltip
.tooltip:nth-child(n + 2) {
margin-left: $spacing-vertical / 3;
> *:not(:last-child) {
margin-right: var(--spacing-vertical-large);
}
}
}
.card__actions-bottom-corner {
bottom: $spacing-vertical;
right: $spacing-vertical;
position: absolute;
}
.card__actions-top-corner {
display: flex;
justify-content: flex-end;
}
.card__actions--between {
justify-content: space-between;
flex-wrap: wrap;
@include between;
}
.card__actions--bottom-corner {
right: 2rem;
bottom: 2rem;
position: absolute;
}
.card__actions--center {
align-items: center;
justify-content: center;
.btn {
margin: 0 $spacing-vertical / 3;
}
}
.card__actions--end {
justify-content: flex-end;
.card__actions--top-corner {
top: 0;
right: 0;
position: absolute;
}
.card__actions--no-margin {
margin-top: 0;
.card__actions--top-space {
padding-top: var(--spacing-vertical-small);
}
.card__actions--vertical {
align-items: flex-end;
flex-direction: column;
margin-top: 0;
.btn:not(:first-child) {
margin-top: $spacing-vertical * 1/3;
}
}
// C A R D
// C O N T E N T
.card__content {
margin-top: $spacing-vertical * 2/3;
}
font-size: 1.15rem;
.card__error-msg {
margin: $spacing-vertical * 1/3 0;
padding: $spacing-vertical * 1/3;
background-color: rgba($lbry-red-1, 0.3);
border-left: 2px solid $lbry-red-5;
color: $lbry-red-5;
}
.card__file-properties {
align-items: center;
color: $lbry-gray-5;
display: flex;
.icon + .icon {
margin-left: $spacing-vertical * 1/3;
p:not(:last-of-type) {
margin-bottom: var(--spacing-vertical-medium);
}
}
// How cards are displayed in lists
// C A R D
// H E A D E R
.card__header {
position: relative;
+ .card__content {
padding-top: var(--spacing-vertical-medium);
}
&:not(.card__header--flat) {
margin-bottom: var(--spacing-vertical-small);
}
}
// C A R D
// I N T E R N A L
.card__internal-links {
top: 2rem;
right: 2rem;
position: absolute;
}
// C A R D
// L I S T
.card__list {
.card {
display: inline-block;
margin-bottom: $spacing-vertical * 3/2;
vertical-align: top;
@media only screen and (max-width: $medium-breakpoint) {
width: calc((100% / 4) - (60px / 4)); // 60px === 20px margin-right * three cards
&:not(:nth-child(4n + 1)) {
margin-left: 20px;
}
}
@media only screen and (min-width: $medium-breakpoint) and (max-width: $large-breakpoint) {
width: calc((100% / 6) - (100px / 6));
&:not(:nth-child(6n + 1)) {
margin-left: 20px;
}
}
@media only screen and (min-width: $large-breakpoint) {
width: calc((100% / 8) - (140px / 8));
&:not(:nth-child(8n + 1)) {
margin-left: 20px;
}
}
}
display: grid;
grid-gap: var(--spacing-vertical-medium);
}
.card__list--recommended {
flex: 0 0 var(--recommended-content-width);
padding-left: $spacing-width;
@media (min-width: $medium-breakpoint) {
flex: 0 0 var(--recommended-content-width-medium);
}
}
.card__list--rewards {
column-count: 2;
column-gap: $spacing-vertical * 1/3;
.card {
display: inline-block;
margin: 0 0 $spacing-vertical * 1/3;
width: 100%;
}
}
// C A R D
// M E T A
.card__meta {
color: $lbry-gray-5;
font-size: 14px;
font-weight: 500;
padding-top: $spacing-vertical * 2/3;
padding-top: var(--spacing-vertical-medium);
padding-bottom: var(--spacing-vertical-medium);
}
// C A R D
// M E S S A G E
.card__message {
border-left: 0.5rem solid;
padding: var(--spacing-vertical-medium) var(--spacing-vertical-medium)
var(--spacing-vertical-medium) var(--spacing-vertical-large);
&:not(&--error):not(&--failure):not(&--success) {
background-color: rgba($lbry-teal-1, 0.1);
border-color: $lbry-teal-3;
}
}
.card__message--error {
background-color: rgba($lbry-orange-1, 0.1);
border-color: $lbry-orange-3;
}
.card__message--failure {
background-color: rgba($lbry-red-1, 0.1);
border-color: $lbry-red-3;
}
.card__message--success {
background-color: rgba($lbry-green-1, 0.1);
border-color: $lbry-green-3;
}
// C A R D
// S U B T I T L E
.card__subtitle {
color: $lbry-gray-5;
font-size: 0.9em;
padding-top: $spacing-vertical * 1/3;
font-size: 1.25rem;
margin-bottom: var(--spacing-vertical-small);
@media (min-width: $large-breakpoint) {
font-size: 1em;
}
}
.card__subtext {
font-size: 0.85em;
padding-top: $spacing-vertical * 1/3;
}
.card__subtext-title {
font-size: 1.1em;
&:not(:first-of-type) {
padding-top: $spacing-vertical * 3/2;
}
}
.card__success-msg {
margin: $spacing-vertical * 1/3 0;
padding: $spacing-vertical * 1/3;
background-color: rgba($lbry-green-1, 0.1);
border-left: 5px solid $lbry-green-5;
color: $lbry-green-5;
}
.card__title {
color: $lbry-black;
font-size: 1.5em;
padding-top: $spacing-vertical * 1/3;
@media (min-width: $large-breakpoint) {
font-size: 1.7em;
}
}
.card__title-identity-icons {
align-items: center;
align-self: flex-start;
display: flex;
}
.card__title--file-card {
// FileCard is slightly different where the title is only slightly bigger than the subtitle
// Slightly bigger than 2 lines for consistent channel placement
font-size: 1em;
height: 3.3em;
@media only screen and (min-width: $large-breakpoint) {
font-size: 1.1em;
}
}
// .card-row is used on the discover page
// It is a list of cards that extend past the right edge of the screen
// There are left/right arrows to scroll the cards and view hidden content
.card-row {
padding-top: $spacing-vertical;
white-space: nowrap;
width: 100%;
&:last-of-type {
padding-bottom: $spacing-vertical * 2/3;
}
}
.card-row__header {
display: flex;
flex-direction: row;
justify-content: space-between;
// specific padding-left styling is needed here
// this needs to be used on a page with noPadding
// doing so allows the content to scroll to the edge of the screen
padding-left: $spacing-width;
&.card-row__header--sub-component {
padding-left: 0;
}
}
.card-row__message {
padding: 0 $spacing-width;
white-space: normal;
}
.card-row__scroll-btns {
display: flex;
padding-right: $spacing-width * 1/3;
@media (min-width: $medium-breakpoint) {
padding-right: $spacing-width;
}
&.card-row__scroll-btns--sub-component {
@media (min-width: $medium-breakpoint) {
padding-right: 0;
}
}
}
.card-row__scrollhouse {
padding-top: $spacing-vertical * 2/3;
padding-bottom: $spacing-vertical * 1/6;
overflow: hidden;
.card {
display: inline-block;
overflow-y: visible;
vertical-align: top;
width: calc((100% / 4) - 34px); // 31 px to handle to padding between cards
&:not(:first-of-type) {
margin-left: 20px;
}
&:first-of-type {
margin-left: $spacing-width;
}
&:last-of-type {
margin-right: $spacing-width;
}
@media only screen and (min-width: $medium-breakpoint) {
width: calc((100% / 6) - 29px);
}
@media only screen and (min-width: $large-breakpoint) {
width: calc((100% / 8) - 27px);
}
.badge {
bottom: -0.12rem;
position: relative;
}
&.card-row__scrollhouse--sub-component {
@ -371,14 +174,27 @@
}
}
.card-row__title {
align-items: center;
display: flex;
font-size: 18px;
font-weight: 600;
line-height: 24px;
// C A R D
// T I T L E
@media only screen and (min-width: $medium-breakpoint) {
font-size: 20px;
.card__title {
font-size: 2rem;
font-weight: 600;
&:not(.card__title--flex) {
.btn {
bottom: -0.5rem;
float: right;
font-size: 1rem;
}
}
.btn {
position: relative;
}
}
.card__title--flex {
@include between;
display: flex;
}

6
src/renderer/scss/component/_channel-indicator.scss
View file

@ -1,6 +0,0 @@
.channel-name {
display: inline-flex;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}

25
src/renderer/scss/component/_channel.scss Normal file
View file

@ -0,0 +1,25 @@
.channel-info {
align-items: center;
display: flex;
justify-content: space-between;
h1 {
user-select: text;
}
}
.channel-info__actions {
display: flex;
}
.channel-info__actions__group {
@extend .media__action-group;
@extend .media__action-group--large;
}
.channel-name {
overflow: hidden;
text-align: left;
text-overflow: ellipsis;
white-space: nowrap;
}

38
src/renderer/scss/component/_content.scss
View file

@ -1,3 +1,10 @@
.content {
flex: 1 0 var(--file-page-min-width);
overflow-x: hidden;
overflow-y: auto;
position: relative;
}
.content__cover {
// Video thumbnail with play/download button
top: 0;
@ -15,6 +22,10 @@
&:not(.card__media--nsfw) {
background-color: $lbry-black;
html[data-theme='dark'] & {
background-color: rgba($lbry-white, 0.1);
}
}
&:hover {
@ -23,11 +34,13 @@
}
.content__embedded {
@include thumbnail;
align-items: center;
background-color: $lbry-black;
display: flex;
justify-content: center;
padding-top: var(--video-aspect-ratio);
margin-bottom: var(--spacing-vertical-large);
max-height: 60vh;
position: relative;
width: 100%;
@ -36,7 +49,6 @@
height: 100%;
top: 0;
left: 0;
position: absolute;
&:hover {
@ -46,21 +58,17 @@
}
.content__empty {
@include thumbnail;
align-items: center;
background-color: $lbry-black;
color: $lbry-white;
display: flex;
justify-content: center;
padding-top: var(--video-aspect-ratio);
width: 100%;
}
.card__media-text {
margin-top: calc(-1 * var(--video-aspect-ratio));
}
&.content__empty--nsfw {
.content__empty--nsfw {
background-color: $lbry-grape-3;
}
}
.content__loading {
@ -72,15 +80,14 @@
display: flex;
flex-direction: column;
justify-content: center;
padding: 0 20px;
padding: 0 var(--spacing-vertical-large);
}
.content__loading-text {
color: $lbry-white;
}
.content__view,
.content__view--container {
.content__view {
width: 100%;
height: 100%;
top: 0;
@ -90,17 +97,10 @@
display: flex;
justify-content: center;
position: absolute;
}
.content__view--container {
iframe {
width: 100%;
height: 100%;
background-color: $lbry-white;
}
}
.content__wrapper {
flex: 1 0 var(--file-page-min-width);
max-width: var(--card-max-width);
}

17
src/renderer/scss/component/_credit.scss Normal file
View file

@ -0,0 +1,17 @@
.credit-amount {
font-size: 0.8rem;
white-space: nowrap;
}
.credit-amount--inherit {
background-color: inherit;
color: inherit;
font-size: inherit;
font-weight: inherit;
padding: 0;
}
.credit-amount--large {
font-size: 36px;
font-weight: 600;
}

41
src/renderer/scss/component/_expandable.scss
View file

@ -1,28 +1,47 @@
.expandable {
border-bottom: var(--input-border-size) solid $lbry-gray-3;
padding-bottom: $spacing-vertical * 1/3;
border-bottom: 1px solid $lbry-gray-1;
margin-bottom: var(--spacing-vertical-medium);
padding-bottom: var(--spacing-vertical-medium);
html[data-theme='dark'] & {
border-color: rgba($lbry-gray-5, 0.2);
}
}
.expandable__button {
font-size: 1.25rem;
}
.expandable--closed,
.expandable--open {
max-height: 100%;
margin-bottom: var(--spacing-vertical-small);
}
.expandable--closed {
max-height: 10em;
position: relative;
max-height: 10rem;
overflow: hidden;
}
position: relative;
.expandable--closed::after {
content: '';
&::after {
width: 100%;
height: 20%;
position: absolute;
left: 0;
height: 100%;
bottom: 0;
left: 0;
background-image: linear-gradient(
to bottom,
transparent 0%,
mix($lbry-white, $lbry-gray-1, 70%) 90%
);
content: '';
position: absolute;
html[data-theme='dark'] & {
background-image: linear-gradient(to bottom, transparent 0%, $lbry-black 90%);
}
}
}
.expandable--open {
max-height: 100%;
}

2
src/renderer/scss/component/_file-download.scss
View file

@ -1,4 +1,4 @@
.file-download {
align-self: center;
font-size: 0.8em;
font-size: 0.8rem;
}

42
src/renderer/scss/component/_file-render.scss
View file

@ -1,24 +1,31 @@
.file-render {
width: 100%;
height: 100%;
top: 0;
left: 0;
bottom: 0;
right: 0;
margin: auto;
overflow: hidden;
position: absolute;
z-index: 1;
html[data-theme='dark'] & {
border: 1px solid rgba($lbry-gray-1, 0.3);
}
}
.file-render__viewer,
.document-viewer {
background-color: $lbry-white;
html[data-theme='dark'] & {
background-color: transparent;
}
}
.file-render__viewer {
width: 100%;
height: 100%;
background-color: $lbry-black;
margin: 0;
iframe,
webview {
width: 100%;
@ -27,14 +34,12 @@
}
.document-viewer {
background-color: $lbry-white;
font-size: calc(var(--font-size-subtext-multiple) * 1em);
overflow: auto;
.markdown-preview {
height: 100%;
overflow: auto;
padding: $spacing-vertical $spacing-width;
padding: var(--spacing-vertical-large);
}
}
@ -49,39 +54,30 @@
.code-viewer .CodeMirror {
width: 100%;
height: 100%;
margin: 0;
padding: 0;
min-height: 100px;
// Block native text selection
user-select: none;
.cm-invalidchar {
display: none;
}
.CodeMirror .CodeMirror-lines {
// is there really a .CodeMirror inside a .CodeMirror?
padding: 4px 0;
padding: var(--spacing-vertical-small) 0;
}
.CodeMirror-code {
font-family: Menlo, Consolas, 'DejaVu Sans Mono', inconsolata, monospace;
font-size: 1em;
font-weight: 350;
letter-spacing: 0.3px;
line-height: 1.5em;
word-spacing: 1px;
@include font-mono;
letter-spacing: 0.1rem;
}
.CodeMirror-gutters {
background-color: $lbry-gray-1;
border-right: 1px solid $lbry-gray-2;
padding-right: 8px;
padding-right: var(--spacing-vertical-medium);
}
.CodeMirror-line {
padding-left: 16px;
padding-left: var(--spacing-vertical-medium);
}
.CodeMirror-linenumber {

131
src/renderer/scss/component/_form-field.scss
View file

@ -1,51 +1,12 @@
.form-row {
align-items: flex-end;
display: flex;
flex-direction: row;
&.form-row--centered {
justify-content: center;
.form-field {
&:not(:last-of-type) {
margin-bottom: var(--spacing-vertical-small);
}
&.form-row--padded {
padding-top: $spacing-vertical * 1/3;
}
&.form-row--right {
justify-content: flex-end;
}
&.form-row--stretch {
flex: 1;
}
&.form-row--vertically-centered {
align-items: center;
}
.form-field {
&:not(:first-of-type) {
padding-left: $spacing-vertical;
}
&.form-field--stretch {
width: 100%;
input {
max-width: 400px;
width: 100%;
}
}
}
input + .btn {
margin-left: $spacing-vertical * 1/3;
}
}
.form-field.form-field--disabled {
&.form-field--disabled {
opacity: 0.4;
pointer-events: none;
}
}
.form-field--SimpleMDE {
@ -54,8 +15,10 @@
}
.form-field__input {
align-items: center;
display: flex;
padding-top: $spacing-vertical / 3;
font-size: 1.25rem;
margin-bottom: var(--spacing-vertical-small);
&.form-field--auto-height {
height: auto;
@ -66,14 +29,6 @@
}
input {
&[type='checkbox'] {
margin-top: 4px;
}
&[type='radio'] {
margin-top: 2px;
}
&.paginate-channel {
width: 35px;
}
@ -84,30 +39,41 @@
}
}
.form-field__input--level {
line-height: 2;
}
.form-field__help,
.form-field__label,
.form-field__error {
font-size: 12px;
font-weight: 500;
}
// TODO: Refactor to remove need for `!important`
.form-field__error {
color: $lbry-red-3 !important;
color: $lbry-red-5 !important;
html[data-theme='dark'] & {
color: $lbry-red-2 !important;
}
}
.form-field__help {
color: $lbry-gray-5;
padding-top: $spacing-vertical * 1/3;
padding-top: var(--spacing-vertical-small);
}
.form-field__label {
color: inherit;
font-size: 1.25rem;
opacity: 0.7;
}
.form-field__prefix,
.form-field__postfix {
font-weight: 500;
// line-height: 2;
&.form-field--align-center {
align-self: center;
@ -119,34 +85,47 @@
}
.form-field__prefix {
padding-right: $spacing-vertical * 1/3;
padding-right: var(--spacing-vertical-small);
}
.form-field__postfix {
padding-left: $spacing-vertical * 1/3;
padding-left: var(--spacing-vertical-small);
}
.form-field__select-wrapper {
position: relative;
width: 20rem;
height: 3rem;
&::after {
width: 100%;
height: 100%;
top: 0;
left: 0;
// TRIANGLE_DOWN
// background-image: url("data:image/svg+xml,%3Csvg viewBox='0 0 24 24' xmlns='http://www.w3.org/2000/svg' xmlns:xlink='http://www.w3.org/1999/xlink'%3E %3Cpath d='M3 4 L21 4 12 20 3 4 Z' stroke='black' stroke-width='2' fill='black' fill-rule='evenodd' stroke-linejoin='round'/%3E %3C/svg%3E"),
// linear-gradient(to right, transparent 80%, $lbry-gray-1 85%);
background-position: 95% center, right top;
background-repeat: no-repeat;
background-size: 0.8rem, 100%;
content: '';
pointer-events: none;
position: absolute;
}
}
.form-field__select {
background-color: $lbry-gray-3;
border-radius: 8px;
color: $lbry-black;
font-size: 12px;
font-weight: 500;
height: 30px;
line-height: 30px;
min-width: 60px;
width: 100%;
height: 100%;
background-color: $lbry-gray-1;
border-radius: 0;
padding: var(--spacing-vertical-small);
-webkit-appearance: none;
&:disabled {
opacity: 0.5;
}
}
// Not sure if I like these
// Maybe this should be in gui.scss?
.input--price-amount {
width: 80px;
}
.input--address {
width: 370px;
}

49
src/renderer/scss/component/_form-row.scss Normal file
View file

@ -0,0 +1,49 @@
.form-row {
display: flex;
flex-direction: row;
&:not(&--vertically-centered) {
align-items: flex-end;
}
.form-field {
&:not(:first-of-type) {
padding-left: var(--spacing-vertical-medium);
}
&.form-field--stretch {
width: 100%;
input {
max-width: 400px;
width: 100%;
}
}
}
button + input,
input + button {
margin-left: var(--spacing-vertical-medium);
}
}
.form-row--centered {
justify-content: center;
}
.form-row--padded {
padding-top: var(--spacing-vertical-medium);
padding-bottom: var(--spacing-vertical-medium);
}
.form-row--right {
justify-content: flex-end;
}
.form-row--stretch {
flex: 1;
}
.form-row--vertically-centered {
align-items: center;
}

164
src/renderer/scss/component/_header.scss
View file

@ -4,39 +4,153 @@
align-items: center;
background-color: $lbry-white;
box-shadow: 0 1px 5px rgba($lbry-black, 0.1);
display: flex;
justify-content: space-between;
padding: 0 $spacing-width * 1/3;
position: fixed;
z-index: 1;
@media (min-width: $medium-breakpoint) {
padding: 0 $spacing-width;
}
}
.header__actions-right {
display: flex;
margin-left: auto;
.btn {
margin-left: $spacing-width * 1/3;
}
}
.header__history {
display: flex;
padding: 0 $spacing-width * 1/2;
@media only screen and (min-width: $medium-breakpoint) {
.btn {
padding: 0 $spacing-width * 1/6;
}
html[data-theme='dark'] & {
background-color: rgba($lbry-black, 0.9);
color: $lbry-white;
}
}
.header__navigation {
display: flex;
justify-content: space-between;
&:first-of-type {
html[data-theme='dark'] & {
border-color: $lbry-gray-5;
}
// Main navigation collapses into a menu button
// at smaller screen widths
@media (min-width: 601px) {
width: 250px;
}
@media (max-width: 600px) {
width: calc(var(--header-height) * 3 + 1px);
}
}
neb-b commented 2018-12-12 21:10:26 +01:00 (Migrated from github.com)
Review
Copy link

Should these be variables? If it's specific to header stuff maybe just add a comment because it's confusing from a glance.

Should these be variables? If it's specific to header stuff maybe just add a comment because it's confusing from a glance.
NetOpWibby commented 2018-12-14 23:26:22 +01:00 (Migrated from github.com)
Review
Copy link

I don't get the confusion. This is how responsive stuff works. These rules are inside a header element.

I don't get the confusion. This is how responsive stuff works. These rules are inside a header element.
neb-b commented 2018-12-14 23:37:40 +01:00 (Migrated from github.com)
Review
Copy link

If 600px is a global width that will trigger ui changes, it should be a variable. But if only the header is changing at 600px then a comment explaining that will help.

If 600px is a global width that will trigger ui changes, it should be a variable. But if only the header is changing at 600px then a comment explaining that will help.
NetOpWibby commented 2018-12-14 23:41:04 +01:00 (Migrated from github.com)
Review
Copy link

Ah gotcha. I'll add comments to all media queries then.

Ah gotcha. I'll add comments to all media queries then.
&:last-of-type {
@media (min-width: 601px) {
width: 10rem;
}
@media (max-width: 600px) {
width: var(--header-height);
}
}
}
.header__navigation-item {
width: var(--header-height);
height: var(--header-height);
background-position: center;
background-repeat: no-repeat;
background-size: 50%;
&:not(:disabled):hover {
background-color: $lbry-gray-1;
html[data-theme='dark'] & {
background-color: $lbry-gray-5;
}
}
&:disabled {
opacity: 0.3;
}
}
.header__navigation-item--back {
html[data-theme='dark'] & {
svg {
stroke: $lbry-white;
}
}
}
.header__navigation-item--forward {
html[data-theme='dark'] & {
svg {
stroke: $lbry-white;
}
}
}
.header__navigation-item--home {
html[data-theme='dark'] & {
svg {
stroke: $lbry-white;
}
}
}
.header__navigation-item--menu {
html[data-theme='dark'] & {
svg {
stroke: $lbry-white;
}
}
// This menu button does not need to be seen
// at larger screen widths
@media (min-width: 601px) {
display: none;
}
}
.header__navigation-item--publish,
.header__navigation-item--wallet {
// Publish and Wallet links are collapsed
// into a menu at smaller screen widths
@media (max-width: 600px) {
display: none;
}
}
.header__navigation-item--publish {
display: flex;
justify-content: center;
position: relative;
width: 100%;
.btn__content {
display: flex;
}
.btn__label {
line-height: 1.8;
padding-left: 0.5rem;
}
html[data-theme='dark'] & {
svg {
stroke: $lbry-white;
}
}
}
.header__navigation-item--wallet {
border-right: 1px solid $lbry-gray-1;
width: calc(100% - (var(--header-height) * 3));
html[data-theme='dark'] & {
border-color: $lbry-gray-5;
}
.btn__content {
line-height: var(--header-height);
overflow: hidden;
text-align: center;
text-overflow: ellipsis;
width: 100%;
}
}

2
src/renderer/scss/component/_icon.scss
View file

@ -2,5 +2,5 @@
// Same for prices on cards
.icon + .icon,
.credit-amount + .icon {
margin-left: $spacing-vertical * 1/3;
margin-left: var(--spacing-vertical-small);
}

12
src/renderer/scss/component/_item-list.scss
View file

@ -1,17 +1,21 @@
.item-list {
background-color: $lbry-white;
margin-top: $spacing-vertical;
padding: $spacing-vertical;
margin-top: var(--spacing-vertical-large);
padding: var(--spacing-vertical-large);
html[data-theme='dark'] & {
background-color: rgba($lbry-white, 0.1);
}
}
.item-list__item {
align-items: center;
display: flex;
padding: $spacing-vertical * 1/3;
padding: var(--spacing-vertical-small);
input,
.item-list__item--cutoff {
margin-right: $spacing-vertical;
margin-right: var(--spacing-vertical-large);
}
}

70
src/renderer/scss/component/_load-screen.scss
View file

@ -3,43 +3,65 @@
min-height: 100vh;
align-items: center;
background-color: $lbry-teal-5;
background-image: linear-gradient(to right, $lbry-teal-5, $lbry-cyan-5 100%);
background-size: cover;
color: $lbry-white;
cursor: default;
display: flex;
flex-direction: column;
justify-content: center;
text-align: center;
.spinner {
margin-right: auto;
margin-left: auto;
}
}
.load-screen__details {
font-weight: 600;
line-height: 1;
max-width: 400px;
}
.load-screen__header {
display: flex;
margin-top: 35vh;
justify-content: center;
margin-bottom: var(--spacing-vertical-medium);
}
.load-screen__help {
font-size: 1.25rem;
padding-top: var(--spacing-vertical-large);
}
.load-screen__message {
font-size: 16px;
font-weight: 800;
line-height: 1;
margin-bottom: var(--spacing-vertical-medium);
}
.load-screen__title {
font-size: 60px;
font-weight: 700;
line-height: 100px;
margin-left: 40px; // width of "beta" superscript
}
.load-screen__beta {
padding-top: 23px;
padding-left: 10px;
}
.load-screen__message {
font-size: 16px;
font-weight: 600;
line-height: 20px;
margin-top: $spacing-vertical * 2/3;
text-align: center;
}
.load-screen__details {
font-size: 12px;
line-height: 1;
max-width: 400px;
padding-top: $spacing-vertical * 2/3;
position: relative;
sup {
margin-left: -var(--spacing-vertical-tiny);
padding: var(--spacing-vertical-miniscule) var(--spacing-vertical-small);
background-color: rgba($lbry-white, 0.3);
border-radius: 0.2rem;
color: $lbry-white;
font-size: 0.6rem;
font-weight: 400;
letter-spacing: 0.1rem;
line-height: 1;
position: absolute;
text-transform: uppercase;
top: 2.15rem;
}
}
.load-screen--help {

10
src/renderer/scss/component/_main.scss Normal file
View file

@ -0,0 +1,10 @@
.main {
margin: auto;
overflow: hidden;
position: relative;
z-index: 1;
&:not(.main--no-padding) {
padding: var(--spacing-vertical-large);
}
}

7
src/renderer/scss/component/_markdown-editor.scss
View file

@ -20,6 +20,7 @@
}
.CodeMirror-selectedtext {
background-color: $lbry-teal-5 !important;
color: $lbry-white;
}
@ -85,4 +86,10 @@
.editor-statusbar {
color: rgba($lbry-black, 0.5);
font-size: 1rem;
padding: var(--spacing-vertical-medium) 0; // overriding styles from elsewhere
html[data-theme='dark'] & {
color: inherit;
}
}

88
src/renderer/scss/component/_markdown-preview.scss
View file

@ -1,7 +1,4 @@
.markdown-preview {
margin: 0;
word-break: break-all;
// Headers
h1,
h2,
@ -9,49 +6,36 @@
h4,
h5,
h6 {
font-size: inherit;
font-weight: 600;
margin: 16px 0;
}
h1 {
font-size: 1.22em;
}
h2 {
font-size: 1.14em;
}
h3 {
font-size: 1.06em;
}
h4 {
font-size: 0.92em;
}
h5 {
font-size: 0.84em;
}
h6 {
color: $lbry-gray-5;
font-size: 0.84em;
margin-bottom: var(--spacing-vertical-medium);
padding-top: var(--spacing-vertical-medium);
}
// Paragraphs
p {
font-size: 1.15rem;
margin-bottom: var(--spacing-vertical-medium);
white-space: pre-line;
svg {
width: 1rem;
height: 1rem;
margin-left: 0.2rem;
position: relative;
top: 1px;
}
}
// Strikethrough text
del {
color: $lbry-gray-5;
}
// Tables
table {
margin: 16px 0;
padding: 8px;
margin-bottom: 1.2rem;
padding: var(--spacing-vertical-medium);
background-color: $lbry-white;
tr {
@ -61,19 +45,30 @@
th:first-of-type,
td:last-of-type,
th:last-of-type {
padding: 8px;
padding: var(--spacing-vertical-medium);
}
}
}
// Image
img {
margin: 16px 0;
margin-bottom: var(--spacing-vertical-medium);
padding-top: var(--spacing-vertical-medium);
}
// Horizontal Rule
hr {
border: 1px solid $lbry-gray-2;
width: 100%;
height: 1px;
background-color: $lbry-gray-1;
margin-bottom: 2rem;
position: relative;
top: 1rem;
html[data-theme='dark'] & {
background-color: rgba($lbry-gray-5, 0.2);
}
}
// Code
@ -82,26 +77,28 @@
}
code {
margin: 16px 0;
padding: 8px;
margin-bottom: var(--spacing-vertical-medium);
padding: var(--spacing-vertical-medium);
background-color: $lbry-gray-1;
color: $lbry-gray-5;
display: block;
font-family: Consolas, 'Lucida Console', 'Source Sans', monospace;
font-size: 1em;
}
table {
@extend .table;
}
a {
color: $lbry-blue-1;
display: inline-block;
font-size: 1em;
}
// Lists
ul,
ol {
margin-bottom: 2em;
margin-bottom: var(--spacing-vertical-medium);
> li {
list-style-position: outside;
@ -113,19 +110,10 @@
}
li {
margin-left: 2em;
margin-left: var(--spacing-vertical-large);
p {
display: inline-block;
}
}
}
blockquote {
margin: 16px 0;
padding: 8px;
background-color: $lbry-gray-1;
color: $lbry-gray-5;
border-left: 2px solid $lbry-gray-5;
}

Some files were not shown because too many files have changed in this diff Show more