Discovery UI #2477
|
|
@ -119,7 +119,7 @@
|
|||
"jsmediatags": "^3.8.1",
|
||||
"json-loader": "^0.5.4",
|
||||
"lbry-format": "https://github.com/lbryio/lbry-format.git",
|
||||
"lbry-redux": "lbryio/lbry-redux#08ed1be3905896452536c92f17997bcde4533aea",
|
||||
"lbry-redux": "lbryio/lbry-redux#fceb9747e10f6f6622e34580baf12c0521616407",
|
||||
"lbryinc": "lbryio/lbryinc#43d382d9b74d396a581a74d87e4c53105e04f845",
|
||||
"lint-staged": "^7.0.2",
|
||||
"localforage": "^1.7.1",
|
||||
|
|
|
|||
|
|
@ -62,9 +62,7 @@ export default function FileList(props: Props) {
|
|||
I think using this as a flag to both trigger default behavior and as the string key for storing state is mixing purposes. Also, are passing I think using this as a flag to both trigger default behavior and as the string key for storing state is mixing purposes.
Also, are passing `header` and `defaultHeader` mutually exclusive? If so, maybe omitting `header` can trigger default behavior and we can be explicit about the key being for state storage.
Probably should just be named Probably should just be named `file_sort`.
I agree it was pretty messy. I added I added a key for every component right now. I agree it was pretty messy. I added `persistedStorageKey` and use the default header if no `header` is passed in. If no `peristedStorageKey` is passed in, it will share state with other instances of the component that don't pass it in.
I added a key for every component right now.
so if I pass nothing or false, it still persists in a global namespace? IMO make all persisting here explicit and do not persist if a value isn't passed so if I pass nothing or false, it still persists in a global namespace? IMO make all persisting here explicit and do not persist if a value isn't passed
`headerAltControls`? `headerSecondaryControls`? or same names without the word header?
Not really a fan of Sort isn't really a good name. Not really a fan of `sort`. This is the item on the right side of the header. Currently the two pages that use this are the homepage (trending/best/new) and search feedback (satisfied with results?)
Sort isn't really a good name.
I think using this as a flag to both trigger default behavior and as the string key for storing state is mixing purposes. Also, are passing I think using this as a flag to both trigger default behavior and as the string key for storing state is mixing purposes.
Also, are passing `header` and `defaultHeader` mutually exclusive? If so, maybe omitting `header` can trigger default behavior and we can be explicit about the key being for state storage.
Probably should just be named Probably should just be named `file_sort`.
I agree it was pretty messy. I added I added a key for every component right now. I agree it was pretty messy. I added `persistedStorageKey` and use the default header if no `header` is passed in. If no `peristedStorageKey` is passed in, it will share state with other instances of the component that don't pass it in.
I added a key for every component right now.
so if I pass nothing or false, it still persists in a global namespace? IMO make all persisting here explicit and do not persist if a value isn't passed so if I pass nothing or false, it still persists in a global namespace? IMO make all persisting here explicit and do not persist if a value isn't passed
`headerAltControls`? `headerSecondaryControls`? or same names without the word header?
|
||||
))}
|
||||
</ul>
|
||||
)}
|
||||
{!hasUris && !loading && (
|
||||
|
Not really a fan of Sort isn't really a good name. Not really a fan of `sort`. This is the item on the right side of the header. Currently the two pages that use this are the homepage (trending/best/new) and search feedback (satisfied with results?)
Sort isn't really a good name.
I think using this as a flag to both trigger default behavior and as the string key for storing state is mixing purposes. Also, are passing I think using this as a flag to both trigger default behavior and as the string key for storing state is mixing purposes.
Also, are passing `header` and `defaultHeader` mutually exclusive? If so, maybe omitting `header` can trigger default behavior and we can be explicit about the key being for state storage.
Probably should just be named Probably should just be named `file_sort`.
I agree it was pretty messy. I added I added a key for every component right now. I agree it was pretty messy. I added `persistedStorageKey` and use the default header if no `header` is passed in. If no `peristedStorageKey` is passed in, it will share state with other instances of the component that don't pass it in.
I added a key for every component right now.
so if I pass nothing or false, it still persists in a global namespace? IMO make all persisting here explicit and do not persist if a value isn't passed so if I pass nothing or false, it still persists in a global namespace? IMO make all persisting here explicit and do not persist if a value isn't passed
`headerAltControls`? `headerSecondaryControls`? or same names without the word header?
|
||||
<div className="main--empty">{empty || <h3 className="card__title">{__('No results')}</h3>}</div>
|
||||
|
Not really a fan of Sort isn't really a good name. Not really a fan of `sort`. This is the item on the right side of the header. Currently the two pages that use this are the homepage (trending/best/new) and search feedback (satisfied with results?)
Sort isn't really a good name.
I think using this as a flag to both trigger default behavior and as the string key for storing state is mixing purposes. Also, are passing I think using this as a flag to both trigger default behavior and as the string key for storing state is mixing purposes.
Also, are passing `header` and `defaultHeader` mutually exclusive? If so, maybe omitting `header` can trigger default behavior and we can be explicit about the key being for state storage.
Probably should just be named Probably should just be named `file_sort`.
I agree it was pretty messy. I added I added a key for every component right now. I agree it was pretty messy. I added `persistedStorageKey` and use the default header if no `header` is passed in. If no `peristedStorageKey` is passed in, it will share state with other instances of the component that don't pass it in.
I added a key for every component right now.
so if I pass nothing or false, it still persists in a global namespace? IMO make all persisting here explicit and do not persist if a value isn't passed so if I pass nothing or false, it still persists in a global namespace? IMO make all persisting here explicit and do not persist if a value isn't passed
`headerAltControls`? `headerSecondaryControls`? or same names without the word header?
|
||||
)}
|
||||
|
Not really a fan of Sort isn't really a good name. Not really a fan of `sort`. This is the item on the right side of the header. Currently the two pages that use this are the homepage (trending/best/new) and search feedback (satisfied with results?)
Sort isn't really a good name.
I think using this as a flag to both trigger default behavior and as the string key for storing state is mixing purposes. Also, are passing I think using this as a flag to both trigger default behavior and as the string key for storing state is mixing purposes.
Also, are passing `header` and `defaultHeader` mutually exclusive? If so, maybe omitting `header` can trigger default behavior and we can be explicit about the key being for state storage.
Probably should just be named Probably should just be named `file_sort`.
I agree it was pretty messy. I added I added a key for every component right now. I agree it was pretty messy. I added `persistedStorageKey` and use the default header if no `header` is passed in. If no `peristedStorageKey` is passed in, it will share state with other instances of the component that don't pass it in.
I added a key for every component right now.
so if I pass nothing or false, it still persists in a global namespace? IMO make all persisting here explicit and do not persist if a value isn't passed so if I pass nothing or false, it still persists in a global namespace? IMO make all persisting here explicit and do not persist if a value isn't passed
`headerAltControls`? `headerSecondaryControls`? or same names without the word header?
|
||||
{!hasUris && !loading && <h2 className="main--empty empty">{empty || __('No results')}</h2>}
|
||||
|
Not really a fan of Sort isn't really a good name. Not really a fan of `sort`. This is the item on the right side of the header. Currently the two pages that use this are the homepage (trending/best/new) and search feedback (satisfied with results?)
Sort isn't really a good name.
I think using this as a flag to both trigger default behavior and as the string key for storing state is mixing purposes. Also, are passing I think using this as a flag to both trigger default behavior and as the string key for storing state is mixing purposes.
Also, are passing `header` and `defaultHeader` mutually exclusive? If so, maybe omitting `header` can trigger default behavior and we can be explicit about the key being for state storage.
Probably should just be named Probably should just be named `file_sort`.
I agree it was pretty messy. I added I added a key for every component right now. I agree it was pretty messy. I added `persistedStorageKey` and use the default header if no `header` is passed in. If no `peristedStorageKey` is passed in, it will share state with other instances of the component that don't pass it in.
I added a key for every component right now.
so if I pass nothing or false, it still persists in a global namespace? IMO make all persisting here explicit and do not persist if a value isn't passed so if I pass nothing or false, it still persists in a global namespace? IMO make all persisting here explicit and do not persist if a value isn't passed
`headerAltControls`? `headerSecondaryControls`? or same names without the word header?
|
||||
</section>
|
||||
);
|
||||
}
|
||||
|
|
|
|||
|
Not really a fan of Sort isn't really a good name. Not really a fan of `sort`. This is the item on the right side of the header. Currently the two pages that use this are the homepage (trending/best/new) and search feedback (satisfied with results?)
Sort isn't really a good name.
I think using this as a flag to both trigger default behavior and as the string key for storing state is mixing purposes. Also, are passing I think using this as a flag to both trigger default behavior and as the string key for storing state is mixing purposes.
Also, are passing `header` and `defaultHeader` mutually exclusive? If so, maybe omitting `header` can trigger default behavior and we can be explicit about the key being for state storage.
Probably should just be named Probably should just be named `file_sort`.
I agree it was pretty messy. I added I added a key for every component right now. I agree it was pretty messy. I added `persistedStorageKey` and use the default header if no `header` is passed in. If no `peristedStorageKey` is passed in, it will share state with other instances of the component that don't pass it in.
I added a key for every component right now.
so if I pass nothing or false, it still persists in a global namespace? IMO make all persisting here explicit and do not persist if a value isn't passed so if I pass nothing or false, it still persists in a global namespace? IMO make all persisting here explicit and do not persist if a value isn't passed
`headerAltControls`? `headerSecondaryControls`? or same names without the word header?
Not really a fan of Sort isn't really a good name. Not really a fan of `sort`. This is the item on the right side of the header. Currently the two pages that use this are the homepage (trending/best/new) and search feedback (satisfied with results?)
Sort isn't really a good name.
I think using this as a flag to both trigger default behavior and as the string key for storing state is mixing purposes. Also, are passing I think using this as a flag to both trigger default behavior and as the string key for storing state is mixing purposes.
Also, are passing `header` and `defaultHeader` mutually exclusive? If so, maybe omitting `header` can trigger default behavior and we can be explicit about the key being for state storage.
Probably should just be named Probably should just be named `file_sort`.
I agree it was pretty messy. I added I added a key for every component right now. I agree it was pretty messy. I added `persistedStorageKey` and use the default header if no `header` is passed in. If no `peristedStorageKey` is passed in, it will share state with other instances of the component that don't pass it in.
I added a key for every component right now.
so if I pass nothing or false, it still persists in a global namespace? IMO make all persisting here explicit and do not persist if a value isn't passed so if I pass nothing or false, it still persists in a global namespace? IMO make all persisting here explicit and do not persist if a value isn't passed
`headerAltControls`? `headerSecondaryControls`? or same names without the word header?
|
||||
|
|
@ -6588,9 +6588,9 @@ lazy-val@^1.0.3, lazy-val@^1.0.4:
|
|||
yargs "^13.2.2"
|
||||
zstd-codec "^0.1.1"
|
||||
|
||||
lbry-redux@lbryio/lbry-redux#08ed1be3905896452536c92f17997bcde4533aea:
|
||||
lbry-redux@lbryio/lbry-redux#fceb9747e10f6f6622e34580baf12c0521616407:
|
||||
version "0.0.1"
|
||||
resolved "https://codeload.github.com/lbryio/lbry-redux/tar.gz/08ed1be3905896452536c92f17997bcde4533aea"
|
||||
resolved "https://codeload.github.com/lbryio/lbry-redux/tar.gz/fceb9747e10f6f6622e34580baf12c0521616407"
|
||||
dependencies:
|
||||
proxy-polyfill "0.1.6"
|
||||
reselect "^3.0.0"
|
||||
|
|
|
|||
Not really a fan of
sort. This is the item on the right side of the header. Currently the two pages that use this are the homepage (trending/best/new) and search feedback (satisfied with results?)Sort isn't really a good name.