From c7eff6883f7969701d8ca7827b0f396d3bed0e5b Mon Sep 17 00:00:00 2001
From: zxawry <zxawry@gmail.com>
Date: Sun, 12 May 2019 15:46:14 +0100
Subject: [PATCH 1/3] show warning when opening external files and links

---
 src/ui/component/externalLink/view.jsx      |  2 +-
 src/ui/component/fileDownloadLink/index.js  |  4 +-
 src/ui/component/fileDownloadLink/view.jsx  | 24 ++++++----
 src/ui/constants/modal_types.js             |  2 +-
 src/ui/modal/modalOpenExternalLink/index.js | 12 -----
 src/ui/modal/modalOpenExternalLink/view.jsx | 52 ---------------------
 src/ui/modal/modalRouter/view.jsx           |  6 +--
 7 files changed, 21 insertions(+), 81 deletions(-)
 delete mode 100644 src/ui/modal/modalOpenExternalLink/index.js
 delete mode 100644 src/ui/modal/modalOpenExternalLink/view.jsx

diff --git a/src/ui/component/externalLink/view.jsx b/src/ui/component/externalLink/view.jsx
index 95dd429b0..ccab6ad27 100644
--- a/src/ui/component/externalLink/view.jsx
+++ b/src/ui/component/externalLink/view.jsx
@@ -37,7 +37,7 @@ class ExternalLink extends React.PureComponent<Props> {
           title={title || href}
           label={children}
           className="button--external-link"
-          onClick={() => openModal(MODALS.CONFIRM_EXTERNAL_LINK, { uri: href })}
+          onClick={() => openModal(MODALS.CONFIRM_EXTERNAL_RESOURCE, { uri: href })}
         />
       );
     }
diff --git a/src/ui/component/fileDownloadLink/index.js b/src/ui/component/fileDownloadLink/index.js
index 50519c69b..b511885bc 100644
--- a/src/ui/component/fileDownloadLink/index.js
+++ b/src/ui/component/fileDownloadLink/index.js
@@ -6,7 +6,7 @@ import {
   makeSelectClaimForUri,
 } from 'lbry-redux';
 import { makeSelectCostInfoForUri } from 'lbryinc';
-import { doOpenFileInShell } from 'redux/actions/file';
+import { doOpenModal } from 'redux/actions/app';
 import { doPurchaseUri, doStartDownload, doSetPlayingUri } from 'redux/actions/content';
 import FileDownloadLink from './view';
 
@@ -20,7 +20,7 @@ const select = (state, props) => ({
 });
 
 const perform = dispatch => ({
-  openInShell: path => dispatch(doOpenFileInShell(path)),
+  openModal: (modal, props) => dispatch(doOpenModal(modal, props)),
   purchaseUri: uri => dispatch(doPurchaseUri(uri)),
   restartDownload: (uri, outpoint) => dispatch(doStartDownload(uri, outpoint)),
   pause: () => dispatch(doSetPlayingUri(null)),
diff --git a/src/ui/component/fileDownloadLink/view.jsx b/src/ui/component/fileDownloadLink/view.jsx
index 9ac82ba80..0d3178390 100644
--- a/src/ui/component/fileDownloadLink/view.jsx
+++ b/src/ui/component/fileDownloadLink/view.jsx
@@ -1,5 +1,6 @@
 // @flow
 import * as ICONS from 'constants/icons';
+import * as MODALS from 'constants/modal_types';
 import React from 'react';
 import Button from 'component/button';
 import ToolTip from 'component/common/tooltip';
@@ -20,7 +21,7 @@ type Props = {
   loading: boolean,
   costInfo: ?{},
   restartDownload: (string, number) => void,
-  openInShell: string => void,
+  openModal: (id: string, { path: string }) => void,
   purchaseUri: string => void,
   pause: () => void,
 };
@@ -43,14 +44,7 @@ class FileDownloadLink extends React.PureComponent<Props> {
   uri: ?string;
 
   render() {
-    const { fileInfo, downloading, uri, openInShell, purchaseUri, costInfo, loading, pause, claim } = this.props;
-
-    const openFile = () => {
-      if (fileInfo) {
-        openInShell(fileInfo.download_path);
-        pause();
-      }
-    };
+    const { fileInfo, downloading, uri, openModal, purchaseUri, costInfo, loading, pause, claim } = this.props;
 
     if (loading || downloading) {
       const progress = fileInfo && fileInfo.written_bytes ? (fileInfo.written_bytes / fileInfo.total_bytes) * 100 : 0;
@@ -83,7 +77,17 @@ class FileDownloadLink extends React.PureComponent<Props> {
     } else if (fileInfo && fileInfo.download_path) {
       return (
         <ToolTip onComponent body={__('Open file')}>
-          <Button button="alt" iconColor="green" icon={ICONS.EXTERNAL} onClick={() => openFile()} />
+          <Button
+            button="alt"
+            iconColor="green"
+            icon={ICONS.EXTERNAL}
+            onClick={
+              () => {
+                pause();
+                openModal(MODALS.CONFIRM_EXTERNAL_RESOURCE, { path: fileInfo.download_path });
+              }
+            }
+          />
         </ToolTip>
       );
     }
diff --git a/src/ui/constants/modal_types.js b/src/ui/constants/modal_types.js
index 14eb7429d..533b0d5fa 100644
--- a/src/ui/constants/modal_types.js
+++ b/src/ui/constants/modal_types.js
@@ -1,5 +1,5 @@
 export const CONFIRM_FILE_REMOVE = 'confirm_file_remove';
-export const CONFIRM_EXTERNAL_LINK = 'confirm_external_link';
+export const CONFIRM_EXTERNAL_RESOURCE = 'confirm_external_resource';
 export const INCOMPATIBLE_DAEMON = 'incompatible_daemon';
 export const FILE_TIMEOUT = 'file_timeout';
 export const DOWNLOADING = 'downloading';
diff --git a/src/ui/modal/modalOpenExternalLink/index.js b/src/ui/modal/modalOpenExternalLink/index.js
deleted file mode 100644
index 4620c4db2..000000000
--- a/src/ui/modal/modalOpenExternalLink/index.js
+++ /dev/null
@@ -1,12 +0,0 @@
-import { connect } from 'react-redux';
-import { doHideModal } from 'redux/actions/app';
-import ModalOpenExternalLink from './view';
-
-const perform = dispatch => ({
-  closeModal: () => dispatch(doHideModal()),
-});
-
-export default connect(
-  null,
-  perform
-)(ModalOpenExternalLink);
diff --git a/src/ui/modal/modalOpenExternalLink/view.jsx b/src/ui/modal/modalOpenExternalLink/view.jsx
deleted file mode 100644
index 006e708db..000000000
--- a/src/ui/modal/modalOpenExternalLink/view.jsx
+++ /dev/null
@@ -1,52 +0,0 @@
-// @flow
-import React from 'react';
-import { Modal } from 'modal/modal';
-import { formatLbryUriForWeb } from 'util/uri';
-// @if TARGET='app'
-import { shell } from 'electron';
-// @endif
-
-type Props = {
-  uri: string,
-  closeModal: () => void,
-};
-
-class ModalOpenExternalLink extends React.PureComponent<Props> {
-  openExternalLink() {
-    const { uri, closeModal } = this.props;
-    // @if TARGET='app'
-    const { openExternal } = shell;
-    if (uri) {
-      openExternal(uri);
-    }
-    // @endif
-    // @if TARGET='web'
-    window.open(uri);
-    // @endif
-
-    closeModal();
-  }
-
-  render() {
-    const { uri, closeModal } = this.props;
-    return (
-      <Modal
-        isOpen
-        title={__('Warning!')}
-        contentLabel={__('Confirm External Link')}
-        type="confirm"
-        confirmButtonLabel={__('Continue')}
-        onConfirmed={() => this.openExternalLink()}
-        onAborted={closeModal}
-      >
-        <section className="card__content">
-          <p>{__('This link leads to an external website.')}</p>
-          <blockquote>{uri}</blockquote>
-          <p>{__('LBRY Inc is not responsible for its content, click continue to proceed at your own risk.')}</p>
-        </section>
-      </Modal>
-    );
-  }
-}
-
-export default ModalOpenExternalLink;
diff --git a/src/ui/modal/modalRouter/view.jsx b/src/ui/modal/modalRouter/view.jsx
index 90e524f36..1c8d7fc13 100644
--- a/src/ui/modal/modalRouter/view.jsx
+++ b/src/ui/modal/modalRouter/view.jsx
@@ -21,7 +21,7 @@ import ModalConfirmTransaction from 'modal/modalConfirmTransaction';
 import ModalSocialShare from 'modal/modalSocialShare';
 import ModalSendTip from 'modal/modalSendTip';
 import ModalPublish from 'modal/modalPublish';
-import ModalOpenExternalLink from 'modal/modalOpenExternalLink';
+import ModalOpenExternalResource from 'modal/modalOpenExternalResource';
 import ModalConfirmThumbnailUpload from 'modal/modalConfirmThumbnailUpload';
 import ModalWalletEncrypt from 'modal/modalWalletEncrypt';
 import ModalWalletDecrypt from 'modal/modalWalletDecrypt';
@@ -85,8 +85,8 @@ function ModalRouter(props: Props) {
       return <ModalSocialShare {...modalProps} />;
     case MODALS.PUBLISH:
       return <ModalPublish {...modalProps} />;
-    case MODALS.CONFIRM_EXTERNAL_LINK:
-      return <ModalOpenExternalLink {...modalProps} />;
+    case MODALS.CONFIRM_EXTERNAL_RESOURCE:
+      return <ModalOpenExternalResource {...modalProps} />;
     case MODALS.CONFIRM_TRANSACTION:
       return <ModalConfirmTransaction {...modalProps} />;
     case MODALS.CONFIRM_THUMBNAIL_UPLOAD:
-- 
2.45.2


From a83e06d6228c5286f013a84d1e5965c9594c391f Mon Sep 17 00:00:00 2001
From: zxawry <zxawry@gmail.com>
Date: Sun, 12 May 2019 15:51:22 +0100
Subject: [PATCH 2/3] rename link to resource

---
 .../modal/modalOpenExternalResource/index.js  | 12 +++
 .../modal/modalOpenExternalResource/view.jsx  | 74 +++++++++++++++++++
 2 files changed, 86 insertions(+)
 create mode 100644 src/ui/modal/modalOpenExternalResource/index.js
 create mode 100644 src/ui/modal/modalOpenExternalResource/view.jsx

diff --git a/src/ui/modal/modalOpenExternalResource/index.js b/src/ui/modal/modalOpenExternalResource/index.js
new file mode 100644
index 000000000..b72a7a7ce
--- /dev/null
+++ b/src/ui/modal/modalOpenExternalResource/index.js
@@ -0,0 +1,12 @@
+import { connect } from 'react-redux';
+import { doHideModal } from 'redux/actions/app';
+import ModalOpenExternalResource from './view';
+
+const perform = dispatch => ({
+  closeModal: () => dispatch(doHideModal()),
+});
+
+export default connect(
+  null,
+  perform
+)(ModalOpenExternalResource);
diff --git a/src/ui/modal/modalOpenExternalResource/view.jsx b/src/ui/modal/modalOpenExternalResource/view.jsx
new file mode 100644
index 000000000..9f3c52bc1
--- /dev/null
+++ b/src/ui/modal/modalOpenExternalResource/view.jsx
@@ -0,0 +1,74 @@
+// @flow
+import React from 'react';
+import { Modal } from 'modal/modal';
+import { formatLbryUriForWeb } from 'util/uri';
+// @if TARGET='app'
+import { shell } from 'electron';
+// @endif
+
+type Props = {
+  uri: string,
+  path: string,
+  closeModal: () => void,
+};
+
+class ModalOpenExternalResource extends React.PureComponent<Props> {
+  openExternalResource() {
+    const { uri, path, closeModal } = this.props;
+    // @if TARGET='app'
+    const { openExternal, openItem, showItemInFolder } = shell;
+    if (uri) {
+      openExternal(uri);
+    } else if(path) {
+      const success = openItem(path);
+      if (!success) {
+        showItemInFolder(path);
+      }
+    }
+    // @endif
+    // @if TARGET='web'
+    if (uri) {
+      window.open(uri);
+    } else if (path) {
+      // Converintg path into uri, like "file://path/to/file"
+      let _uri = path.replace(/\\/g, '/');
+      // Windows drive letter must be prefixed with a slash
+      if (_uri[0] !== '/') {
+        _uri = `/${_uri}`;
+      }
+      _uri = encodeURI(`file://${_uri}`).replace(/[?#]/g, encodeURIComponent);
+      window.open(_uri);
+    }
+    // @endif
+
+    closeModal();
+  }
+
+  render() {
+    const { uri, path, closeModal } = this.props;
+    return (
+      <Modal
+        isOpen
+        title={__('Warning!')}
+        contentLabel={__('Confirm External Resource')}
+        type="confirm"
+        confirmButtonLabel={__('Continue')}
+        onConfirmed={() => this.openExternalResource()}
+        onAborted={closeModal}
+      >
+        <section className="card__content">
+          <p>
+            {
+              (uri && __('This link leads to an external website.')) ||
+              (path && __('This file has been shared with you by other people.'))
+            }
+          </p>
+          <blockquote>{uri || path}</blockquote>
+          <p>{__('LBRY Inc is not responsible for its content, click continue to proceed at your own risk.')}</p>
+        </section>
+      </Modal>
+    );
+  }
+}
+
+export default ModalOpenExternalResource;
-- 
2.45.2


From 75a6e8babad05e0322fcbb913d182f6b7e4a046c Mon Sep 17 00:00:00 2001
From: zxawry <zxawry@gmail.com>
Date: Sun, 12 May 2019 18:59:57 +0100
Subject: [PATCH 3/3] prettier

---
 src/ui/component/fileDownloadLink/view.jsx      | 10 ++++------
 src/ui/modal/modalOpenExternalResource/view.jsx |  8 +++-----
 2 files changed, 7 insertions(+), 11 deletions(-)

diff --git a/src/ui/component/fileDownloadLink/view.jsx b/src/ui/component/fileDownloadLink/view.jsx
index 0d3178390..93f4395e9 100644
--- a/src/ui/component/fileDownloadLink/view.jsx
+++ b/src/ui/component/fileDownloadLink/view.jsx
@@ -81,12 +81,10 @@ class FileDownloadLink extends React.PureComponent<Props> {
             button="alt"
             iconColor="green"
             icon={ICONS.EXTERNAL}
-            onClick={
-              () => {
-                pause();
-                openModal(MODALS.CONFIRM_EXTERNAL_RESOURCE, { path: fileInfo.download_path });
-              }
-            }
+            onClick={() => {
+              pause();
+              openModal(MODALS.CONFIRM_EXTERNAL_RESOURCE, { path: fileInfo.download_path });
+            }}
           />
         </ToolTip>
       );
diff --git a/src/ui/modal/modalOpenExternalResource/view.jsx b/src/ui/modal/modalOpenExternalResource/view.jsx
index 9f3c52bc1..d1ba71ac0 100644
--- a/src/ui/modal/modalOpenExternalResource/view.jsx
+++ b/src/ui/modal/modalOpenExternalResource/view.jsx
@@ -19,7 +19,7 @@ class ModalOpenExternalResource extends React.PureComponent<Props> {
     const { openExternal, openItem, showItemInFolder } = shell;
     if (uri) {
       openExternal(uri);
-    } else if(path) {
+    } else if (path) {
       const success = openItem(path);
       if (!success) {
         showItemInFolder(path);
@@ -58,10 +58,8 @@ class ModalOpenExternalResource extends React.PureComponent<Props> {
       >
         <section className="card__content">
           <p>
-            {
-              (uri && __('This link leads to an external website.')) ||
-              (path && __('This file has been shared with you by other people.'))
-            }
+            {(uri && __('This link leads to an external website.')) ||
+              (path && __('This file has been shared with you by other people.'))}
           </p>
           <blockquote>{uri || path}</blockquote>
           <p>{__('LBRY Inc is not responsible for its content, click continue to proceed at your own risk.')}</p>
-- 
2.45.2