From 63daf5d282fdf417e62be2c3a8b577b7cf93157f Mon Sep 17 00:00:00 2001 From: 6ea86b96 <6ea86b96@gmail.com> Date: Wed, 19 Jul 2017 12:35:32 +0700 Subject: [PATCH 1/3] Use toQueryString from util/query_params in app actions --- ui/js/actions/app.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/ui/js/actions/app.js b/ui/js/actions/app.js index c29520720..d5014d9ad 100644 --- a/ui/js/actions/app.js +++ b/ui/js/actions/app.js @@ -13,6 +13,7 @@ import { doSearch } from "actions/search"; import { doFetchDaemonSettings } from "actions/settings"; import { doAuthenticate } from "actions/user"; import { doFileList } from "actions/file_info"; +import { toQueryString } from "util/query_params"; const { remote, ipcRenderer, shell } = require("electron"); const path = require("path"); @@ -20,14 +21,10 @@ const { download } = remote.require("electron-dl"); const fs = remote.require("fs"); const { lbrySettings: config } = require("../../../app/package.json"); -const queryStringFromParams = params => { - return Object.keys(params).map(key => `${key}=${params[key]}`).join("&"); -}; - export function doNavigate(path, params = {}) { return function(dispatch, getState) { let url = path; - if (params) url = `${url}?${queryStringFromParams(params)}`; + if (params) url = `${url}?${toQueryString(params)}`; dispatch(doChangePath(url)); -- 2.45.2 From 76a99cc576605d11ce6eb8bb8b591687857553e1 Mon Sep 17 00:00:00 2001 From: 6ea86b96 <6ea86b96@gmail.com> Date: Wed, 19 Jul 2017 13:12:01 +0700 Subject: [PATCH 2/3] Add a loading file info message. --- ui/js/component/fileActions/view.jsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/js/component/fileActions/view.jsx b/ui/js/component/fileActions/view.jsx index 53188a1f5..64fb859db 100644 --- a/ui/js/component/fileActions/view.jsx +++ b/ui/js/component/fileActions/view.jsx @@ -142,6 +142,8 @@ class FileActions extends React.PureComponent { onClick={() => openInShell(fileInfo)} /> ); + } else if (!fileInfo) { + content = ; } else { console.log("handle this case of file action props?"); } -- 2.45.2 From c8990a0f797e1abc91d628d1adea6a56ac154ccd Mon Sep 17 00:00:00 2001 From: 6ea86b96 <6ea86b96@gmail.com> Date: Fri, 21 Jul 2017 16:04:36 +0700 Subject: [PATCH 3/3] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3269d2934..c35165bef 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ Web UI version numbers should always match the corresponding version of LBRY App * Added transition to card hovers to smooth animation * Support markdown makeup in claim description * Replaced free speech flag (used when image is missing) with labeled color tiles + * Added a loading message to file actions ### Changed * Publishes now uses claims rather than files -- 2.45.2