From 24cd2c5978364ac41f50b9c4b335a453ffb30a02 Mon Sep 17 00:00:00 2001
From: infinite-persistence <inf.persistence@gmail.com>
Date: Thu, 30 Sep 2021 21:57:16 +0800
Subject: [PATCH] Add favicon for Google Search results

- A side-quest from "7166 improve search metadata".
- The favicon must be from the same domain as the homepage, so the CDN URL couldn't be used, hence the additional upload.
- The favicon also needs to be multiples of 48x48 and above.
    - Wanted to use SVG for the smallest size possible, but seems like Safari does not fully support it. Got Dejan to give me a reasonably-sized PNG.

## Reference
https://developers.google.com/search/docs/advanced/appearance/favicon-in-search#guidelines
---
 static/img/favicon-spaceman.png | Bin 0 -> 2905 bytes
 static/index-web.html           |   2 ++
 web/middleware/cache-control.js |   3 ++-
 web/webpack.config.js           |   5 +++++
 4 files changed, 9 insertions(+), 1 deletion(-)
 create mode 100644 static/img/favicon-spaceman.png

diff --git a/static/img/favicon-spaceman.png b/static/img/favicon-spaceman.png
new file mode 100644
index 0000000000000000000000000000000000000000..f6925795aa0e5549cee5be87f0854eb3bed0e520
GIT binary patch
literal 2905
zcmV-f3#RmmP)<h;3K|Lk000e1NJLTq003YB003YJ1^@s6;+S_h0000PbVXQnQ*UN;
zcVTj606}DLVr3vnZDD6+Qe|Oed2z{QJOBU+`$<GWRCwC#U0Y~e)f!$io#s+&6MfS5
z92&7u(TW#n#eyb+mx?c`O1(Uosa1SXXi62lfQ|YfqMl5_^W>#dkZOzCJP5Wbm<U>}
zD6PGqU^Ky`4=Sc<v`KRt*SE6vxMz1?)^+balm4(tm}K_s`M&?Q{`If5GNn?9q)|>T
z-O@&XTurZLdbRPFTLs_V$A9+XR`fd5e4@KIjo&kq76Lfn&edw^WBNELy=fsNQ35#V
zd3v?et10G>AEj3hy^2Ya5jz1CbhwmG4*c@4|IPmQLU!e@Us3V;?9iWN=IAh)IW}zS
zu?9f|y$Y0!lQl^I1-^y;=%QCg*#9kDcO|=WYgdr$e=Z2U=j_l3ncRJloO!*ElunJC
zdeohGPD;c;O%Nagd}c`_seibY)ZMct67(P<{@(beNsEY$2&)88@VmIXX$k`#S7u3r
z_UE16@(!~I!*K#`sjI38;K8*R=HsF5jnAz&0=!$sZh6J1B`mmN8EJTY-Rarkk!R{3
zyrGbK0x0-+$jxEyX3_Th$->)KN!@qm_z5!m>s;_<z^q!vg0q)ExTCR~Up5jG0RH0l
zA1i;x)W=5;ExdKrHK`<k0)I8v`m4ggU;M#iWWnW2h3+|hpr1_cIY_2HI^qkc<H8!Y
z-d6GY#H;)1wNDQidhaC%pFNx4{@=!@K0Us%{*kubsUd)Z-_F5rG66ocef-(IWctgW
zggzhcY*F`pmCpOJr?sr0Ve7iHh;^hiHc^_~``t_R53GGk7rU$h@DXJ9Mh&E>9~A<B
za?dx+g+zgmG!-DhO(5`2?LS)acUXpw_J_ScbACgHg8$^?yI;SNC;=3FXnl9o{{gJ}
zhi()C|8(arq0ff@hlZZFV-o}H^yXbu<0mStLRIiyk>sH6-s?6^_x<=&A_Q>oJ4DS{
zB$tQV5tXTZN9Mi&A2-0=AYPQe7=0bqp-O<L<XTr=szXB7Hu!U;gi9m;4?$DLXCu}8
z>+b)v+~0X0M#QQ>x}R4xNiab|)+YE)X(3ABI#dQwh!gJju{4ziaGB3mdEOur&J@4+
z)+zx!;C4to*xD6B+N|YAsn(X`$ZkD1q!T+9ti0%2ic#JQ0X)_0mVGD$ND)oek@G)!
zg5~V)*dU_-I_}3uk#=yb%n{%kWXYSRfdALkeq=1rc7P2xgn+K1(W>sp?E<+JIcCNz
zph)7MFcJRJj^B6Y4O~DljTW&&UH9X$z9vzH%?fCLA*{S$q~Nt`nb!NG02XmWh!r~S
z2Uh1M9++|L)Cu5K&CRy8*d0Vw1TlnVQhXecX=;=vKxgFa4gN0K%rR89fMOhOM8-|{
z2?lUux4g_W5MX;XIf?*if8B=FdIan_sDxoQMEko)#GI{=b{^;#3xKz)2S5zO06r|~
zytg(<6O8h>9{AsQ-H%(Ab1cOP;M0hmaRyUe7XU3sIvP~N39^Dkh5NO9zcY%DkWP-N
zumyCP%6dd|e1M=r0@L~(o5<q#9t|y^c?rP#FxjH-dP23|ofY|7!CCVGoT*<-X|`Xj
zK1@XCb&<1!Fwt=ag0xdBLe?caBNrs6u6sd*07owIPV(mhwBMLGQ;4DhvXIXMEN_Vd
zTI{r~$aYV_I)WxxENj0P+kBt}@TRE|)Be5bhZmJ6-x0)FgO)<OicNt<om%s}%B<T3
z?&dFV46qV-rw^#tdf;Nx20n9@ox4=0JUhdJaNY_5n#H!X30#l2=qDk0Ujq1uZTUF@
zB4XO{6T;J`A>)EJKMTlPduSR=-4)7e75M$X?tIO}t@3^ZwA*}m4U<g|_;<Z#stLHg
zf&gw3R?E%R?uPz;&}j2-lQUo7SU{WYF8~X0w~bVjU~p(bf!bpw0L3sYtf)rt4R>4<
zH|EYrxYg#Dzz7yauQcZKVKTn0#}@cy%rhewcY=w}Yypp^EZg(KwsL*VbW=obf(5jk
z13nS(AuUD;K;^S;!<woEK4$RC1hkm|9vWY5K0aaaSs>1x13oeEiIWAj&S&7+An`zd
zBH#o2+<XQ;4Wsnjd<NbT-M%Di1k^h4<?p#+HS6n1!V)kLE7e*auPP>1S87=R>NQwQ
zC$gTa76p^`a7XC0Gr0GJ7y(Xyjc$`tEx04JtzhCM4iZ>36upt?Dx2@%I|3ZArdg+7
zRhR(pa{RakJ!ohW?HjFS5;D`rhD&j2K7dD%bDEjp_QLu((;%3Hx9N_uWM=kcTpEwj
zrn{32zk8RK&NEBs%i4T+xEQvU*8_ZI>bI|AX=$2CuwntT1AiR0Vzv}`bP<RQZe&)-
zCrJWk^$bgIwlq0ytYHU}?wCUr*=)mGi}7x@k=7JdcO|7q2C}8maU)Ln%p0GxW>wWW
z)VaY=`nx7z1qS26fYTkVylD_R-r(a+)KS9r=t+~9nmcGd(VbyIc;?8EQYHkqA?t2J
zt%zns)zHESS7e}q+E*S4%LZb{*JG<llld|36?ZXA$69p*@V^B7KGq|XT4G74t$rEY
zw;HU#Krm(mlvl`<#wKR56<3(AN1%+O$rj~sEV@g(XmrhuQvcsvwg46fz8m~GFv!vm
zLWUDphcjY|i8>LU9rv*{&_fH3qLe*Oxg0(D;o)thF88*(OaQ=>YAZ)9(6s_+r#q&Y
zp5bH5r)V&iT&M>rI=^@q=?xG|t7KFJRa%`{xu6*?<np@fgUjQWZ9TH}tU>C2TFRw}
zAZF5$Z`%p<$l;O8n-GP?<rNrv2`HqA0NFLhvLu*@4GP<$6#@z1>sNQChJa(kR_|}B
z2q>}9(@yUJ5q{<9uCx#!v)@~i*_OnZ;4EyjKJ|%#v{-@R%41;pBPKVr)9)~du-#Hd
zlLUWm6QwoQKgZPCwFoyf8su4g3E)f>k_11_MgbFJod|bX2s#QSa7vON+c6j?@T@V6
z4wOuRFS<vC&R!N}rMY}*P=$0b><E;o=G;6nynZa`Xezu0pPxjBgsF5FR^U?`%7?xu
z?2kC$jE;`C6V06yq1o_}7_`LM=qox;VJh8)Qh5m29(71uWLE^e0k&6Bp15aScb`5%
z8lP*A75pSREj)4HFvpH)5#TbTQ5DUHKTo2)UDmCb8Wr>T;!z^F`H2t#l*vOxVK<e=
z=hr9J^(GrwOQU9H_V_Nqd5#$|WdR@oHSCRP8p(#HmLDZkMxQx4^f1SY7$ty{P?Q-Z
zC$+K$l}_2YYK5A<-{*ec^uvo%2m463CQ=geBt-=~KT(<3*Ck-O@5lbS4XdR$Ialfp
zO*07!TS;n<h5>%Ab)}NORc_7|AtCNm5H%gu5;MjEDwR<k@U;kVk+4yBAY=-B-7Upr
z+ao8sKmMN%_}T=x0`q#mae~FYb}Ie%&<F!xcSOsM#zIGTh$XN?q<4KaId(^PN5hs|
zx9UE-^}{@MC)T3_?tarJYR_pV4)npP8obVraRob{=GQ+D%jEg75#S=C;y7Dd%aFXw
zonn&hBISid3E(8O5!Zpvrt1674(RBXh#B}nuJyg9Zyei^=CB0R`eplZ0J_s4mOztO
zbslN%A)$rLO~-XOE~&f)y=PZ+=OiL_G!@c9nnl^}j0h2=*j+(0Sye+o5D_VsSb&e6
z02dL>+%4rvdfFfddCV$!`*v!M0H0tDBCv~W+$Z(HzoTkdv=LmZf&d>foXgfmvS<PV
z*gdB5_?jUgfRGk`wego*C4eRzZ20nlB(*$D{t;jR1zUydTSKx=00000NkvXXu0mjf
DDiek+

literal 0
HcmV?d00001

diff --git a/static/index-web.html b/static/index-web.html
index 248dcd0e6..8c599178e 100644
--- a/static/index-web.html
+++ b/static/index-web.html
@@ -13,6 +13,8 @@
     <link rel="preload" href="/public/font/v1/700.woff" as="font" type="font/woff" crossorigin />
     <link rel="preload" href="/public/font/v1/700i.woff" as="font" type="font/woff" crossorigin />
 
+    <link rel="shortcut icon" href="/public/favicon-spaceman.png">
+
     <style>
       @font-face {
         font-family: 'Inter';
diff --git a/web/middleware/cache-control.js b/web/middleware/cache-control.js
index bce66c7b4..800b2b815 100644
--- a/web/middleware/cache-control.js
+++ b/web/middleware/cache-control.js
@@ -8,7 +8,8 @@ const STATIC_ASSET_PATHS = [
   '/public/font/v1/400i.woff',
   '/public/font/v1/700.woff',
   '/public/font/v1/700i.woff',
-  '/public/favicon.png',
+  '/public/favicon.png', // LBRY icon
+  '/public/favicon-spaceman.png',
   '/public/img/busy.gif',
   '/public/img/fileRenderPlaceholder.png',
   '/public/img/gerbil-happy.png',
diff --git a/web/webpack.config.js b/web/webpack.config.js
index 7c4f4f7b6..f483c6217 100644
--- a/web/webpack.config.js
+++ b/web/webpack.config.js
@@ -50,6 +50,11 @@ const copyWebpackCommands = [
     to: `${DIST_ROOT}/public/favicon.png`,
     force: true,
   },
+  {
+    from: `${STATIC_ROOT}/img/favicon-spaceman.png`,
+    to: `${DIST_ROOT}/public/favicon-spaceman.png`,
+    force: true,
+  },
   {
     from: `${STATIC_ROOT}/img/v2-og.png`,
     to: `${DIST_ROOT}/public/v2-og.png`,
-- 
2.45.2