ece2312ec5
## Issue `normalizeUri` | `parseURI` is expensive and has been causing sluggish operations when called repeatedly or within a loop. ## Change Since I'm not confident enough to remove the call entirely from makeSelectClaimIsMine (although I've yet to find a scenario that the uri is not already normalized), we'll try caching the calls instead. ## Results - in a simple test of toggling between 2 category pages, we saved 20ms from `parseURI` calls alone. - in a test of opening all categories one time, the memory usage remained similar. This makes sense since we removed a `makeSelect*` (which creates a selector for each call + not memoizing), and replaced that with a cached selector that's actually memoizing.
31 lines
1.5 KiB
JavaScript
31 lines
1.5 KiB
JavaScript
import { connect } from 'react-redux';
|
|
import { doChannelMute } from 'redux/actions/blocked';
|
|
import { doCommentPin, doCommentModAddDelegate } from 'redux/actions/comments';
|
|
import { doOpenModal } from 'redux/actions/app';
|
|
import { doSetPlayingUri } from 'redux/actions/content';
|
|
import { doToast } from 'redux/actions/notifications';
|
|
import { selectClaimIsMineForUri, makeSelectClaimForUri } from 'redux/selectors/claims';
|
|
import { selectActiveChannelClaim } from 'redux/selectors/app';
|
|
import { selectModerationDelegatorsById } from 'redux/selectors/comments';
|
|
import { selectPlayingUri } from 'redux/selectors/content';
|
|
import CommentMenuList from './view';
|
|
|
|
const select = (state, props) => ({
|
|
claim: makeSelectClaimForUri(props.uri)(state),
|
|
claimIsMine: selectClaimIsMineForUri(state, props.uri),
|
|
activeChannelClaim: selectActiveChannelClaim(state),
|
|
playingUri: selectPlayingUri(state),
|
|
moderationDelegatorsById: selectModerationDelegatorsById(state),
|
|
});
|
|
|
|
const perform = (dispatch) => ({
|
|
openModal: (modal, props) => dispatch(doOpenModal(modal, props)),
|
|
clearPlayingUri: () => dispatch(doSetPlayingUri({ uri: null })),
|
|
muteChannel: (channelUri) => dispatch(doChannelMute(channelUri)),
|
|
pinComment: (commentId, claimId, remove) => dispatch(doCommentPin(commentId, claimId, remove)),
|
|
commentModAddDelegate: (modChanId, modChanName, creatorChannelClaim) =>
|
|
dispatch(doCommentModAddDelegate(modChanId, modChanName, creatorChannelClaim, true)),
|
|
doToast: (props) => dispatch(doToast(props)),
|
|
});
|
|
|
|
export default connect(select, perform)(CommentMenuList);
|