From cb4c6e1c4ae086e541aab998e8c5c3ae5d77cf14 Mon Sep 17 00:00:00 2001
From: Akinwale Ariwodola <akinwale@gmail.com>
Date: Tue, 3 Dec 2019 15:44:24 +0100
Subject: [PATCH 1/2] move file action buttons to large button row

---
 src/page/discover/view.js | 46 ++------------------------
 src/page/file/view.js     | 69 +++++++++++++++------------------------
 src/styles/filePage.js    |  2 +-
 3 files changed, 30 insertions(+), 87 deletions(-)

diff --git a/src/page/discover/view.js b/src/page/discover/view.js
index 96394be..cadd801 100644
--- a/src/page/discover/view.js
+++ b/src/page/discover/view.js
@@ -87,11 +87,9 @@ class DiscoverPage extends React.PureComponent {
   }
 
   onComponentFocused = () => {
-    const { fetchSubscriptions, pushDrawerStack } = this.props;
+    const { pushDrawerStack } = this.props;
     // pushDrawerStack();
-    NativeModules.Firebase.setCurrentScreen('Your tags').then(result => {
-      fetchSubscriptions();
-    });
+    NativeModules.Firebase.setCurrentScreen('Your tags');
   };
 
   handleSortByItemSelected = item => {
@@ -124,46 +122,6 @@ class DiscoverPage extends React.PureComponent {
     return null;
   };
 
-  componentDidUpdate(prevProps, prevState) {
-    const { unreadSubscriptions, enabledChannelNotifications } = this.props;
-
-    const utility = NativeModules.UtilityModule;
-    const hasUnread =
-      prevProps.unreadSubscriptions &&
-      prevProps.unreadSubscriptions.length !== unreadSubscriptions.length &&
-      unreadSubscriptions.length > 0;
-
-    if (hasUnread) {
-      unreadSubscriptions.map(({ channel, uris }) => {
-        const { claimName: channelName } = parseURI(channel);
-
-        // check if notifications are enabled for the channel
-        if (enabledChannelNotifications.includes(channelName)) {
-          uris.forEach(uri => {
-            Lbry.resolve({ urls: uri }).then(result => {
-              const sub = result[uri];
-
-              if (sub && sub.value) {
-                const { source, title, thumbnail } = sub.value;
-                const isPlayable =
-                  source && source.media_type && ['audio', 'video'].includes(source.media_type.substring(0, 5));
-                if (title) {
-                  utility.showNotificationForContent(
-                    uri,
-                    title,
-                    channelName,
-                    thumbnail ? thumbnail.url : null,
-                    isPlayable
-                  );
-                }
-              }
-            });
-          });
-        }
-      });
-    }
-  }
-
   showRatingReminder = () => {
     const { ratingReminderDisabled, ratingReminderLastShown, setClientSetting } = this.props;
 
diff --git a/src/page/file/view.js b/src/page/file/view.js
index a17f4a0..23cec0e 100644
--- a/src/page/file/view.js
+++ b/src/page/file/view.js
@@ -818,7 +818,7 @@ class FilePage extends React.PureComponent {
         <View style={filePageStyle.pageContainer}>
           {!this.state.fullscreenMode && <UriBar value={uri} navigation={navigation} />}
           {this.state.showWebView && isWebViewable && (
-            <WebView source={{ uri: localFileUri }} style={filePageStyle.viewer} />
+            <WebView allowFileAccess source={{ uri: localFileUri }} style={filePageStyle.viewer} />
           )}
 
           {this.state.showImageViewer && (
@@ -937,48 +937,8 @@ class FilePage extends React.PureComponent {
                 />
               )}
 
-              {showActions && showFileActions && (
-                <View style={filePageStyle.actions}>
-                  {showFileActions && (
-                    <View style={filePageStyle.fileActions}>
-                      {canEdit && (
-                        <Button
-                          style={[filePageStyle.actionButton, filePageStyle.editButton]}
-                          theme={'light'}
-                          icon={'edit'}
-                          text={'Edit'}
-                          onPress={this.onEditPressed}
-                        />
-                      )}
-
-                      {(completed || canEdit) && (
-                        <Button
-                          style={filePageStyle.actionButton}
-                          theme={'light'}
-                          icon={'trash-alt'}
-                          text={'Delete'}
-                          onPress={this.onDeletePressed}
-                        />
-                      )}
-                      {!completed &&
-                        fileInfo &&
-                        !fileInfo.stopped &&
-                        fileInfo.written_bytes < fileInfo.total_bytes &&
-                        !this.state.stopDownloadConfirmed && (
-                        <Button
-                          style={filePageStyle.actionButton}
-                          icon={'stop'}
-                          theme={'light'}
-                          text={'Stop Download'}
-                          onPress={this.onStopDownloadPressed}
-                        />
-                      )}
-                    </View>
-                  )}
-                </View>
-              )}
               <ScrollView
-                style={showActions ? filePageStyle.scrollContainerActions : filePageStyle.scrollContainer}
+                style={filePageStyle.scrollContainer}
                 contentContainerstyle={showActions ? null : filePageStyle.scrollContent}
                 keyboardShouldPersistTaps={'handled'}
                 ref={ref => {
@@ -1021,6 +981,31 @@ class FilePage extends React.PureComponent {
                     <Icon name={'flag'} size={20} style={filePageStyle.largeButtonIcon} />
                     <Text style={filePageStyle.largeButtonText}>Report</Text>
                   </TouchableOpacity>
+
+                  {canEdit && (
+                    <TouchableOpacity style={filePageStyle.largeButton} onPress={this.onEditPressed}>
+                      <Icon name={'edit'} size={20} style={filePageStyle.largeButtonIcon} />
+                      <Text style={filePageStyle.largeButtonText}>Edit</Text>
+                    </TouchableOpacity>
+                  )}
+
+                  {(completed || canEdit) && (
+                    <TouchableOpacity style={filePageStyle.largeButton} onPress={this.onDeletePressed}>
+                      <Icon name={'trash-alt'} size={20} style={filePageStyle.largeButtonIcon} />
+                      <Text style={filePageStyle.largeButtonText}>Delete</Text>
+                    </TouchableOpacity>
+                  )}
+
+                  {!completed &&
+                    fileInfo &&
+                    !fileInfo.stopped &&
+                    fileInfo.written_bytes < fileInfo.total_bytes &&
+                    !this.state.stopDownloadConfirmed && (
+                    <TouchableOpacity style={filePageStyle.largeButton} onPress={this.onStopDownloadPressed}>
+                      <Icon name={'stop'} size={20} style={filePageStyle.largeButtonIcon} />
+                      <Text style={filePageStyle.largeButtonText}>Stop Download</Text>
+                    </TouchableOpacity>
+                  )}
                 </View>
 
                 <View style={filePageStyle.channelRow}>
diff --git a/src/styles/filePage.js b/src/styles/filePage.js
index 77ff2a0..54f2058 100644
--- a/src/styles/filePage.js
+++ b/src/styles/filePage.js
@@ -384,7 +384,7 @@ const filePageStyle = StyleSheet.create({
   largeButton: {
     alignItems: 'center',
     justifyContent: 'center',
-    marginRight: 48,
+    marginRight: 36,
   },
   largeButtonIcon: {
     color: Colors.DescriptionGrey,
-- 
2.45.3


From f2fe275e691eed2b2d8c03427342af427934adcc Mon Sep 17 00:00:00 2001
From: Akinwale Ariwodola <akinwale@gmail.com>
Date: Fri, 6 Dec 2019 17:16:37 +0100
Subject: [PATCH 2/2] update button order

---
 src/page/file/view.js  | 68 ++++++++++++++++++++++++++++--------------
 src/styles/filePage.js |  9 ++++++
 2 files changed, 55 insertions(+), 22 deletions(-)

diff --git a/src/page/file/view.js b/src/page/file/view.js
index 23cec0e..7bfdbb6 100644
--- a/src/page/file/view.js
+++ b/src/page/file/view.js
@@ -597,6 +597,18 @@ class FilePage extends React.PureComponent {
     setPlayerVisible();
   };
 
+  onDownloadPressed = () => {
+    const { claim, costInfo, purchaseUri } = this.props;
+    this.setState(
+      {
+        downloadPressed: true,
+        autoPlayMedia: false,
+        stopDownloadConfirmed: false,
+      },
+      () => purchaseUri(claim.permanent_url, costInfo, true)
+    );
+  };
+
   onBackButtonPressed = () => {
     const { navigation, drawerStack, popDrawerStack } = this.props;
     navigateBack(navigation, drawerStack, popDrawerStack);
@@ -963,7 +975,7 @@ class FilePage extends React.PureComponent {
                 <View style={filePageStyle.largeButtonsRow}>
                   <TouchableOpacity style={filePageStyle.largeButton} onPress={this.handleSharePress}>
                     <Icon name={'share-alt'} size={20} style={filePageStyle.largeButtonIcon} />
-                    <Text style={filePageStyle.largeButtonText}>Share</Text>
+                    <Text style={filePageStyle.largeButtonText}>{__('Share')}</Text>
                   </TouchableOpacity>
 
                   <TouchableOpacity
@@ -971,39 +983,51 @@ class FilePage extends React.PureComponent {
                     onPress={() => this.setState({ showTipView: true })}
                   >
                     <Icon name={'gift'} size={20} style={filePageStyle.largeButtonIcon} />
-                    <Text style={filePageStyle.largeButtonText}>Tip</Text>
+                    <Text style={filePageStyle.largeButtonText}>{__('Tip')}</Text>
                   </TouchableOpacity>
 
-                  <TouchableOpacity
-                    style={filePageStyle.largeButton}
-                    onPress={() => Linking.openURL(`https://lbry.com/dmca/${claim.claim_id}`)}
-                  >
-                    <Icon name={'flag'} size={20} style={filePageStyle.largeButtonIcon} />
-                    <Text style={filePageStyle.largeButtonText}>Report</Text>
-                  </TouchableOpacity>
+                  <View style={filePageStyle.sharedLargeButton}>
+                    {!isPlayable && !fileInfo && (
+                      <TouchableOpacity style={filePageStyle.innerLargeButton} onPress={this.onDownloadPressed}>
+                        <Icon name={'download'} size={20} style={filePageStyle.largeButtonIcon} />
+                        <Text style={filePageStyle.largeButtonText}>{__('Download')}</Text>
+                      </TouchableOpacity>
+                    )}
+
+                    {!completed &&
+                      fileInfo &&
+                      !fileInfo.stopped &&
+                      fileInfo.written_bytes > 0 &&
+                      fileInfo.written_bytes < fileInfo.total_bytes &&
+                      !this.state.stopDownloadConfirmed && (
+                      <TouchableOpacity style={filePageStyle.innerLargeButton} onPress={this.onStopDownloadPressed}>
+                        <Icon name={'stop'} size={20} style={filePageStyle.largeButtonIcon} />
+                        <Text style={filePageStyle.largeButtonText}>{__('Stop')}</Text>
+                      </TouchableOpacity>
+                    )}
+                  </View>
+
+                  {!canEdit && (
+                    <TouchableOpacity
+                      style={filePageStyle.largeButton}
+                      onPress={() => Linking.openURL(`https://lbry.com/dmca/${claim.claim_id}`)}
+                    >
+                      <Icon name={'flag'} size={20} style={filePageStyle.largeButtonIcon} />
+                      <Text style={filePageStyle.largeButtonText}>{__('Report')}</Text>
+                    </TouchableOpacity>
+                  )}
 
                   {canEdit && (
                     <TouchableOpacity style={filePageStyle.largeButton} onPress={this.onEditPressed}>
                       <Icon name={'edit'} size={20} style={filePageStyle.largeButtonIcon} />
-                      <Text style={filePageStyle.largeButtonText}>Edit</Text>
+                      <Text style={filePageStyle.largeButtonText}>{__('Edit')}</Text>
                     </TouchableOpacity>
                   )}
 
                   {(completed || canEdit) && (
                     <TouchableOpacity style={filePageStyle.largeButton} onPress={this.onDeletePressed}>
                       <Icon name={'trash-alt'} size={20} style={filePageStyle.largeButtonIcon} />
-                      <Text style={filePageStyle.largeButtonText}>Delete</Text>
-                    </TouchableOpacity>
-                  )}
-
-                  {!completed &&
-                    fileInfo &&
-                    !fileInfo.stopped &&
-                    fileInfo.written_bytes < fileInfo.total_bytes &&
-                    !this.state.stopDownloadConfirmed && (
-                    <TouchableOpacity style={filePageStyle.largeButton} onPress={this.onStopDownloadPressed}>
-                      <Icon name={'stop'} size={20} style={filePageStyle.largeButtonIcon} />
-                      <Text style={filePageStyle.largeButtonText}>Stop Download</Text>
+                      <Text style={filePageStyle.largeButtonText}>{__('Delete')}</Text>
                     </TouchableOpacity>
                   )}
                 </View>
diff --git a/src/styles/filePage.js b/src/styles/filePage.js
index 54f2058..078b53b 100644
--- a/src/styles/filePage.js
+++ b/src/styles/filePage.js
@@ -381,6 +381,15 @@ const filePageStyle = StyleSheet.create({
   backButtonIcon: {
     color: Colors.White,
   },
+  sharedLargeButton: {
+    alignItems: 'center',
+    justifyContent: 'center',
+    marginRight: 36,
+  },
+  innerLargeButton: {
+    alignItems: 'center',
+    justifyContent: 'center',
+  },
   largeButton: {
     alignItems: 'center',
     justifyContent: 'center',
-- 
2.45.3