From ccbb5d88dc9911c8aeddb3b956f2aff83a9d854a Mon Sep 17 00:00:00 2001 From: Jack Robison Date: Tue, 30 May 2017 10:48:08 -0400 Subject: [PATCH 1/4] don't allow bid to be equal to wallet balance (nothing left for the tx fee) --- lbrynet/lbrynet_daemon/Daemon.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lbrynet/lbrynet_daemon/Daemon.py b/lbrynet/lbrynet_daemon/Daemon.py index d579f62c3..cefe25aa3 100644 --- a/lbrynet/lbrynet_daemon/Daemon.py +++ b/lbrynet/lbrynet_daemon/Daemon.py @@ -1804,7 +1804,7 @@ class Daemon(AuthJSONRPCServer): if bid <= 0.0: raise Exception("Invalid bid") - if bid > self.session.wallet.get_balance(): + if bid >= self.session.wallet.get_balance(): raise InsufficientFundsError() metadata = metadata or {} From f258df95e600b236e730e3ffa9a2b6d8e0df68dd Mon Sep 17 00:00:00 2001 From: Jack Robison Date: Tue, 30 May 2017 10:48:21 -0400 Subject: [PATCH 2/4] fix licenseUrl metadata key name --- lbrynet/lbrynet_daemon/Daemon.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lbrynet/lbrynet_daemon/Daemon.py b/lbrynet/lbrynet_daemon/Daemon.py index cefe25aa3..adf01f6c4 100644 --- a/lbrynet/lbrynet_daemon/Daemon.py +++ b/lbrynet/lbrynet_daemon/Daemon.py @@ -1821,7 +1821,7 @@ class Daemon(AuthJSONRPCServer): if license is not None: metadata['license'] = license if license_url is not None: - metadata['license_url'] = license_url + metadata['licenseUrl'] = license_url if thumbnail is not None: metadata['thumbnail'] = thumbnail if preview is not None: From 61cb3e2a8dfce3dcb89924f2c917d183e91eb1cf Mon Sep 17 00:00:00 2001 From: Jack Robison Date: Tue, 30 May 2017 10:49:22 -0400 Subject: [PATCH 3/4] update fee parameter to match lbryschema --- lbrynet/lbrynet_daemon/Daemon.py | 34 +++++++++++++------------------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/lbrynet/lbrynet_daemon/Daemon.py b/lbrynet/lbrynet_daemon/Daemon.py index adf01f6c4..6daf95981 100644 --- a/lbrynet/lbrynet_daemon/Daemon.py +++ b/lbrynet/lbrynet_daemon/Daemon.py @@ -1834,26 +1834,13 @@ class Daemon(AuthJSONRPCServer): # original format {'currency':{'address','amount'}} # add address to fee if unspecified {'version': ,'currency', 'address' , 'amount'} if 'fee' in metadata: - assert len(metadata['fee']) == 1, "Too many fees" - currency, fee_dict = metadata['fee'].items()[0] - if 'address' not in fee_dict: - address = yield self.session.wallet.get_new_address() - else: - address = fee_dict['address'] - metadata['fee'] = { - 'version': '_0_0_1', - 'currency': currency, - 'address': address, - 'amount': fee_dict['amount'] - } - - log.info("Publish: %s", { - 'name': name, - 'file_path': file_path, - 'bid': bid, - 'metadata': metadata, - 'fee': fee, - }) + if 'amount' in metadata['fee'] and 'currency' in metadata['fee']: + if not metadata['fee']['amount']: + log.warning("Stripping empty fee from published metadata") + del metadata['fee'] + elif 'address' not in metadata['fee']: + address = yield self.session.wallet.get_unused_address() + metadata['fee']['address'] = address claim_dict = { 'version': '_0_0_1', @@ -1867,6 +1854,13 @@ class Daemon(AuthJSONRPCServer): if sources is not None: claim_dict['stream']['source'] = sources + log.info("Publish: %s", { + 'name': name, + 'file_path': file_path, + 'bid': bid, + 'claim_dict': claim_dict, + }) + if channel_id: certificate_id = channel_id elif channel_name: From 4643309e6b0ffcfb30ffe1e2e3a7e421e532fad5 Mon Sep 17 00:00:00 2001 From: Jack Robison Date: Tue, 30 May 2017 10:51:41 -0400 Subject: [PATCH 4/4] update changelog --- CHANGELOG.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 75ebc0f89..2e711a0fb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,12 +13,15 @@ at anytime. * ### Changed - * + * Update `publish` to use {'currency': ..., 'address': ..., 'amount'} format for fee parameter, + previously used old {currency: {'address': ..., 'amount': ...}} format * ### Fixed * * + * Allow claim_show to be used without specifying name + * Fix licenseUrl field in `publish` ### Deprecated *