LBRYCommunity/lbry-sdk
1
0
Fork 1
Code Issues Pull requests Projects Releases 282 Packages Wiki Activity

dont send analytics info if its disabled

Browse source
This commit is contained in:
Alex Grintsvayg 2017-04-26 18:20:02 -04:00
parent 2353dbcb00
commit 8afe4d1af8
1 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
lbrynet/analytics.py
View file

@ -34,9 +34,8 @@ class Manager(object):
self.is_started = False self.is_started = False
@classmethod @classmethod
def new_instance(cls, api=None): def new_instance(cls, enabled=None):
if api is None: api = Api.new_instance(enabled)
api = Api.new_instance()
return cls(api) return cls(api)
# Things We Track # Things We Track
@ -194,10 +193,11 @@ class Manager(object):
class Api(object): class Api(object):
def __init__(self, session, url, write_key): def __init__(self, session, url, write_key, enabled):
self.session = session self.session = session
self.url = url self.url = url
self._write_key = write_key self._write_key = write_key
self._enabled = enabled
def _post(self, endpoint, data): def _post(self, endpoint, data):
# there is an issue with a timing condition with keep-alive # there is an issue with a timing condition with keep-alive
@ -220,6 +220,8 @@ class Api(object):
def track(self, event): def track(self, event):
"""Send a single tracking event""" """Send a single tracking event"""
if not self._enabled:
return defer.succeed('analytics disabled')
def _log_error(failure): def _log_error(failure):
log.warning('Failed to send track event. %s', failure.getTraceback()) log.warning('Failed to send track event. %s', failure.getTraceback())
@ -230,12 +232,14 @@ class Api(object):
return d return d
@classmethod @classmethod
def new_instance(cls, session=None): def new_instance(cls, enabled=None):
"""Initialize an instance using values from the configuration""" """Initialize an instance using values from the configuration"""
if not session: session = Session()
session = Session() if enabled is None:
enabled = conf.settings['share_debug_info']
return cls( return cls(
session, session,
conf.settings['ANALYTICS_ENDPOINT'], conf.settings['ANALYTICS_ENDPOINT'],
utils.deobfuscate(conf.settings['ANALYTICS_TOKEN']) utils.deobfuscate(conf.settings['ANALYTICS_TOKEN']),
enabled,
) )