From abc7b11e26b1892ec78749c2e81121bab597f052 Mon Sep 17 00:00:00 2001
From: Job Evers-Meltzer <jobevers@users.noreply.github.com>
Date: Thu, 10 Nov 2016 13:55:31 -0600
Subject: [PATCH] remove repeated code for reflector

---
 lbrynet/lbrynet_daemon/Daemon.py | 32 ++++++++++++--------------------
 1 file changed, 12 insertions(+), 20 deletions(-)

diff --git a/lbrynet/lbrynet_daemon/Daemon.py b/lbrynet/lbrynet_daemon/Daemon.py
index b8b434030..3e89f7c6e 100644
--- a/lbrynet/lbrynet_daemon/Daemon.py
+++ b/lbrynet/lbrynet_daemon/Daemon.py
@@ -1022,44 +1022,26 @@ class Daemon(AuthJSONRPCServer):
     def _reflect(self, lbry_file):
         if not lbry_file:
             return defer.fail(Exception("no lbry file given to reflect"))
-
         stream_hash = lbry_file.stream_hash
-
         if stream_hash is None:
             return defer.fail(Exception("no stream hash"))
-
         log.info("Reflecting stream: %s" % stream_hash)
-
-        reflector_server = random.choice(lbrynet_settings.reflector_servers)
-        reflector_address, reflector_port = reflector_server[0], reflector_server[1]
-        log.info("Start reflector client")
         factory = reflector.ClientFactory(
             self.session.blob_manager,
             self.lbry_file_manager.stream_info_manager,
             stream_hash
         )
-        d = reactor.resolve(reflector_address)
-        d.addCallback(lambda ip: reactor.connectTCP(ip, reflector_port, factory))
-        d.addCallback(lambda _: factory.finished_deferred)
-        return d
+        return run_reflector_factory(factory)
 
     def _reflect_blobs(self, blob_hashes):
         if not blob_hashes:
             return defer.fail(Exception("no lbry file given to reflect"))
-
         log.info("Reflecting %i blobs" % len(blob_hashes))
-
-        reflector_server = random.choice(lbrynet_settings.reflector_servers)
-        reflector_address, reflector_port = reflector_server[0], reflector_server[1]
-        log.info("Start reflector client")
         factory = reflector.BlobClientFactory(
             self.session.blob_manager,
             blob_hashes
         )
-        d = reactor.resolve(reflector_address)
-        d.addCallback(lambda ip: reactor.connectTCP(ip, reflector_port, factory))
-        d.addCallback(lambda _: factory.finished_deferred)
-        return d
+        return run_reflector_factory(factory)
 
     def _log_to_slack(self, msg):
         URL = "https://hooks.slack.com/services/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"
@@ -2701,3 +2683,13 @@ def handle_failure(err, msg):
     #
     # If so, maybe we should return something else.
     return server.failure
+
+
+def run_reflector_factory(factory):
+    reflector_server = random.choice(lbrynet_settings.reflector_servers)
+    reflector_address, reflector_port = reflector_server
+    log.info("Start reflector client")
+    d = reactor.resolve(reflector_address)
+    d.addCallback(lambda ip: reactor.connectTCP(ip, reflector_port, factory))
+    d.addCallback(lambda _: factory.finished_deferred)
+    return d