diff --git a/lbry/lbry/extras/daemon/Daemon.py b/lbry/lbry/extras/daemon/Daemon.py index ad33ab912..993c85749 100644 --- a/lbry/lbry/extras/daemon/Daemon.py +++ b/lbry/lbry/extras/daemon/Daemon.py @@ -1022,8 +1022,7 @@ class Daemon(metaclass=JSONRPCServerType): """ with self.conf.update_config() as c: setattr(c, key, NOT_SET) - setting = self.conf.settings_dict[key] - return {key: setting} + return {key: self.conf.settings_dict[key]} PREFERENCE_DOC = """ Preferences management. diff --git a/lbry/tests/integration/test_other_commands.py b/lbry/tests/integration/test_other_commands.py index 1c1ca9441..ecfef90da 100644 --- a/lbry/tests/integration/test_other_commands.py +++ b/lbry/tests/integration/test_other_commands.py @@ -14,21 +14,12 @@ class AddressManagement(CommandTestCase): class SettingsManagement(CommandTestCase): async def test_settings(self): - settings = self.daemon.jsonrpc_settings_get() - self.assertNotEqual(settings['lbryum_servers'][0],('127.0.0.1', 50002)) - self.assertEqual(settings['lbryum_servers'][0],('127.0.0.1', 50001)) + self.assertEqual(self.daemon.jsonrpc_settings_get()['lbryum_servers'][0], ('127.0.0.1', 50001)) - servers = ['server:50001', 'server2:50001'] - setting = self.daemon.jsonrpc_settings_set('lbryum_servers', servers) + setting = self.daemon.jsonrpc_settings_set('lbryum_servers', ['server:50001']) self.assertEqual(setting['lbryum_servers'][0], ('server', 50001)) + self.assertEqual(self.daemon.jsonrpc_settings_get()['lbryum_servers'][0], ('server', 50001)) - self.daemon.jsonrpc_settings_set('use_upnp', True) - settings2 = self.daemon.jsonrpc_settings_get() - self.assertEqual(settings2['lbryum_servers'][0], ('server', 50001)) - self.assertEqual(settings2['use_upnp'], True) - - clearing = self.daemon.jsonrpc_settings_clear('lbryum_servers') - self.assertEqual(clearing['lbryum_servers'][0], ('spv1.lbry.com', 50001)) - settings3 = self.daemon.jsonrpc_settings_get() - self.assertNotEqual(settings3['lbryum_servers'][0], ('spv1.lbry.com', 50002)) - self.assertEqual(settings3['lbryum_servers'][0], ('spv1.lbry.com', 50001)) + setting = self.daemon.jsonrpc_settings_clear('lbryum_servers') + self.assertEqual(setting['lbryum_servers'][0], ('spv1.lbry.com', 50001)) + self.assertEqual(self.daemon.jsonrpc_settings_get()['lbryum_servers'][0], ('spv1.lbry.com', 50001))