diff --git a/Development-Process-&-Standards.md b/Development-Process-&-Standards.md index 50c40a1..54d88d0 100644 --- a/Development-Process-&-Standards.md +++ b/Development-Process-&-Standards.md @@ -5,6 +5,7 @@ 1. squash/rebase code for sharing, write quality commit messages 1. run automated linting/testing suite. if there are issues, goto 1 1. test the code yourself (on every OS/platform/environment we support) +1. document your changes in the [changelog](https://github.com/lbryio/lbry/wiki/Changelog-format) 1. create PR (or update existing PR) 1. assign someone to review and approve your PR. if reviewer raises any issues, goto 1 1. squash fixup commits; merge your PR into master; delete branch @@ -17,7 +18,7 @@ 3. Commit messages should be informative, usable for release notes, and provide context/explanation for the change being made 4. Commits on master should stand-alone 5. Force pushes on feature branches are allowed; please commit early and often, but clean-up the mess before merging into master. - +6. Pull requests should have an informative changelog entry (see [changelog format](https://github.com/lbryio/lbry/wiki/Changelog-format)). # Code Review