Merge pull request #48 from lbryio/stopper_debugging

Added debugging logic for our stopper pattern.
This commit is contained in:
Mark 2018-12-23 01:22:58 -05:00 committed by GitHub
commit 7593aa704f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -2,6 +2,7 @@ package stop
import ( import (
"context" "context"
"log"
"sync" "sync"
) )
@ -10,6 +11,8 @@ type Chan <-chan struct{}
// Stopper extends sync.WaitGroup to add a convenient way to stop running goroutines // Stopper extends sync.WaitGroup to add a convenient way to stop running goroutines
type Group struct { type Group struct {
waitingOn map[string]int
l sync.RWMutex
sync.WaitGroup sync.WaitGroup
ctx context.Context ctx context.Context
cancel context.CancelFunc cancel context.CancelFunc
@ -27,6 +30,15 @@ func New(parent ...*Group) *Group {
return s return s
} }
// NewDebug allows you to debug the go routines the group waits on. In order to leverage this, AddNamed and DoneNamed should be used.
func NewDebug(parent ...*Group) *Group {
s := New(parent...)
s.waitingOn = make(map[string]int)
s.l = sync.RWMutex{}
return s
}
// Ch returns a channel that will be closed when Stop is called. // Ch returns a channel that will be closed when Stop is called.
func (s *Group) Ch() Chan { func (s *Group) Ch() Chan {
return s.ctx.Done() return s.ctx.Done()
@ -47,3 +59,38 @@ func (s *Group) StopAndWait() {
func (s *Group) Child() *Group { func (s *Group) Child() *Group {
return New(s) return New(s)
} }
func (s *Group) AddNamed(delta int, name string) {
if s.waitingOn != nil {
s.l.Lock()
defer s.l.Unlock()
_, ok := s.waitingOn[name]
if !ok {
s.waitingOn[name] = 1
} else {
s.waitingOn[name] = s.waitingOn[name] + 1
}
}
s.Add(delta)
}
func (s *Group) DoneNamed(name string) {
if s.waitingOn != nil {
s.l.Lock()
defer s.l.Unlock()
_, ok := s.waitingOn[name]
if !ok {
log.Printf("%s is not recorded in stop group map")
} else {
s.waitingOn[name] = s.waitingOn[name] - 1
}
log.Printf("-->> LIST WAITING ON")
for k, v := range s.waitingOn {
if v > 0 {
log.Printf("waiting on %d %s routines...", v, k)
}
}
}
s.Done()
}