From 1bbedef565d45cab4802998ec1cba92cc3345ecb Mon Sep 17 00:00:00 2001 From: Brannon King Date: Wed, 9 Oct 2019 21:53:07 -0600 Subject: [PATCH] ensure we don't return witness data in the transaction w/o segwit rule --- configure.ac | 2 +- src/rpc/mining.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 0af532822..255c7e9d2 100644 --- a/configure.ac +++ b/configure.ac @@ -3,7 +3,7 @@ AC_PREREQ([2.60]) define(_CLIENT_VERSION_MAJOR, 0) define(_CLIENT_VERSION_MINOR, 17) define(_CLIENT_VERSION_REVISION, 3) -define(_CLIENT_VERSION_BUILD, 1) +define(_CLIENT_VERSION_BUILD, 2) define(_CLIENT_VERSION_IS_RELEASE, true) define(_COPYRIGHT_YEAR, 2019) define(_COPYRIGHT_HOLDERS,[The %s developers]) diff --git a/src/rpc/mining.cpp b/src/rpc/mining.cpp index 0d1ba67ed..87b160145 100644 --- a/src/rpc/mining.cpp +++ b/src/rpc/mining.cpp @@ -451,7 +451,7 @@ static UniValue getblocktemplate(const JSONRPCRequest& request) if (strMode != "template") throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid mode"); - if (Params().NetworkIDString() != CBaseChainParams::REGTEST) // who should own this constant? + if (Params().NetworkIDString() == CBaseChainParams::MAIN) { if (!g_connman) throw JSONRPCError(RPC_CLIENT_P2P_DISABLED, "Error: Peer-to-peer functionality missing or disabled"); @@ -585,7 +585,7 @@ static UniValue getblocktemplate(const JSONRPCRequest& request) UniValue entry(UniValue::VOBJ); - entry.pushKV("data", EncodeHexTx(tx)); + entry.pushKV("data", EncodeHexTx(tx, fSupportsSegwit ? 0 : SERIALIZE_TRANSACTION_NO_WITNESS)); entry.pushKV("txid", txHash.GetHex()); entry.pushKV("hash", tx.GetWitnessHash().GetHex());