LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

Make pass-by-ref arguments const.

Browse source 
Make some of the arguments in rest.cpp, that are passed by
reference but never modified, const to emphasise that.
This commit is contained in:
Daniel Kraft 2014-12-16 13:45:27 +01:00
parent 28a274e6ce
commit 7c8e4c5cfb
2 changed files with 17 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
src/rest.cpp
View file

@ -90,8 +90,8 @@ static bool ParseHashStr(const string& strReq, uint256& v)
} }
static bool rest_headers(AcceptedConnection* conn, static bool rest_headers(AcceptedConnection* conn,
string& strReq, const std::string& strReq,
map<string, string>& mapHeaders, const std::map<std::string, std::string>& mapHeaders,
bool fRun) bool fRun)
{ {
vector<string> params; vector<string> params;
@ -153,8 +153,8 @@ static bool rest_headers(AcceptedConnection* conn,
} }
static bool rest_block(AcceptedConnection* conn, static bool rest_block(AcceptedConnection* conn,
string& strReq, const std::string& strReq,
map<string, string>& mapHeaders, const std::map<std::string, std::string>& mapHeaders,
bool fRun, bool fRun,
bool showTxDetails) bool showTxDetails)
{ {
@ -211,24 +211,24 @@ static bool rest_block(AcceptedConnection* conn,
} }
static bool rest_block_extended(AcceptedConnection* conn, static bool rest_block_extended(AcceptedConnection* conn,
string& strReq, const std::string& strReq,
map<string, string>& mapHeaders, const std::map<std::string, std::string>& mapHeaders,
bool fRun) bool fRun)
{ {
return rest_block(conn, strReq, mapHeaders, fRun, true); return rest_block(conn, strReq, mapHeaders, fRun, true);
} }
static bool rest_block_notxdetails(AcceptedConnection* conn, static bool rest_block_notxdetails(AcceptedConnection* conn,
string& strReq, const std::string& strReq,
map<string, string>& mapHeaders, const std::map<std::string, std::string>& mapHeaders,
bool fRun) bool fRun)
{ {
return rest_block(conn, strReq, mapHeaders, fRun, false); return rest_block(conn, strReq, mapHeaders, fRun, false);
} }
static bool rest_tx(AcceptedConnection* conn, static bool rest_tx(AcceptedConnection* conn,
string& strReq, const std::string& strReq,
map<string, string>& mapHeaders, const std::map<std::string, std::string>& mapHeaders,
bool fRun) bool fRun)
{ {
vector<string> params; vector<string> params;
@ -280,8 +280,8 @@ static bool rest_tx(AcceptedConnection* conn,
static const struct { static const struct {
const char* prefix; const char* prefix;
bool (*handler)(AcceptedConnection* conn, bool (*handler)(AcceptedConnection* conn,
string& strURI, const std::string& strURI,
map<string, string>& mapHeaders, const std::map<std::string, std::string>& mapHeaders,
bool fRun); bool fRun);
} uri_prefixes[] = { } uri_prefixes[] = {
{"/rest/tx/", rest_tx}, {"/rest/tx/", rest_tx},
@ -291,8 +291,8 @@ static const struct {
}; };
bool HTTPReq_REST(AcceptedConnection* conn, bool HTTPReq_REST(AcceptedConnection* conn,
string& strURI, const std::string& strURI,
map<string, string>& mapHeaders, const std::map<std::string, std::string>& mapHeaders,
bool fRun) bool fRun)
{ {
try { try {
@ -307,7 +307,7 @@ bool HTTPReq_REST(AcceptedConnection* conn,
return uri_prefixes[i].handler(conn, strReq, mapHeaders, fRun); return uri_prefixes[i].handler(conn, strReq, mapHeaders, fRun);
} }
} }
} catch (RestErr& re) { } catch (const RestErr& re) {
conn->stream() << HTTPReply(re.status, re.message + "\r\n", false, false, "text/plain") << std::flush; conn->stream() << HTTPReply(re.status, re.message + "\r\n", false, false, "text/plain") << std::flush;
return false; return false;
} }

4
src/rpcserver.h
View file

@ -227,8 +227,8 @@ extern json_spirit::Value reconsiderblock(const json_spirit::Array& params, bool
// in rest.cpp // in rest.cpp
extern bool HTTPReq_REST(AcceptedConnection *conn, extern bool HTTPReq_REST(AcceptedConnection *conn,
std::string& strURI, const std::string& strURI,
std::map<std::string, std::string>& mapHeaders, const std::map<std::string, std::string>& mapHeaders,
bool fRun); bool fRun);
#endif // BITCOIN_RPCSERVER_H #endif // BITCOIN_RPCSERVER_H