From ba534ccd5664670707f711451ad15f64c5244ba5 Mon Sep 17 00:00:00 2001 From: John Newbery Date: Tue, 30 Apr 2019 15:06:26 -0500 Subject: [PATCH 1/2] [tests] log thread names by default in functional tests --- test/functional/test_framework/test_node.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/functional/test_framework/test_node.py b/test/functional/test_framework/test_node.py index 8b2006a05..21ca96d6b 100755 --- a/test/functional/test_framework/test_node.py +++ b/test/functional/test_framework/test_node.py @@ -84,6 +84,7 @@ class TestNode(): self.binary, "-datadir=" + self.datadir, "-logtimemicros", + "-logthreadnames", "-debug", "-debugexclude=libevent", "-debugexclude=leveldb", From 7b29ec277b2f99a526c2a70f0dec7b28f1e874a4 Mon Sep 17 00:00:00 2001 From: John Newbery Date: Fri, 3 May 2019 12:47:27 -0400 Subject: [PATCH 2/2] [tests] Comment for why logging config is set as command-line args. --- test/functional/test_framework/test_node.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/functional/test_framework/test_node.py b/test/functional/test_framework/test_node.py index 21ca96d6b..b9d1082dd 100755 --- a/test/functional/test_framework/test_node.py +++ b/test/functional/test_framework/test_node.py @@ -80,6 +80,9 @@ class TestNode(): # For those callers that need more flexibility, they can just set the args property directly. # Note that common args are set in the config file (see initialize_datadir) self.extra_args = extra_args + # Configuration for logging is set as command-line args rather than in the bitcoin.conf file. + # This means that starting a bitcoind using the temp dir to debug a failed test won't + # spam debug.log. self.args = [ self.binary, "-datadir=" + self.datadir,