LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

Merge #16962: doc: Put PR template in comments

Browse source 
203a67d21f doc: Put PR template in comments (Wladimir J. van der Laan)

Pull request description:

  This prevents the common annoyance of the text being included into PRs
  accidentally.

ACKs for top commit:
  sdaftuar:
    utACK 203a67d21f
  fanquake:
    ACK 203a67d21f - I make an effort to remove it whenever I see it in a PR.

Tree-SHA512: 3514d285488b7930d7f3d7f8823198d7325d8b7de57a6d8f13e559c0c23b30d58916b15782cbbdc347a375b418e9d0f7a5b99b34d26f3b957d7d5a03a3d83dfd
This commit is contained in:
Wladimir J. van der Laan 2019-09-30 09:48:10 +02:00
commit 942e275018
No known key found for this signature in database
GPG key ID: 1E4AED62986CD25D
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
.github/PULL_REQUEST_TEMPLATE.md vendored
View file

@ -1,9 +1,14 @@
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed Pull requests without a rationale and clear improvement may be closed
immediately. immediately.
-->
<!--
Please provide clear motivation for your patch and explain how it improves Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience Bitcoin Core user experience or Bitcoin Core developer experience
significantly. significantly:
* Any test improvements or new tests that improve coverage are always welcome. * Any test improvements or new tests that improve coverage are always welcome.
* All other changes should have accompanying unit tests (see `src/test/`) or * All other changes should have accompanying unit tests (see `src/test/`) or
@ -24,8 +29,11 @@ significantly.
is often a subjective matter. Unless they are explicitly mentioned to be is often a subjective matter. Unless they are explicitly mentioned to be
preferred in the [developer notes](/doc/developer-notes.md), stylistic code preferred in the [developer notes](/doc/developer-notes.md), stylistic code
changes are usually rejected. changes are usually rejected.
-->
<!--
Bitcoin Core has a thorough review process and even the most trivial change Bitcoin Core has a thorough review process and even the most trivial change
needs to pass a lot of eyes and requires non-zero or even substantial time needs to pass a lot of eyes and requires non-zero or even substantial time
effort to review. There is a huge lack of active reviewers on the project, so effort to review. There is a huge lack of active reviewers on the project, so
patches often sit for a long time. patches often sit for a long time.
-->