LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

use const references where appropriate

Browse source
This commit is contained in:
Philip Kaufmann 2015-05-31 15:36:44 +02:00
parent 466f0ea0e6
commit a9ac95c1bc
21 changed files with 61 additions and 63 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/alert.cpp
View file

@ -50,7 +50,7 @@ std::string CUnsignedAlert::ToString() const
BOOST_FOREACH(int n, setCancel) BOOST_FOREACH(int n, setCancel)
strSetCancel += strprintf("%d ", n); strSetCancel += strprintf("%d ", n);
std::string strSetSubVer; std::string strSetSubVer;
BOOST_FOREACH(std::string str, setSubVer) BOOST_FOREACH(const std::string& str, setSubVer)
strSetSubVer += "\"" + str + "\" "; strSetSubVer += "\"" + str + "\" ";
return strprintf( return strprintf(
"CAlert(\n" "CAlert(\n"
@ -110,7 +110,7 @@ bool CAlert::Cancels(const CAlert& alert) const
return (alert.nID <= nCancel || setCancel.count(alert.nID)); return (alert.nID <= nCancel || setCancel.count(alert.nID));
} }
bool CAlert::AppliesTo(int nVersion, std::string strSubVerIn) const bool CAlert::AppliesTo(int nVersion, const std::string& strSubVerIn) const
{ {
// TODO: rework for client-version-embedded-in-strSubVer ? // TODO: rework for client-version-embedded-in-strSubVer ?
return (IsInEffect() && return (IsInEffect() &&

2
src/alert.h
View file

@ -97,7 +97,7 @@ public:
uint256 GetHash() const; uint256 GetHash() const;
bool IsInEffect() const; bool IsInEffect() const;
bool Cancels(const CAlert& alert) const; bool Cancels(const CAlert& alert) const;
bool AppliesTo(int nVersion, std::string strSubVerIn) const; bool AppliesTo(int nVersion, const std::string& strSubVerIn) const;
bool AppliesToMe() const; bool AppliesToMe() const;
bool RelayTo(CNode* pnode) const; bool RelayTo(CNode* pnode) const;
bool CheckSignature(const std::vector<unsigned char>& alertKey) const; bool CheckSignature(const std::vector<unsigned char>& alertKey) const;

2
src/consensus/validation.h
View file

@ -48,7 +48,7 @@ public:
unsigned char _chRejectCode=0, std::string _strRejectReason="") { unsigned char _chRejectCode=0, std::string _strRejectReason="") {
return DoS(0, ret, _chRejectCode, _strRejectReason); return DoS(0, ret, _chRejectCode, _strRejectReason);
} }
bool Error(std::string strRejectReasonIn="") { bool Error(const std::string& strRejectReasonIn) {
if (mode == MODE_VALID) if (mode == MODE_VALID)
strRejectReason = strRejectReasonIn; strRejectReason = strRejectReasonIn;
mode = MODE_ERROR; mode = MODE_ERROR;

2
src/core_io.h
View file

@ -15,7 +15,7 @@ class uint256;
class UniValue; class UniValue;
// core_read.cpp // core_read.cpp
extern CScript ParseScript(std::string s); extern CScript ParseScript(const std::string& s);
extern bool DecodeHexTx(CTransaction& tx, const std::string& strHexTx); extern bool DecodeHexTx(CTransaction& tx, const std::string& strHexTx);
extern bool DecodeHexBlk(CBlock&, const std::string& strHexBlk); extern bool DecodeHexBlk(CBlock&, const std::string& strHexBlk);
extern uint256 ParseHashUV(const UniValue& v, const std::string& strName); extern uint256 ParseHashUV(const UniValue& v, const std::string& strName);

2
src/core_read.cpp
View file

@ -22,7 +22,7 @@
using namespace std; using namespace std;
CScript ParseScript(std::string s) CScript ParseScript(const std::string& s)
{ {
CScript result; CScript result;

14
src/init.cpp
View file

@ -535,7 +535,7 @@ void ThreadImport(std::vector<boost::filesystem::path> vImportFiles)
} }
// -loadblock= // -loadblock=
BOOST_FOREACH(boost::filesystem::path &path, vImportFiles) { BOOST_FOREACH(const boost::filesystem::path& path, vImportFiles) {
FILE *file = fopen(path.string().c_str(), "rb"); FILE *file = fopen(path.string().c_str(), "rb");
if (file) { if (file) {
CImportingNow imp; CImportingNow imp;
@ -946,7 +946,7 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)
if (mapArgs.count("-onlynet")) { if (mapArgs.count("-onlynet")) {
std::set<enum Network> nets; std::set<enum Network> nets;
BOOST_FOREACH(std::string snet, mapMultiArgs["-onlynet"]) { BOOST_FOREACH(const std::string& snet, mapMultiArgs["-onlynet"]) {
enum Network net = ParseNetwork(snet); enum Network net = ParseNetwork(snet);
if (net == NET_UNROUTABLE) if (net == NET_UNROUTABLE)
return InitError(strprintf(_("Unknown network specified in -onlynet: '%s'"), snet)); return InitError(strprintf(_("Unknown network specified in -onlynet: '%s'"), snet));
@ -1003,13 +1003,13 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)
bool fBound = false; bool fBound = false;
if (fListen) { if (fListen) {
if (mapArgs.count("-bind") || mapArgs.count("-whitebind")) { if (mapArgs.count("-bind") || mapArgs.count("-whitebind")) {
BOOST_FOREACH(std::string strBind, mapMultiArgs["-bind"]) { BOOST_FOREACH(const std::string& strBind, mapMultiArgs["-bind"]) {
CService addrBind; CService addrBind;
if (!Lookup(strBind.c_str(), addrBind, GetListenPort(), false)) if (!Lookup(strBind.c_str(), addrBind, GetListenPort(), false))
return InitError(strprintf(_("Cannot resolve -bind address: '%s'"), strBind)); return InitError(strprintf(_("Cannot resolve -bind address: '%s'"), strBind));
fBound |= Bind(addrBind, (BF_EXPLICIT | BF_REPORT_ERROR)); fBound |= Bind(addrBind, (BF_EXPLICIT | BF_REPORT_ERROR));
} }
BOOST_FOREACH(std::string strBind, mapMultiArgs["-whitebind"]) { BOOST_FOREACH(const std::string& strBind, mapMultiArgs["-whitebind"]) {
CService addrBind; CService addrBind;
if (!Lookup(strBind.c_str(), addrBind, 0, false)) if (!Lookup(strBind.c_str(), addrBind, 0, false))
return InitError(strprintf(_("Cannot resolve -whitebind address: '%s'"), strBind)); return InitError(strprintf(_("Cannot resolve -whitebind address: '%s'"), strBind));
@ -1029,7 +1029,7 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)
} }
if (mapArgs.count("-externalip")) { if (mapArgs.count("-externalip")) {
BOOST_FOREACH(string strAddr, mapMultiArgs["-externalip"]) { BOOST_FOREACH(const std::string& strAddr, mapMultiArgs["-externalip"]) {
CService addrLocal(strAddr, GetListenPort(), fNameLookup); CService addrLocal(strAddr, GetListenPort(), fNameLookup);
if (!addrLocal.IsValid()) if (!addrLocal.IsValid())
return InitError(strprintf(_("Cannot resolve -externalip address: '%s'"), strAddr)); return InitError(strprintf(_("Cannot resolve -externalip address: '%s'"), strAddr));
@ -1037,7 +1037,7 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)
} }
} }
BOOST_FOREACH(string strDest, mapMultiArgs["-seednode"]) BOOST_FOREACH(const std::string& strDest, mapMultiArgs["-seednode"])
AddOneShot(strDest); AddOneShot(strDest);
// ********************************************************* Step 7: load block chain // ********************************************************* Step 7: load block chain
@ -1362,7 +1362,7 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)
std::vector<boost::filesystem::path> vImportFiles; std::vector<boost::filesystem::path> vImportFiles;
if (mapArgs.count("-loadblock")) if (mapArgs.count("-loadblock"))
{ {
BOOST_FOREACH(string strFile, mapMultiArgs["-loadblock"]) BOOST_FOREACH(const std::string& strFile, mapMultiArgs["-loadblock"])
vImportFiles.push_back(strFile); vImportFiles.push_back(strFile);
} }
threadGroup.create_thread(boost::bind(&ThreadImport, vImportFiles)); threadGroup.create_thread(boost::bind(&ThreadImport, vImportFiles));

2
src/main.cpp
View file

@ -3696,7 +3696,7 @@ void static CheckBlockIndex()
// CAlert // CAlert
// //
string GetWarnings(string strFor) std::string GetWarnings(const std::string& strFor)
{ {
int nPriority = 0; int nPriority = 0;
string strStatusBar; string strStatusBar;

2
src/main.h
View file

@ -190,7 +190,7 @@ void PartitionCheck(bool (*initialDownloadCheck)(), CCriticalSection& cs, const
/** Check whether we are doing an initial block download (synchronizing from disk or network) */ /** Check whether we are doing an initial block download (synchronizing from disk or network) */
bool IsInitialBlockDownload(); bool IsInitialBlockDownload();
/** Format a string that describes several potential problems detected by the core */ /** Format a string that describes several potential problems detected by the core */
std::string GetWarnings(std::string strFor); std::string GetWarnings(const std::string& strFor);
/** Retrieve a transaction (from memory pool, or from disk, if possible) */ /** Retrieve a transaction (from memory pool, or from disk, if possible) */
bool GetTransaction(const uint256 &hash, CTransaction &tx, uint256 &hashBlock, bool fAllowSlow = false); bool GetTransaction(const uint256 &hash, CTransaction &tx, uint256 &hashBlock, bool fAllowSlow = false);
/** Find the best known block, and make it the tip of the block chain */ /** Find the best known block, and make it the tip of the block chain */

21
src/net.cpp
View file

@ -107,7 +107,7 @@ boost::condition_variable messageHandlerCondition;
static CNodeSignals g_signals; static CNodeSignals g_signals;
CNodeSignals& GetNodeSignals() { return g_signals; } CNodeSignals& GetNodeSignals() { return g_signals; }
void AddOneShot(string strDest) void AddOneShot(const std::string& strDest)
{ {
LOCK(cs_vOneShots); LOCK(cs_vOneShots);
vOneShots.push_back(strDest); vOneShots.push_back(strDest);
@ -1124,7 +1124,7 @@ void ThreadDNSAddressSeed()
vector<CAddress> vAdd; vector<CAddress> vAdd;
if (LookupHost(seed.host.c_str(), vIPs)) if (LookupHost(seed.host.c_str(), vIPs))
{ {
BOOST_FOREACH(CNetAddr& ip, vIPs) BOOST_FOREACH(const CNetAddr& ip, vIPs)
{ {
int nOneDay = 24*3600; int nOneDay = 24*3600;
CAddress addr = CAddress(CService(ip, Params().GetDefaultPort())); CAddress addr = CAddress(CService(ip, Params().GetDefaultPort()));
@ -1188,7 +1188,7 @@ void ThreadOpenConnections()
for (int64_t nLoop = 0;; nLoop++) for (int64_t nLoop = 0;; nLoop++)
{ {
ProcessOneShot(); ProcessOneShot();
BOOST_FOREACH(string strAddr, mapMultiArgs["-connect"]) BOOST_FOREACH(const std::string& strAddr, mapMultiArgs["-connect"])
{ {
CAddress addr; CAddress addr;
OpenNetworkConnection(addr, NULL, strAddr.c_str()); OpenNetworkConnection(addr, NULL, strAddr.c_str());
@ -1291,10 +1291,10 @@ void ThreadOpenAddedConnections()
list<string> lAddresses(0); list<string> lAddresses(0);
{ {
LOCK(cs_vAddedNodes); LOCK(cs_vAddedNodes);
BOOST_FOREACH(string& strAddNode, vAddedNodes) BOOST_FOREACH(const std::string& strAddNode, vAddedNodes)
lAddresses.push_back(strAddNode); lAddresses.push_back(strAddNode);
} }
BOOST_FOREACH(string& strAddNode, lAddresses) { BOOST_FOREACH(const std::string& strAddNode, lAddresses) {
CAddress addr; CAddress addr;
CSemaphoreGrant grant(*semOutbound); CSemaphoreGrant grant(*semOutbound);
OpenNetworkConnection(addr, &grant, strAddNode.c_str()); OpenNetworkConnection(addr, &grant, strAddNode.c_str());
@ -1309,20 +1309,19 @@ void ThreadOpenAddedConnections()
list<string> lAddresses(0); list<string> lAddresses(0);
{ {
LOCK(cs_vAddedNodes); LOCK(cs_vAddedNodes);
BOOST_FOREACH(string& strAddNode, vAddedNodes) BOOST_FOREACH(const std::string& strAddNode, vAddedNodes)
lAddresses.push_back(strAddNode); lAddresses.push_back(strAddNode);
} }
list<vector<CService> > lservAddressesToAdd(0); list<vector<CService> > lservAddressesToAdd(0);
BOOST_FOREACH(string& strAddNode, lAddresses) BOOST_FOREACH(const std::string& strAddNode, lAddresses) {
{
vector<CService> vservNode(0); vector<CService> vservNode(0);
if(Lookup(strAddNode.c_str(), vservNode, Params().GetDefaultPort(), fNameLookup, 0)) if(Lookup(strAddNode.c_str(), vservNode, Params().GetDefaultPort(), fNameLookup, 0))
{ {
lservAddressesToAdd.push_back(vservNode); lservAddressesToAdd.push_back(vservNode);
{ {
LOCK(cs_setservAddNodeAddresses); LOCK(cs_setservAddNodeAddresses);
BOOST_FOREACH(CService& serv, vservNode) BOOST_FOREACH(const CService& serv, vservNode)
setservAddNodeAddresses.insert(serv); setservAddNodeAddresses.insert(serv);
} }
} }
@ -1333,7 +1332,7 @@ void ThreadOpenAddedConnections()
LOCK(cs_vNodes); LOCK(cs_vNodes);
BOOST_FOREACH(CNode* pnode, vNodes) BOOST_FOREACH(CNode* pnode, vNodes)
for (list<vector<CService> >::iterator it = lservAddressesToAdd.begin(); it != lservAddressesToAdd.end(); it++) for (list<vector<CService> >::iterator it = lservAddressesToAdd.begin(); it != lservAddressesToAdd.end(); it++)
BOOST_FOREACH(CService& addrNode, *(it)) BOOST_FOREACH(const CService& addrNode, *(it))
if (pnode->addr == addrNode) if (pnode->addr == addrNode)
{ {
it = lservAddressesToAdd.erase(it); it = lservAddressesToAdd.erase(it);
@ -1906,7 +1905,7 @@ bool CAddrDB::Read(CAddrMan& addr)
unsigned int ReceiveFloodSize() { return 1000*GetArg("-maxreceivebuffer", 5*1000); } unsigned int ReceiveFloodSize() { return 1000*GetArg("-maxreceivebuffer", 5*1000); }
unsigned int SendBufferSize() { return 1000*GetArg("-maxsendbuffer", 1*1000); } unsigned int SendBufferSize() { return 1000*GetArg("-maxsendbuffer", 1*1000); }
CNode::CNode(SOCKET hSocketIn, CAddress addrIn, std::string addrNameIn, bool fInboundIn) : CNode::CNode(SOCKET hSocketIn, const CAddress& addrIn, const std::string& addrNameIn, bool fInboundIn) :
ssSend(SER_NETWORK, INIT_PROTO_VERSION), ssSend(SER_NETWORK, INIT_PROTO_VERSION),
addrKnown(5000, 0.001, insecure_rand()), addrKnown(5000, 0.001, insecure_rand()),
setInventoryKnown(SendBufferSize() / 1000) setInventoryKnown(SendBufferSize() / 1000)

4
src/net.h
View file

@ -63,7 +63,7 @@ static const size_t MAPASKFOR_MAX_SZ = MAX_INV_SZ;
unsigned int ReceiveFloodSize(); unsigned int ReceiveFloodSize();
unsigned int SendBufferSize(); unsigned int SendBufferSize();
void AddOneShot(std::string strDest); void AddOneShot(const std::string& strDest);
void AddressCurrentlyConnected(const CService& addr); void AddressCurrentlyConnected(const CService& addr);
CNode* FindNode(const CNetAddr& ip); CNode* FindNode(const CNetAddr& ip);
CNode* FindNode(const std::string& addrName); CNode* FindNode(const std::string& addrName);
@ -321,7 +321,7 @@ public:
// Whether a ping is requested. // Whether a ping is requested.
bool fPingQueued; bool fPingQueued;
CNode(SOCKET hSocketIn, CAddress addrIn, std::string addrNameIn = "", bool fInboundIn=false); CNode(SOCKET hSocketIn, const CAddress &addrIn, const std::string &addrNameIn = "", bool fInboundIn = false);
~CNode(); ~CNode();
private: private:

3
src/rpcmining.cpp
View file

@ -523,8 +523,7 @@ UniValue getblocktemplate(const UniValue& params, bool fHelp)
UniValue transactions(UniValue::VARR); UniValue transactions(UniValue::VARR);
map<uint256, int64_t> setTxIndex; map<uint256, int64_t> setTxIndex;
int i = 0; int i = 0;
BOOST_FOREACH (CTransaction& tx, pblock->vtx) BOOST_FOREACH (const CTransaction& tx, pblock->vtx) {
{
uint256 txHash = tx.GetHash(); uint256 txHash = tx.GetHash();
setTxIndex[txHash] = i++; setTxIndex[txHash] = i++;

17
src/rpcnet.cpp
View file

@ -253,19 +253,20 @@ UniValue getaddednodeinfo(const UniValue& params, bool fHelp)
if (params.size() == 1) if (params.size() == 1)
{ {
LOCK(cs_vAddedNodes); LOCK(cs_vAddedNodes);
BOOST_FOREACH(string& strAddNode, vAddedNodes) BOOST_FOREACH(const std::string& strAddNode, vAddedNodes)
laddedNodes.push_back(strAddNode); laddedNodes.push_back(strAddNode);
} }
else else
{ {
string strNode = params[1].get_str(); string strNode = params[1].get_str();
LOCK(cs_vAddedNodes); LOCK(cs_vAddedNodes);
BOOST_FOREACH(string& strAddNode, vAddedNodes) BOOST_FOREACH(const std::string& strAddNode, vAddedNodes) {
if (strAddNode == strNode) if (strAddNode == strNode)
{ {
laddedNodes.push_back(strAddNode); laddedNodes.push_back(strAddNode);
break; break;
} }
}
if (laddedNodes.size() == 0) if (laddedNodes.size() == 0)
throw JSONRPCError(RPC_CLIENT_NODE_NOT_ADDED, "Error: Node has not been added."); throw JSONRPCError(RPC_CLIENT_NODE_NOT_ADDED, "Error: Node has not been added.");
} }
@ -273,8 +274,7 @@ UniValue getaddednodeinfo(const UniValue& params, bool fHelp)
UniValue ret(UniValue::VARR); UniValue ret(UniValue::VARR);
if (!fDns) if (!fDns)
{ {
BOOST_FOREACH(string& strAddNode, laddedNodes) BOOST_FOREACH (const std::string& strAddNode, laddedNodes) {
{
UniValue obj(UniValue::VOBJ); UniValue obj(UniValue::VOBJ);
obj.push_back(Pair("addednode", strAddNode)); obj.push_back(Pair("addednode", strAddNode));
ret.push_back(obj); ret.push_back(obj);
@ -283,8 +283,7 @@ UniValue getaddednodeinfo(const UniValue& params, bool fHelp)
} }
list<pair<string, vector<CService> > > laddedAddreses(0); list<pair<string, vector<CService> > > laddedAddreses(0);
BOOST_FOREACH(string& strAddNode, laddedNodes) BOOST_FOREACH(const std::string& strAddNode, laddedNodes) {
{
vector<CService> vservNode(0); vector<CService> vservNode(0);
if(Lookup(strAddNode.c_str(), vservNode, Params().GetDefaultPort(), fNameLookup, 0)) if(Lookup(strAddNode.c_str(), vservNode, Params().GetDefaultPort(), fNameLookup, 0))
laddedAddreses.push_back(make_pair(strAddNode, vservNode)); laddedAddreses.push_back(make_pair(strAddNode, vservNode));
@ -306,12 +305,11 @@ UniValue getaddednodeinfo(const UniValue& params, bool fHelp)
UniValue addresses(UniValue::VARR); UniValue addresses(UniValue::VARR);
bool fConnected = false; bool fConnected = false;
BOOST_FOREACH(CService& addrNode, it->second) BOOST_FOREACH(const CService& addrNode, it->second) {
{
bool fFound = false; bool fFound = false;
UniValue node(UniValue::VOBJ); UniValue node(UniValue::VOBJ);
node.push_back(Pair("address", addrNode.ToString())); node.push_back(Pair("address", addrNode.ToString()));
BOOST_FOREACH(CNode* pnode, vNodes) BOOST_FOREACH(CNode* pnode, vNodes) {
if (pnode->addr == addrNode) if (pnode->addr == addrNode)
{ {
fFound = true; fFound = true;
@ -319,6 +317,7 @@ UniValue getaddednodeinfo(const UniValue& params, bool fHelp)
node.push_back(Pair("connected", pnode->fInbound ? "inbound" : "outbound")); node.push_back(Pair("connected", pnode->fInbound ? "inbound" : "outbound"));
break; break;
} }
}
if (!fFound) if (!fFound)
node.push_back(Pair("connected", "false")); node.push_back(Pair("connected", "false"));
addresses.push_back(node); addresses.push_back(node);

10
src/rpcserver.cpp
View file

@ -173,7 +173,7 @@ vector<unsigned char> ParseHexO(const UniValue& o, string strKey)
* Note: This interface may still be subject to change. * Note: This interface may still be subject to change.
*/ */
string CRPCTable::help(string strCommand) const std::string CRPCTable::help(const std::string& strCommand) const
{ {
string strRet; string strRet;
string category; string category;
@ -391,7 +391,7 @@ CRPCTable::CRPCTable()
} }
} }
const CRPCCommand *CRPCTable::operator[](string name) const const CRPCCommand *CRPCTable::operator[](const std::string& name) const
{ {
map<string, const CRPCCommand*>::const_iterator it = mapCommands.find(name); map<string, const CRPCCommand*>::const_iterator it = mapCommands.find(name);
if (it == mapCommands.end()) if (it == mapCommands.end())
@ -1026,11 +1026,13 @@ UniValue CRPCTable::execute(const std::string &strMethod, const UniValue &params
g_rpcSignals.PostCommand(*pcmd); g_rpcSignals.PostCommand(*pcmd);
} }
std::string HelpExampleCli(string methodname, string args){ std::string HelpExampleCli(const std::string& methodname, const std::string& args)
{
return "> bitcoin-cli " + methodname + " " + args + "\n"; return "> bitcoin-cli " + methodname + " " + args + "\n";
} }
std::string HelpExampleRpc(string methodname, string args){ std::string HelpExampleRpc(const std::string& methodname, const std::string& args)
{
return "> curl --user myusername --data-binary '{\"jsonrpc\": \"1.0\", \"id\":\"curltest\", " return "> curl --user myusername --data-binary '{\"jsonrpc\": \"1.0\", \"id\":\"curltest\", "
"\"method\": \"" + methodname + "\", \"params\": [" + args + "] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/\n"; "\"method\": \"" + methodname + "\", \"params\": [" + args + "] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/\n";
} }

8
src/rpcserver.h
View file

@ -110,8 +110,8 @@ private:
std::map<std::string, const CRPCCommand*> mapCommands; std::map<std::string, const CRPCCommand*> mapCommands;
public: public:
CRPCTable(); CRPCTable();
const CRPCCommand* operator[](std::string name) const; const CRPCCommand* operator[](const std::string& name) const;
std::string help(std::string name) const; std::string help(const std::string& name) const;
/** /**
* Execute a method. * Execute a method.
@ -142,8 +142,8 @@ extern CAmount AmountFromValue(const UniValue& value);
extern UniValue ValueFromAmount(const CAmount& amount); extern UniValue ValueFromAmount(const CAmount& amount);
extern double GetDifficulty(const CBlockIndex* blockindex = NULL); extern double GetDifficulty(const CBlockIndex* blockindex = NULL);
extern std::string HelpRequiringPassphrase(); extern std::string HelpRequiringPassphrase();
extern std::string HelpExampleCli(std::string methodname, std::string args); extern std::string HelpExampleCli(const std::string& methodname, const std::string& args);
extern std::string HelpExampleRpc(std::string methodname, std::string args); extern std::string HelpExampleRpc(const std::string& methodname, const std::string& args);
extern void EnsureWalletIsUnlocked(); extern void EnsureWalletIsUnlocked();

3
src/univalue/univalue.h
View file

@ -61,7 +61,7 @@ public:
bool setObject(); bool setObject();
enum VType getType() const { return typ; } enum VType getType() const { return typ; }
std::string getValStr() const { return val; } const std::string& getValStr() const { return val; }
bool empty() const { return (values.size() == 0); } bool empty() const { return (values.size() == 0); }
size_t size() const { return values.size(); } size_t size() const { return values.size(); }
@ -247,4 +247,3 @@ extern const UniValue NullUniValue;
const UniValue& find_value( const UniValue& obj, const std::string& name); const UniValue& find_value( const UniValue& obj, const std::string& name);
#endif // BITCOIN_UNIVALUE_UNIVALUE_H #endif // BITCOIN_UNIVALUE_UNIVALUE_H

2
src/util.cpp
View file

@ -702,7 +702,7 @@ boost::filesystem::path GetTempPath() {
#endif #endif
} }
void runCommand(std::string strCommand) void runCommand(const std::string& strCommand)
{ {
int nErr = ::system(strCommand.c_str()); int nErr = ::system(strCommand.c_str());
if (nErr) if (nErr)

2
src/util.h
View file

@ -126,7 +126,7 @@ boost::filesystem::path GetSpecialFolderPath(int nFolder, bool fCreate = true);
#endif #endif
boost::filesystem::path GetTempPath(); boost::filesystem::path GetTempPath();
void ShrinkDebugFile(); void ShrinkDebugFile();
void runCommand(std::string strCommand); void runCommand(const std::string& strCommand);
inline bool IsSwitchChar(char c) inline bool IsSwitchChar(char c)
{ {

2
src/utilstrencodings.cpp
View file

@ -471,7 +471,7 @@ bool ParseDouble(const std::string& str, double *out)
return endp && *endp == 0 && !errno; return endp && *endp == 0 && !errno;
} }
std::string FormatParagraph(const std::string in, size_t width, size_t indent) std::string FormatParagraph(const std::string& in, size_t width, size_t indent)
{ {
std::stringstream out; std::stringstream out;
size_t col = 0; size_t col = 0;

2
src/utilstrencodings.h
View file

@ -92,7 +92,7 @@ inline std::string HexStr(const T& vch, bool fSpaces=false)
* Format a paragraph of text to a fixed width, adding spaces for * Format a paragraph of text to a fixed width, adding spaces for
* indentation to any added line. * indentation to any added line.
*/ */
std::string FormatParagraph(const std::string in, size_t width=79, size_t indent=0); std::string FormatParagraph(const std::string& in, size_t width = 79, size_t indent = 0);
/** /**
* Timing-attack-resistant comparison. * Timing-attack-resistant comparison.

2
src/wallet/wallet.cpp
View file

@ -2414,7 +2414,7 @@ set< set<CTxDestination> > CWallet::GetAddressGroupings()
return ret; return ret;
} }
set<CTxDestination> CWallet::GetAccountAddresses(string strAccount) const std::set<CTxDestination> CWallet::GetAccountAddresses(const std::string& strAccount) const
{ {
LOCK(cs_wallet); LOCK(cs_wallet);
set<CTxDestination> result; set<CTxDestination> result;

4
src/wallet/wallet.h
View file

@ -496,7 +496,7 @@ public:
SetNull(); SetNull();
} }
CWallet(std::string strWalletFileIn) CWallet(const std::string& strWalletFileIn)
{ {
SetNull(); SetNull();
@ -645,7 +645,7 @@ public:
std::set< std::set<CTxDestination> > GetAddressGroupings(); std::set< std::set<CTxDestination> > GetAddressGroupings();
std::map<CTxDestination, CAmount> GetAddressBalances(); std::map<CTxDestination, CAmount> GetAddressBalances();
std::set<CTxDestination> GetAccountAddresses(std::string strAccount) const; std::set<CTxDestination> GetAccountAddresses(const std::string& strAccount) const;
isminetype IsMine(const CTxIn& txin) const; isminetype IsMine(const CTxIn& txin) const;
CAmount GetDebit(const CTxIn& txin, const isminefilter& filter) const; CAmount GetDebit(const CTxIn& txin, const isminefilter& filter) const;