From b8b4c80146780f9011abbd1be72343cc965c07b9 Mon Sep 17 00:00:00 2001 From: Matt Corallo Date: Thu, 17 Jan 2019 14:48:25 +1000 Subject: [PATCH] [refactor] drop IsInvalid(nDoSOut) Co-authored-by: Anthony Towns --- src/consensus/validation.h | 7 ------- src/test/txvalidation_tests.cpp | 4 ---- 2 files changed, 11 deletions(-) diff --git a/src/consensus/validation.h b/src/consensus/validation.h index 36142e1e4..163b17e62 100644 --- a/src/consensus/validation.h +++ b/src/consensus/validation.h @@ -71,13 +71,6 @@ public: bool IsError() const { return mode == MODE_ERROR; } - bool IsInvalid(int &nDoSOut) const { - if (IsInvalid()) { - nDoSOut = nDoS; - return true; - } - return false; - } bool CorruptionPossible() const { return corruptionPossible; } diff --git a/src/test/txvalidation_tests.cpp b/src/test/txvalidation_tests.cpp index c2777cd6d..4876c44f1 100644 --- a/src/test/txvalidation_tests.cpp +++ b/src/test/txvalidation_tests.cpp @@ -52,10 +52,6 @@ BOOST_FIXTURE_TEST_CASE(tx_mempool_reject_coinbase, TestChain100Setup) // Check that the validation state reflects the unsuccessful attempt. BOOST_CHECK(state.IsInvalid()); BOOST_CHECK_EQUAL(state.GetRejectReason(), "coinbase"); - - int nDoS; - BOOST_CHECK_EQUAL(state.IsInvalid(nDoS), true); - BOOST_CHECK_EQUAL(nDoS, 100); } BOOST_AUTO_TEST_SUITE_END()