LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

wallet_balance.py: Prevent edge cases

Browse source
This commit is contained in:
Steven Roose 2019-05-23 15:40:16 +01:00
parent 12fd4bbd1e
commit bb41e632ca
No known key found for this signature in database
GPG key ID: 2F2A88D7F8D68E87
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
test/functional/wallet_balance.py
View file

@ -28,12 +28,17 @@ def create_transactions(node, address, amt, fees):
for utxo in utxos: for utxo in utxos:
inputs.append({"txid": utxo["txid"], "vout": utxo["vout"]}) inputs.append({"txid": utxo["txid"], "vout": utxo["vout"]})
ins_total += utxo['amount'] ins_total += utxo['amount']
if ins_total + max(fees) > amt: if ins_total >= amt + max(fees):
break break
# make sure there was enough utxos
assert ins_total >= amt + max(fees)
txs = [] txs = []
for fee in fees: for fee in fees:
outputs = {address: amt, node.getrawchangeaddress(): ins_total - amt - fee} outputs = {address: amt}
# prevent 0 change output
if ins_total > amt + fee:
outputs[node.getrawchangeaddress()] = ins_total - amt - fee
raw_tx = node.createrawtransaction(inputs, outputs, 0, True) raw_tx = node.createrawtransaction(inputs, outputs, 0, True)
raw_tx = node.signrawtransactionwithwallet(raw_tx) raw_tx = node.signrawtransactionwithwallet(raw_tx)
assert_equal(raw_tx['complete'], True) assert_equal(raw_tx['complete'], True)